refactor: reuse variance in stats/base/dists/binomial/stdev

PR-URL: #11369
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>

Author: Om-A-osc

lib/node_modules/@stdlib/stats/base/dists/binomial/stdev/lib/main.js

@@ -20,10 +20,8 @@
 
 // MODULES //
 
-var isNonNegativeInteger = require( '@stdlib/math/base/assert/is-nonnegative-integer' );
-var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var sqrt = require( '@stdlib/math/base/special/sqrt' );
-var PINF = require( '@stdlib/constants/float64/pinf' );
+var variance = require( '@stdlib/stats/base/dists/binomial/variance' );
 
 
 // MAIN //
@@ -56,17 +54,7 @@ var PINF = require( '@stdlib/constants/float64/pinf' );
 * // returns NaN
 */
 function stdev( n, p ) {
-	if (
-		isnan( n ) ||
-		isnan( p ) ||
-		p < 0.0 ||
-		p > 1.0 ||
-		!isNonNegativeInteger( n ) ||
-		n === PINF
-	) {
-		return NaN;
-	}
-	return sqrt( n * p * ( 1.0 - p ) );
+	return sqrt( variance( n, p ) );
 }
 
 

lib/node_modules/@stdlib/stats/base/dists/binomial/stdev/manifest.json

@@ -39,8 +39,8 @@
       "libpath": [],
       "dependencies": [
         "@stdlib/math/base/napi/binary",
-        "@stdlib/math/base/assert/is-nan",
-        "@stdlib/math/base/special/sqrt"
+        "@stdlib/math/base/special/sqrt",
+        "@stdlib/stats/base/dists/binomial/variance"
       ]
     },
     {
@@ -55,9 +55,9 @@
       "libraries": [],
       "libpath": [],
       "dependencies": [
-        "@stdlib/math/base/assert/is-nan",
         "@stdlib/math/base/special/sqrt",
-        "@stdlib/math/base/special/ceil"
+        "@stdlib/math/base/special/ceil",
+        "@stdlib/stats/base/dists/binomial/variance"
       ]
     },
     {
@@ -72,9 +72,9 @@
       "libraries": [],
       "libpath": [],
       "dependencies": [
-        "@stdlib/math/base/assert/is-nan",
         "@stdlib/math/base/special/sqrt",
-        "@stdlib/math/base/special/ceil"
+        "@stdlib/math/base/special/ceil",
+        "@stdlib/stats/base/dists/binomial/variance"
       ]
     }
   ]

lib/node_modules/@stdlib/stats/base/dists/binomial/stdev/src/main.c

@@ -17,8 +17,8 @@
 */
 
 #include "stdlib/stats/base/dists/binomial/stdev.h"
-#include "stdlib/math/base/assert/is_nan.h"
 #include "stdlib/math/base/special/sqrt.h"
+#include "stdlib/stats/base/dists/binomial/variance.h"
 #include <stdint.h>
 
 /**
@@ -33,13 +33,5 @@
 * // returns 3.0
 */
 double stdlib_base_dists_binomial_stdev( const int32_t n, const double p ) {
-	if (
-		stdlib_base_is_nan( p ) ||
-		n < 0 ||
-		p < 0.0 ||
-		p > 1.0
-	) {
-		return 0.0 / 0.0;
-	}
-	return stdlib_base_sqrt( n * p * (1.0 - p) );
+	return stdlib_base_sqrt( stdlib_base_dists_binomial_variance( n, p ) );
 }