Skip to content

Commit 6599710

Browse files
committed
fix: apply suggestion from code review
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 6968e1a commit 6599710

1 file changed

Lines changed: 15 additions & 2 deletions

File tree

  • lib/node_modules/@stdlib/blas/ext/base/svander/src

lib/node_modules/@stdlib/blas/ext/base/svander/src/addon.c

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,16 +34,29 @@
3434
* @return Node-API value
3535
*/
3636
static napi_value addon( napi_env env, napi_callback_info info ) {
37+
CBLAS_INT sa1;
38+
CBLAS_INT sa2;
39+
3740
STDLIB_NAPI_ARGV( env, info, argv, argc, 8 );
3841
STDLIB_NAPI_ARGV_INT64( env, order, argv, 0 );
3942
STDLIB_NAPI_ARGV_FLOAT( env, mode, argv, 1 );
4043
STDLIB_NAPI_ARGV_INT64( env, M, argv, 2 );
4144
STDLIB_NAPI_ARGV_INT64( env, N, argv, 3 );
4245
STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 5 );
43-
STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, X, M, strideX, argv, 4 );
4446
STDLIB_NAPI_ARGV_INT64( env, LDO, argv, 7 );
45-
STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY2D( env, Out, M, N, LDO, 1, argv, 6 );
47+
48+
if ( order == CblasColMajor ) {
49+
sa1 = 1;
50+
sa2 = LDO;
51+
} else { // order == CblasRowMajor
52+
sa1 = LDO;
53+
sa2 = 1;
54+
}
55+
STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, X, M, strideX, argv, 4 );
56+
STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY2D( env, Out, M, N, sa1, sa2, argv, 6 );
57+
4658
API_SUFFIX(stdlib_strided_svander)( order, mode, M, N, X, strideX, Out, LDO );
59+
4760
return NULL;
4861
}
4962

0 commit comments

Comments
 (0)