Skip to content

Commit 6b79aec

Browse files
authored
test: migrate math/base/special/ceiln to ULP-based testing
PR-URL: #12751 Reviewed-by: Athan Reines <kgryte@gmail.com> Ref: #11352
1 parent 8117e16 commit 6b79aec

2 files changed

Lines changed: 4 additions & 22 deletions

File tree

lib/node_modules/@stdlib/math/base/special/ceiln/test/test.js

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,13 @@ var tape = require( 'tape' );
2424
var PI = require( '@stdlib/constants/float64/pi' );
2525
var PINF = require( '@stdlib/constants/float64/pinf' );
2626
var NINF = require( '@stdlib/constants/float64/ninf' );
27-
var EPS = require( '@stdlib/constants/float64/eps' );
2827
var randu = require( '@stdlib/random/base/randu' );
2928
var round = require( '@stdlib/math/base/special/round' );
3029
var pow = require( '@stdlib/math/base/special/pow' );
31-
var abs = require( '@stdlib/math/base/special/abs' );
3230
var isnan = require( '@stdlib/math/base/assert/is-nan' );
3331
var isNegativeZero = require( '@stdlib/math/base/assert/is-negative-zero' );
3432
var isPositiveZero = require( '@stdlib/math/base/assert/is-positive-zero' );
33+
var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' );
3534
var ceiln = require( './../lib' );
3635

3736

@@ -207,8 +206,6 @@ tape( 'if `n > 308` and `x < 0`, the function returns `-0` (sign preserving)', f
207206

208207
tape( 'the function supports rounding very small numbers (including subnormals)', function test( t ) {
209208
var expected;
210-
var delta;
211-
var tol;
212209
var x;
213210
var n;
214211
var v;
@@ -242,13 +239,7 @@ tape( 'the function supports rounding very small numbers (including subnormals)'
242239

243240
for ( i = 0; i < n.length; i++ ) {
244241
v = ceiln( x, n[i] );
245-
if ( v === expected[i] ) {
246-
t.strictEqual( v, expected[ i ], 'returns '+expected[i]+' when provided x='+x+' and n='+n[i]+'.' );
247-
} else {
248-
delta = abs( v - expected[i] );
249-
tol = EPS * abs( expected[i] );
250-
t.strictEqual( delta <= tol, true, 'x: '+x+'. n: '+n[i]+'. v: '+v+'. expected: '+expected[i]+'. delta: '+delta+'. tol: '+tol );
251-
}
242+
t.strictEqual( isAlmostSameValue( v, expected[ i ], 1 ), true, 'returns expected value' );
252243
}
253244
t.end();
254245
});

lib/node_modules/@stdlib/math/base/special/ceiln/test/test.native.js

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,13 @@ var tape = require( 'tape' );
2525
var PI = require( '@stdlib/constants/float64/pi' );
2626
var PINF = require( '@stdlib/constants/float64/pinf' );
2727
var NINF = require( '@stdlib/constants/float64/ninf' );
28-
var EPS = require( '@stdlib/constants/float64/eps' );
2928
var randu = require( '@stdlib/random/base/randu' );
3029
var round = require( '@stdlib/math/base/special/round' );
3130
var pow = require( '@stdlib/math/base/special/pow' );
32-
var abs = require( '@stdlib/math/base/special/abs' );
3331
var isnan = require( '@stdlib/math/base/assert/is-nan' );
3432
var isNegativeZero = require( '@stdlib/math/base/assert/is-negative-zero' );
3533
var isPositiveZero = require( '@stdlib/math/base/assert/is-positive-zero' );
34+
var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' );
3635
var tryRequire = require( '@stdlib/utils/try-require' );
3736

3837

@@ -198,8 +197,6 @@ tape( 'if `n > 308` and `x < 0`, the function returns `-0` (sign preserving)', o
198197

199198
tape( 'the function supports rounding very small numbers (including subnormals)', opts, function test( t ) {
200199
var expected;
201-
var delta;
202-
var tol;
203200
var x;
204201
var n;
205202
var v;
@@ -233,13 +230,7 @@ tape( 'the function supports rounding very small numbers (including subnormals)'
233230

234231
for ( i = 0; i < n.length; i++ ) {
235232
v = ceiln( x, n[i] );
236-
if ( v === expected[i] ) {
237-
t.strictEqual( v, expected[ i ], 'returns '+expected[i]+' when provided x='+x+' and n='+n[i]+'.' );
238-
} else {
239-
delta = abs( v - expected[i] );
240-
tol = EPS * abs( expected[i] );
241-
t.strictEqual( delta <= tol, true, 'x: '+x+'. n: '+n[i]+'. v: '+v+'. expected: '+expected[i]+'. delta: '+delta+'. tol: '+tol );
242-
}
233+
t.strictEqual( isAlmostSameValue( v, expected[ i ], 1 ), true, 'returns expected value' );
243234
}
244235
t.end();
245236
});

0 commit comments

Comments
 (0)