Skip to content

Commit 6f1f614

Browse files
test: migrate math/base/special/acosd to ULP-based testing
PR-URL: #11601 Reviewed-by: Athan Reines <kgryte@gmail.com> Ref: #11352
1 parent aaa6e06 commit 6f1f614

2 files changed

Lines changed: 6 additions & 38 deletions

File tree

lib/node_modules/@stdlib/math/base/special/acosd/test/test.js

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
var tape = require( 'tape' );
2424
var isnan = require( '@stdlib/math/base/assert/is-nan' );
25-
var abs = require( '@stdlib/math/base/special/abs' );
25+
var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' );
2626
var randu = require( '@stdlib/random/base/randu' );
2727
var EPS = require( '@stdlib/constants/float64/eps' );
2828
var isPositiveZero = require( '@stdlib/assert/is-positive-zero' );
@@ -51,8 +51,6 @@ tape( 'the function returns `NaN` if provided `NaN`', function test( t ) {
5151

5252
tape( 'the function computes the arccosine in degrees (negative values)', function test( t ) {
5353
var expected;
54-
var delta;
55-
var tol;
5654
var x;
5755
var y;
5856
var i;
@@ -62,21 +60,13 @@ tape( 'the function computes the arccosine in degrees (negative values)', functi
6260

6361
for ( i = 0; i < x.length; i++ ) {
6462
y = acosd( x[i] );
65-
if ( y === expected[ i ] ) {
66-
t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] );
67-
} else {
68-
delta = abs( y - expected[i] );
69-
tol = 1.4 * EPS * abs( expected[i] );
70-
t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' );
71-
}
63+
t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' );
7264
}
7365
t.end();
7466
});
7567

7668
tape( 'the function computes the arccosine in degrees (positive values)', function test( t ) {
7769
var expected;
78-
var delta;
79-
var tol;
8070
var x;
8171
var y;
8272
var i;
@@ -86,13 +76,7 @@ tape( 'the function computes the arccosine in degrees (positive values)', functi
8676

8777
for ( i = 0; i < x.length; i++ ) {
8878
y = acosd( x[i] );
89-
if ( y === expected[ i ] ) {
90-
t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] );
91-
} else {
92-
delta = abs( y - expected[i] );
93-
tol = 1.4 * EPS * abs( expected[i] );
94-
t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' );
95-
}
79+
t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' );
9680
}
9781
t.end();
9882
});

lib/node_modules/@stdlib/math/base/special/acosd/test/test.native.js

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
var resolve = require( 'path' ).resolve;
2424
var tape = require( 'tape' );
2525
var isnan = require( '@stdlib/math/base/assert/is-nan' );
26-
var abs = require( '@stdlib/math/base/special/abs' );
26+
var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' );
2727
var randu = require( '@stdlib/random/base/randu' );
2828
var EPS = require( '@stdlib/constants/float64/eps' );
2929
var isPositiveZero = require( '@stdlib/assert/is-positive-zero' );
@@ -60,8 +60,6 @@ tape( 'the function returns `NaN` if provided `NaN`', opts, function test( t ) {
6060

6161
tape( 'the function computes the arccosine in degrees (negative values)', opts, function test( t ) {
6262
var expected;
63-
var delta;
64-
var tol;
6563
var x;
6664
var y;
6765
var i;
@@ -71,21 +69,13 @@ tape( 'the function computes the arccosine in degrees (negative values)', opts,
7169

7270
for ( i = 0; i < x.length; i++ ) {
7371
y = acosd( x[i] );
74-
if ( y === expected[ i ] ) {
75-
t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] );
76-
} else {
77-
delta = abs( y - expected[i] );
78-
tol = 1.4 * EPS * abs( expected[i] );
79-
t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' );
80-
}
72+
t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' );
8173
}
8274
t.end();
8375
});
8476

8577
tape( 'the function computes the arccosine in degrees (positive values)', opts, function test( t ) {
8678
var expected;
87-
var delta;
88-
var tol;
8979
var x;
9080
var y;
9181
var i;
@@ -95,13 +85,7 @@ tape( 'the function computes the arccosine in degrees (positive values)', opts,
9585

9686
for ( i = 0; i < x.length; i++ ) {
9787
y = acosd( x[i] );
98-
if ( y === expected[ i ] ) {
99-
t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] );
100-
} else {
101-
delta = abs( y - expected[i] );
102-
tol = 1.4 * EPS * abs( expected[i] );
103-
t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' );
104-
}
88+
t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' );
10589
}
10690
t.end();
10791
});

0 commit comments

Comments
 (0)