Skip to content

Commit 73503f2

Browse files
committed
fix: apply suggestions from code review
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 15b01de commit 73503f2

File tree

2 files changed

+18
-7
lines changed

2 files changed

+18
-7
lines changed

lib/node_modules/@stdlib/blas/ext/base/dcartesian-square/lib/ndarray.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,10 @@ var dcopy = require( '@stdlib/blas/base/dcopy' ).ndarray;
5555
*/
5656
function dcartesianSquare( N, x, strideX, offsetX, out, strideOut1, strideOut2, offsetOut ) { // eslint-disable-line max-len
5757
var ix;
58+
var jx;
5859
var io;
5960
var i;
61+
var j;
6062

6163
if ( N <= 0 ) {
6264
return out;
@@ -65,10 +67,14 @@ function dcartesianSquare( N, x, strideX, offsetX, out, strideOut1, strideOut2,
6567
io = offsetOut;
6668
if ( isRowMajor( [ strideOut1, strideOut2 ] ) ) {
6769
for ( i = 0; i < N; i++ ) {
68-
dfill( N, x[ ix ], out, strideOut1, io );
69-
dcopy( N, x, strideX, offsetX, out, strideOut1, io + strideOut2 );
70+
jx = offsetX;
71+
for ( j = 0; j < N; j++ ) {
72+
out[ io ] = x[ ix ];
73+
out[ io + strideOut2 ] = x[ jx ];
74+
jx += strideX;
75+
io += strideOut1;
76+
}
7077
ix += strideX;
71-
io += N * strideOut1;
7278
}
7379
} else { // order === 'column-major'
7480
for ( i = 0; i < N; i++ ) {

lib/node_modules/@stdlib/blas/ext/base/dcartesian-square/src/main.c

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,10 @@ void API_SUFFIX(stdlib_strided_dcartesian_square_ndarray)( const CBLAS_INT N, co
6767
int64_t sa[ 2 ];
6868
CBLAS_INT isrm;
6969
CBLAS_INT ix;
70+
CBLAS_INT jx;
7071
CBLAS_INT io;
7172
CBLAS_INT i;
73+
CBLAS_INT j;
7274
double v;
7375

7476
if ( N <= 0 ) {
@@ -81,11 +83,14 @@ void API_SUFFIX(stdlib_strided_dcartesian_square_ndarray)( const CBLAS_INT N, co
8183
ix = offsetX;
8284
io = offsetOut;
8385
for ( i = 0; i < N; i++ ) {
84-
v = X[ ix ];
86+
jx = offsetX;
87+
for ( j = 0; j < N; j++ ) {
88+
Out[ io ] = X[ ix ];
89+
Out[ io + strideOut2 ] = X[ jx ];
90+
jx += strideX;
91+
io += strideOut1;
92+
}
8593
ix += strideX;
86-
API_SUFFIX(stdlib_strided_dfill_ndarray)( N, v, Out, strideOut1, io );
87-
API_SUFFIX(c_dcopy_ndarray)( N, X, strideX, offsetX, Out, strideOut1, io + strideOut2 );
88-
io += N * strideOut1;
8994
}
9095
} else { // isColMajor
9196
ix = offsetX;

0 commit comments

Comments
 (0)