Skip to content

Commit 8156089

Browse files
DivitJain26DivitJain26
committed
test: remove strideA1 and strideA2 validations and tests
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent c025bd0 commit 8156089

3 files changed

Lines changed: 17 additions & 89 deletions

File tree

‎lib/node_modules/@stdlib/blas/base/cgbmv/lib/cgbmv.js‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,12 @@ var base = require( './base.js' );
5555
* @throws {TypeError} second argument must be a valid transpose operation
5656
* @throws {RangeError} third argument must be a nonnegative integer
5757
* @throws {RangeError} fourth argument must be a nonnegative integer
58-
* @throws {RangeError} seventh argument must be greater than or equal KL + KU + 1
58+
* @throws {RangeError} fifth argument must be a nonnegative integer
59+
* @throws {RangeError} sixth argument must be a nonnegative integer
60+
* @throws {RangeError} ninth argument must be greater than or equal KL + KU + 1
5961
* @throws {RangeError} ninth argument must be non-zero
60-
* @throws {RangeError} twelfth argument must be non-zero
62+
* @throws {RangeError} eleventh argument must be non-zero
63+
* @throws {RangeError} fourteenth argument must be non-zero
6164
* @returns {Complex64Array} `y`
6265
*
6366
* @example
@@ -103,7 +106,7 @@ function cgbmv( order, trans, M, N, KL, KU, alpha, A, LDA, x, strideX, beta, y,
103106
if ( KU < 0 ) {
104107
throw new RangeError( format( 'invalid argument. Sixth argument must be a nonnegative integer. Value: `%d`.', KU ) );
105108
}
106-
if ( LDA < KL + KU + 1 ) {
109+
if ( LDA < ( KL + KU + 1 ) ) {
107110
throw new RangeError( format( 'invalid argument. ninth argument is not a valid integer. Value: `%d`.', ( KL + KU + 1 ) ) );
108111
}
109112
if ( strideX === 0 ) {

‎lib/node_modules/@stdlib/blas/base/cgbmv/lib/ndarray.js‎

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,10 @@ var base = require( './base.js' );
5555
* @throws {TypeError} first argument must be a valid transpose operation
5656
* @throws {RangeError} second argument must be a nonnegative integer
5757
* @throws {RangeError} third argument must be a nonnegative integer
58-
* @throws {RangeError} eighth argument must be non-zero
59-
* @throws {RangeError} ninth argument must be non-zero
60-
* @throws {RangeError} fourteenth argument must be non-zero
58+
* @throws {RangeError} fourth argument must be a nonnegative integer
59+
* @throws {RangeError} fifth argument must be a nonnegative integer
60+
* @throws {RangeError} twelfth argument must be non-zero
61+
* @throws {RangeError} sixteenth argument must be non-zero
6162
* @returns {Complex64Array} `y`
6263
*
6364
* @example
@@ -80,31 +81,25 @@ function cgbmv( trans, M, N, KL, KU, alpha, A, strideA1, strideA2, offsetA, x, s
8081
var imbeta;
8182

8283
if ( !isMatrixTranspose( trans ) ) {
83-
throw new TypeError( format( 'invalid argument. Second argument must be a valid transpose operation. Value: `%s`.', trans ) );
84+
throw new TypeError( format( 'invalid argument. First argument must be a valid transpose operation. Value: `%s`.', trans ) );
8485
}
8586
if ( M < 0 ) {
86-
throw new RangeError( format( 'invalid argument. Third argument must be a nonnegative integer. Value: `%d`.', M ) );
87+
throw new RangeError( format( 'invalid argument. Second argument must be a nonnegative integer. Value: `%d`.', M ) );
8788
}
8889
if ( N < 0 ) {
89-
throw new RangeError( format( 'invalid argument. Fourth argument must be a nonnegative integer. Value: `%d`.', N ) );
90+
throw new RangeError( format( 'invalid argument. Third argument must be a nonnegative integer. Value: `%d`.', N ) );
9091
}
9192
if ( KL < 0 ) {
92-
throw new RangeError( format( 'invalid argument. Fifth argument must be a nonnegative integer. Value: `%d`.', KL ) );
93+
throw new RangeError( format( 'invalid argument. Fourth argument must be a nonnegative integer. Value: `%d`.', KL ) );
9394
}
9495
if ( KU < 0 ) {
95-
throw new RangeError( format( 'invalid argument. Sixth argument must be a nonnegative integer. Value: `%d`.', KU ) );
96-
}
97-
if ( strideA1 === 0 ) {
98-
throw new RangeError( format( 'invalid argument. Eighth argument must be non-zero. Value: `%d`.', strideA1 ) );
99-
}
100-
if ( strideA2 === 0 ) {
101-
throw new RangeError( format( 'invalid argument. Ninth argument must be non-zero. Value: `%d`.', strideA2 ) );
96+
throw new RangeError( format( 'invalid argument. Fifth argument must be a nonnegative integer. Value: `%d`.', KU ) );
10297
}
10398
if ( strideX === 0 ) {
104-
throw new RangeError( format( 'invalid argument. Thirtheenth argument must be non-zero. Value: `%d`.', strideX ) );
99+
throw new RangeError( format( 'invalid argument. Twelfth argument must be non-zero. Value: `%d`.', strideX ) );
105100
}
106101
if ( strideY === 0 ) {
107-
throw new RangeError( format( 'invalid argument. Seventeenth argument must be non-zero. Value: `%d`.', strideY ) );
102+
throw new RangeError( format( 'invalid argument. Sixteenth argument must be non-zero. Value: `%d`.', strideY ) );
108103
}
109104
rebeta = realf( beta );
110105
imbeta = imagf( beta );

‎lib/node_modules/@stdlib/blas/base/cgbmv/test/test.ndarray.js‎

Lines changed: 0 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -262,76 +262,6 @@ tape( 'the function throws an error if provided an invalid fifth argument', func
262262
}
263263
});
264264

265-
tape( 'the function throws an error if provided an invalid eighth argument', function test( t ) {
266-
var values;
267-
var alpha;
268-
var data;
269-
var beta;
270-
var i;
271-
var a;
272-
var x;
273-
var y;
274-
275-
data = rnt;
276-
277-
a = new Complex64Array( data.A );
278-
x = new Complex64Array( data.x );
279-
y = new Complex64Array( data.y );
280-
281-
alpha = new Complex64( data.alpha[0], data.alpha[1] );
282-
beta = new Complex64( data.beta[0], data.beta[1] );
283-
284-
values = [
285-
0
286-
];
287-
288-
for ( i = 0; i < values.length; i++ ) {
289-
t.throws( badValue( values[ i ] ), RangeError, 'throws an error when provided ' + values[ i ] );
290-
}
291-
t.end();
292-
293-
function badValue( value ) {
294-
return function badValue() {
295-
cgbmv( data.trans, data.M, data.N, data.KL, data.KU, alpha, a, value, data.strideA2, data.offsetA, x, data.strideX, data.offsetX, beta, y, data.strideY, data.offsetY );
296-
};
297-
}
298-
});
299-
300-
tape( 'the function throws an error if provided an invalid ninth argument', function test( t ) {
301-
var values;
302-
var alpha;
303-
var data;
304-
var beta;
305-
var i;
306-
var a;
307-
var x;
308-
var y;
309-
310-
data = rnt;
311-
312-
a = new Complex64Array( data.A );
313-
x = new Complex64Array( data.x );
314-
y = new Complex64Array( data.y );
315-
316-
alpha = new Complex64( data.alpha[0], data.alpha[1] );
317-
beta = new Complex64( data.beta[0], data.beta[1] );
318-
319-
values = [
320-
0
321-
];
322-
323-
for ( i = 0; i < values.length; i++ ) {
324-
t.throws( badValue( values[ i ] ), RangeError, 'throws an error when provided ' + values[ i ] );
325-
}
326-
t.end();
327-
328-
function badValue( value ) {
329-
return function badValue() {
330-
cgbmv( data.trans, data.M, data.N, data.KL, data.KU, alpha, a, data.strideA1, value, data.offsetA, x, data.strideX, data.offsetX, beta, y, data.strideY, data.offsetY );
331-
};
332-
}
333-
});
334-
335265
tape( 'the function throws an error if provided an invalid twelfth argument', function test( t ) {
336266
var values;
337267
var alpha;

0 commit comments

Comments
 (0)