Skip to content

Commit 8857862

Browse files
authored
Apply suggestions from code review
Signed-off-by: Athan <kgryte@gmail.com>
1 parent d7c710e commit 8857862

File tree

4 files changed

+11
-8
lines changed

4 files changed

+11
-8
lines changed

lib/node_modules/@stdlib/stats/base/ndarray/stdevch/README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ limitations under the License.
2020

2121
# stdevch
2222

23-
> Calculate the [standard deviation][standard-deviation] of a one-dimensional ndarray using a one-pass trial mean algorithm
23+
> Calculate the [standard deviation][standard-deviation] of a one-dimensional ndarray using a one-pass trial mean algorithm.
2424
2525
<section class="intro">
2626

@@ -100,14 +100,14 @@ var stdevch = require( '@stdlib/stats/base/ndarray/stdevch' );
100100

101101
#### stdevch( arrays )
102102

103-
Computes the [standard deviation][standard-deviation] of a one-dimensional ndarray using a one-pass trial mean algorithm
103+
Computes the [standard deviation][standard-deviation] of a one-dimensional ndarray using a one-pass trial mean algorithm.
104104

105105
```javascript
106106
var ndarray = require( '@stdlib/ndarray/base/ctor' );
107107
var scalar2ndarray = require( '@stdlib/ndarray/from-scalar' );
108108

109109
var opts = {
110-
'dtype': 'float64'
110+
'dtype': 'generic'
111111
};
112112

113113
var xbuf = [ 1.0, -2.0, 2.0 ];
@@ -145,7 +145,6 @@ The function has the following parameters:
145145

146146
```javascript
147147
var discreteUniform = require( '@stdlib/random/array/discrete-uniform' );
148-
var Float64Array = require( '@stdlib/array/float64' );
149148
var ndarray = require( '@stdlib/ndarray/base/ctor' );
150149
var scalar2ndarray = require( '@stdlib/ndarray/from-scalar' );
151150
var ndarray2array = require( '@stdlib/ndarray/to-array' );

lib/node_modules/@stdlib/stats/base/ndarray/stdevch/benchmark/benchmark.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ var stdevch = require( './../lib' );
3434
// VARIABLES //
3535

3636
var options = {
37-
'dtype': 'float64'
37+
'dtype': 'generic'
3838
};
3939

4040

lib/node_modules/@stdlib/stats/base/ndarray/stdevch/docs/types/index.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ import { typedndarray } from '@stdlib/types/ndarray';
4444
* var v = stdevch( [ x, correction ] );
4545
* // returns ~2.0817
4646
*/
47-
declare function stdevch<T extends typedndarray = typedndarray>( arrays: [ T, T ] ): number;
47+
declare function stdevch<T extends typedndarray<number> = typedndarray<number>>( arrays: [ T, T ] ): number;
4848

4949

5050
// EXPORTS //

lib/node_modules/@stdlib/stats/base/ndarray/stdevch/docs/types/test.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,9 @@ import stdevch = require( './index' );
3030
const x = zeros( [ 10 ], {
3131
'dtype': 'float64'
3232
});
33-
const correction = scalar2ndarray( 1.0, { 'dtype': 'float64' } );
33+
const correction = scalar2ndarray( 1.0, {
34+
'dtype': 'float64'
35+
});
3436

3537
stdevch( [ x, correction ] ); // $ExpectType number
3638
}
@@ -53,7 +55,9 @@ import stdevch = require( './index' );
5355
const x = zeros( [ 10 ], {
5456
'dtype': 'float64'
5557
});
56-
const correction = scalar2ndarray( 1.0, { 'dtype': 'float64' } );
58+
const correction = scalar2ndarray( 1.0, {
59+
'dtype': 'float64'
60+
});
5761

5862
stdevch(); // $ExpectError
5963
stdevch( [ x, correction ], 10 ); // $ExpectError

0 commit comments

Comments
 (0)