refactor!: remove NaN checks and optimize implementation for better performance

PR-URL: #11699
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>

Author: impawstarlight

lib/node_modules/@stdlib/number/int32/base/muldw/benchmark/benchmark.js

@@ -21,7 +21,7 @@
 // MODULES //
 
 var bench = require( '@stdlib/bench' );
-var minstd = require( '@stdlib/random/base/minstd' );
+var discreteUniform = require( '@stdlib/random/array/discrete-uniform' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var format = require( '@stdlib/string/format' );
 var pkg = require( './../package.json' ).name;
@@ -33,12 +33,17 @@ var imuldw = require( './../lib' );
 bench( pkg, function benchmark( b ) {
 	var x;
 	var y;
+	var z;
 	var i;
 
+	x = discreteUniform( 100, 0x10000, 0x10000000, {
+		'dtype': 'int32'
+	});
+
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
-		x = minstd();
-		y = imuldw( x, x );
+		z = x[ i%x.length ];
+		y = imuldw( z, z );
 		if ( isnan( y[ 0 ] ) ) {
 			b.fail( 'should not return NaN' );
 		}
@@ -55,14 +60,19 @@ bench( format( '%s:assign', pkg ), function benchmark( b ) {
 	var out;
 	var x;
 	var y;
+	var z;
 	var i;
 
+	x = discreteUniform( 100, 0x10000, 0x10000000, {
+		'dtype': 'int32'
+	});
+
 	out = [ 0.0, 0.0 ];
 
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
-		x = minstd();
-		y = imuldw.assign( x, x, out, 1, 0 );
+		z = x[ i%x.length ];
+		y = imuldw.assign( z, z, out, 1, 0 );
 		if ( isnan( y[ 0 ] ) ) {
 			b.fail( 'should not return NaN' );
 		}

lib/node_modules/@stdlib/number/int32/base/muldw/lib/assign.js

@@ -20,7 +20,7 @@
 
 // MODULES //
 
-var isnan = require( '@stdlib/math/base/assert/is-nan' );
+var imul = require( '@stdlib/number/int32/base/mul' );
 
 
 // VARIABLES //
@@ -48,19 +48,13 @@ var LOW_WORD_MASK = 0x0000ffff>>>0; // asm type annotation
 function imuldw( a, b, out, stride, offset ) {
 	var w1;
 	var w2;
-	var w3;
 	var ha;
 	var hb;
 	var la;
 	var lb;
 	var t;
 	var k;
 
-	if ( isnan( a ) || isnan( b ) ) {
-		out[ offset ] = NaN;
-		out[ offset + stride ] = NaN;
-		return out;
-	}
 	a |= 0; // asm type annotation
 	b |= 0; // asm type annotation
 
@@ -71,7 +65,6 @@ function imuldw( a, b, out, stride, offset ) {
 	lb = ( b & LOW_WORD_MASK ) >>> 0;
 
 	t = ( la*lb ) >>> 0;
-	w3 = ( t & LOW_WORD_MASK ) >>> 0;
 	k = ( t >>> 16 ) >>> 0;
 
 	t = ( ( ha*lb ) + k ) >>> 0;
@@ -82,7 +75,7 @@ function imuldw( a, b, out, stride, offset ) {
 	k = ( t >> 16 ) >>> 0;
 
 	out[ offset ] = ( ( ha*hb ) + w1 + k ) | 0; // compute the higher 32 bits and cast to a signed 32-bit integer
-	out[ offset + stride ] = ( ( t << 16 ) + w3 ) | 0; // compute the lower 32 bits and cast to a signed 32-bit integer
+	out[ offset + stride ] = imul( a, b ) | 0; // compute the lower 32 bits and cast to a signed 32-bit integer
 
 	return out;
 }

lib/node_modules/@stdlib/number/int32/base/muldw/test/test.assign.js

@@ -21,7 +21,6 @@
 // MODULES //
 
 var tape = require( 'tape' );
-var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var Float64Array = require( '@stdlib/array/float64' );
 var imuldw = require( './../lib/assign.js' );
 
@@ -39,31 +38,6 @@ tape( 'main export is a function', function test( t ) {
 	t.end();
 });
 
-tape( 'the function returns `NaN` if provided `NaN`', function test( t ) {
-	var out;
-	var v;
-
-	out = [ 0, 0 ];
-	v = imuldw( NaN, 1, out, 1, 0 );
-	t.strictEqual( v, out, 'returns output array' );
-	t.strictEqual( isnan( v[0] ), true, 'returns expected value' );
-	t.strictEqual( isnan( v[1] ), true, 'returns expected value' );
-
-	out = [ 0, 0 ];
-	v = imuldw( 1, NaN, out, 1, 0 );
-	t.strictEqual( v, out, 'returns output array' );
-	t.strictEqual( isnan( v[0] ), true, 'returns expected value' );
-	t.strictEqual( isnan( v[1] ), true, 'returns expected value' );
-
-	out = [ 0, 0 ];
-	v = imuldw( NaN, NaN, out, 1, 0 );
-	t.strictEqual( v, out, 'returns output array' );
-	t.strictEqual( isnan( v[0] ), true, 'returns expected value' );
-	t.strictEqual( isnan( v[1] ), true, 'returns expected value' );
-
-	t.end();
-});
-
 tape( 'the function computes the double word product of two (signed) words', function test( t ) {
 	var expected;
 	var actual;

lib/node_modules/@stdlib/number/int32/base/muldw/test/test.main.js

@@ -21,7 +21,6 @@
 // MODULES //
 
 var tape = require( 'tape' );
-var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var imuldw = require( './../lib/main.js' );
 
 
@@ -38,24 +37,6 @@ tape( 'main export is a function', function test( t ) {
 	t.end();
 });
 
-tape( 'the function returns `NaN` if provided `NaN`', function test( t ) {
-	var v;
-
-	v = imuldw( NaN, 1 );
-	t.strictEqual( isnan( v[0] ), true, 'returns expected value' );
-	t.strictEqual( isnan( v[1] ), true, 'returns expected value' );
-
-	v = imuldw( 1, NaN );
-	t.strictEqual( isnan( v[0] ), true, 'returns expected value' );
-	t.strictEqual( isnan( v[1] ), true, 'returns expected value' );
-
-	v = imuldw( NaN, NaN );
-	t.strictEqual( isnan( v[0] ), true, 'returns expected value' );
-	t.strictEqual( isnan( v[1] ), true, 'returns expected value' );
-
-	t.end();
-});
-
 tape( 'the function computes the double word product of two (signed) words', function test( t ) {
 	var expected;
 	var actual;