chore: apply requested changes

Author: LoayAhmed304

lib/node_modules/@stdlib/ndarray/base/where/README.md

@@ -47,24 +47,24 @@ var Float64Array = require( '@stdlib/array/float64' );
 var Uint8Array = require( '@stdlib/array/uint8' );
 
 // Create data buffers:
-var cbuf = new Uint8Array( [ 1, 0, 0, 1, 0, 1, 1, 0, 1, 0, 0, 1 ] );
-var xbuf = new Float64Array( [ 1.0, 2.0, 3.0, 4.0, 5.0, 6.0, 7.0, 8.0, 9.0, 10.0, 11.0, 12.0 ] );
-var ybuf = new Float64Array( [ -1.0, -2.0, -3.0, -4.0, -5.0, -6.0, -7.0, -8.0, -9.0, -10.0, -11.0, -12.0 ] );
+var cbuf = new Uint8Array( [ 1, 0, 0, 1, 0, 1 ] );
+var xbuf = new Float64Array( [ 1.0, 2.0, 3.0, 4.0, 5.0, 6.0 ] );
+var ybuf = new Float64Array( [ -1.0, -2.0, -3.0, -4.0, -5.0, -6.0 ] );
 var obuf = new Float64Array( 6 );
 
 // Define the shape of the input and output arrays:
 var shape = [ 3, 1, 2 ];
 
 // Define the array strides:
-var sc = [ 4, 4, 1 ];
-var sx = [ 4, 4, 1 ];
-var sy = [ 4, 4, 1 ];
+var sc = [ 2, 2, 1 ];
+var sx = [ 2, 2, 1 ];
+var sy = [ 2, 2, 1 ];
 var so = [ 2, 2, 1 ];
 
 // Define the index offsets:
-var oc = 1;
-var ox = 1;
-var oy = 1;
+var oc = 0;
+var ox = 0;
+var oy = 0;
 var oo = 0;
 
 // Create the input and output ndarrays:
@@ -105,7 +105,7 @@ var out = {
 where( [ condition, x, y, out ] );
 
 console.log( out.data );
-// => <Float64Array>[ -2.0, -3.0, 6.0, 7.0, -10.0, -11.0 ]
+// => <Float64Array>[ 1.0, -2.0, -3.0, 4.0, -5.0, 6.0 ]
 ```
 
 The function accepts the following arguments:
@@ -131,7 +131,6 @@ Each provided ndarray should be an object with the following properties:
 
 -   `condition` ndarray must be a `boolean` or `uint8` ndarray.
 -   `condition`, `x`, `y`, and `out` ndarrays must have the same shape.
--   `x` and `y` must have the same data type.
 -   The function **mutates** the input ndarrays shapes and strides if necessary.
 -   For very high-dimensional ndarrays which are non-contiguous, one should consider copying the underlying data to contiguous memory before conditionally assigning elements in order to achieve better performance.
 

lib/node_modules/@stdlib/ndarray/base/where/docs/repl.txt

@@ -1,7 +1,7 @@
 
 {{alias}}( arrays )
-    Applies a condition to elements in two input ndarrays
-    and assigns results to elements in an output ndarray.
+    Applies a condition to elements in two input ndarrays and assigns results
+    to elements in an output ndarray.
 
     Each provided "ndarray" should be an object with the following properties:
 

lib/node_modules/@stdlib/ndarray/base/where/docs/types/index.d.ts

@@ -30,7 +30,6 @@ import { ndarray } from '@stdlib/types/ndarray';
 * @throws arrays must have the same number of dimensions
 * @throws arrays must have the same shape
 * @throws {Error} condition array must be a boolean or uint8 ndarray
-* @throws {Error} x and y ndarrays must have the same dtype
 *
 * @example
 * var Float64Array = require( '@stdlib/array/float64' );

lib/node_modules/@stdlib/ndarray/base/where/lib/main.js

@@ -16,6 +16,8 @@
 * limitations under the License.
 */
 
+/* eslint-disable max-lines */
+
 'use strict';
 
 // MODULES //
@@ -25,6 +27,7 @@ var isComplexDataType = require( '@stdlib/ndarray/base/assert/is-complex-floatin
 var isRealDataType = require( '@stdlib/ndarray/base/assert/is-real-data-type' );
 var isComplexArray = require( '@stdlib/array/base/assert/is-complex-typed-array' );
 var isBooleanArray = require( '@stdlib/array/base/assert/is-booleanarray' );
+var isUint8Array = require( '@stdlib/assert/is-uint8array' );
 var iterationOrder = require( '@stdlib/ndarray/base/iteration-order' );
 var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 var anyIsEntryIn = require( '@stdlib/array/base/any-is-entry-in' );
@@ -148,10 +151,11 @@ var COMPLEX_TO_REAL = { // WARNING: this table needs to be manually updated if w
 * @param {ndarrayLike} x - first ndarray
 * @param {ndarrayLike} y - second ndarray
 * @param {ndarrayLike} z - third ndarray
+* @param {ndarrayLike} w - fourth ndarray
 * @returns {boolean} boolean indicating whether an ndarray data buffer implements the accessor protocol
 */
-function hasAccessors( x, y, z ) {
-	return anyIsEntryIn( [ x, y, z ], 'accessorProtocol', true );
+function hasAccessors( x, y, z, w ) {
+	return anyIsEntryIn( [ x, y, z, w ], 'accessorProtocol', true );
 }
 
 /**
@@ -224,7 +228,6 @@ function complex2real( x ) {
 * @throws {Error} arrays must have the same number of dimensions
 * @throws {Error} arrays must have the same shape
 * @throws {Error} condition array must be a boolean or uint8 ndarray
-* @throws {Error} x and y ndarrays must have the same dtype
 * @returns {void}
 *
 * @example
@@ -292,7 +295,7 @@ function complex2real( x ) {
 * console.log( out.data );
 * // => <Float64Array>[ -2.0, -3.0, 6.0, 7.0, -10.0, -11.0 ]
 */
-function where( arrays ) {
+function where( arrays ) { // eslint-disable-line max-statements
 	var ndims;
 	var cmmv;
 	var xmmv;
@@ -330,12 +333,18 @@ function where( arrays ) {
 	y = ndarray2object( arrays[ 2 ] );
 	o = ndarray2object( arrays[ 3 ] );
 
-	if ( !isBooleanArray( c.data ) && c.dtype !== 'bool' && c.dtype !== 'uint8') {
-		throw new Error( format( 'invalid arguments. Condition array must be a boolean or uint8 ndarray. c.dtype=%s', c.dtype ) );
+	// Verify that the input and output arrays have the same number of dimensions...
+	shc = c.shape;
+	shx = x.shape;
+	shy = y.shape;
+	sho = o.shape;
+	ndims = shc.length;
+	if ( ndims !== shx.length || ndims !== shy.length || ndims !== sho.length ) { // eslint-disable-line max-len
+		throw new Error( format( 'invalid arguments. Arrays must have the same number of dimensions (i.e., same rank). ndims(c) == %d. ndims(x) == %d. ndims(y) == %d. ndims(o) == %d.', shc.length, shx.length, shy.length, sho.length ) );
 	}
 
-	if ( x.dtype !== y.dtype ) {
-		throw new Error( format( 'invalid arguments. Input arrays must have the same data type. x.dtype=%s, y.dtype=%s', x.dtype, y.dtype ) );
+	if ( !isBooleanArray( c.data ) && !isUint8Array( c.data ) ) {
+		throw new Error( format( 'invalid arguments. Condition array must be a boolean or uint8 ndarray. c.dtype=%s', c.dtype ) );
 	}
 
 	// Always reinterpret condition array to uint8
@@ -344,11 +353,11 @@ function where( arrays ) {
 	}
 
 	// Check for known array types which can be reinterpreted for better iteration performance...
-	if ( isBooleanArray( x.data ) && isBooleanArray( y.data ) && isBooleanArray( o.data ) ) {
+	if ( isBooleanArray( x.data ) && isBooleanArray( y.data ) && isBooleanArray( o.data ) ) { // eslint-disable-line max-len
 		x = boolean2uint8( x );
 		y = boolean2uint8( y );
 		o = boolean2uint8( o );
-	} else if ( isComplexArray( x.data ) && isComplexArray( y.data ) && isComplexArray( o.data ) ) {
+	} else if ( isComplexArray( x.data ) && isComplexArray( y.data ) && isComplexArray( o.data ) ) { // eslint-disable-line max-len
 		x = complex2real( x );
 		y = complex2real( y );
 		o = complex2real( o );
@@ -357,21 +366,23 @@ function where( arrays ) {
 		c.strides.push( 0 ); // broadcast
 	}
 	// Determine whether we are casting a real data type to a complex data type and we need to use a specialized accessor (note: we don't support the other way, complex-to-real, as this is not an allowed (mostly) safe cast; note: we cannot create a specialized view for assigning only real components, as the imaginary component for each element in `y` also needs to be set to zero and while we could perform two passes, it's not clear it's worth the effort)...
-	else if ( (isRealDataType( x.dtype ) && isRealDataType( y.dtype ) ) && isComplexDataType( o.dtype ) ) {
-		x.accessorProtocol = true;
-		y.accessorProtocol = true;
-		x.accessors[ 0 ] = castReturn( x.accessors[ 0 ], 2, complexCtors( String( o.dtype ) ) ); // eslint-disable-line max-len
-		y.accessors[ 0 ] = castReturn( y.accessors[ 0 ], 2, complexCtors( String( o.dtype ) ) ); // eslint-disable-line max-len
+	else if ( isComplexDataType( o.dtype ) ) {
+		if ( isRealDataType( x.dtype )) {
+			x.accessorProtocol = true;
+			x.accessors[ 0 ] = castReturn( x.accessors[ 0 ], 2, complexCtors( String( o.dtype ) ) ); // eslint-disable-line max-len
+		}
+		if ( isRealDataType( y.dtype ) ) {
+			y.accessorProtocol = true;
+			y.accessors[ 0 ] = castReturn( y.accessors[ 0 ], 2, complexCtors( String( o.dtype ) ) ); // eslint-disable-line max-len
+		}
 	}
-	// Verify that the input and output arrays have the same number of dimensions...
+
 	shc = c.shape;
 	shx = x.shape;
 	shy = y.shape;
 	sho = o.shape;
 	ndims = shc.length;
-	if ( ndims !== shx.length || ndims !== shy.length || ndims !== sho.length ) {
-		throw new Error( format( 'invalid arguments. Arrays must have the same number of dimensions (i.e., same rank). ndims(c) == %d. ndims(x) == %d. ndims(y) == %d. ndims(o) == %d.', shc.length, shx.length, shy.length, sho.length ) );
-	}
+
 	// Determine whether we can avoid iteration altogether...
 	if ( ndims === 0 ) {
 		if ( hasAccessors( c, x, y, o ) ) {
@@ -439,15 +450,15 @@ function where( arrays ) {
 
 	// Determine whether we can avoid blocked iteration...
 	ord = strides2order( sc );
-	if ( ioc !== 0 && iox !== 0 && ioy !== 0 && ioo !== 0 && ord === strides2order( sx ) && ord === strides2order( sy ) && ord === strides2order( so ) ) {
+	if ( ioc !== 0 && iox !== 0 && ioy !== 0 && ioo !== 0 && ord === strides2order( sx ) && ord === strides2order( sy ) && ord === strides2order( so ) ) { // eslint-disable-line max-len
 		// Determine the minimum and maximum linear indices which are accessible by the array views:
 		cmmv = minmaxViewBufferIndex( shc, sc, c.offset );
 		xmmv = minmaxViewBufferIndex( shx, sx, x.offset );
 		ymmv = minmaxViewBufferIndex( shy, sy, y.offset );
 		ommv = minmaxViewBufferIndex( sho, so, o.offset );
 
 		// Determine whether we can ignore shape (and strides) and treat the ndarrays as linear one-dimensional strided arrays...
-		if ( len === ( cmmv[1]-cmmv[0]+1 ) && len === ( xmmv[1]-xmmv[0]+1 ) && len === ( ymmv[1]-ymmv[0]+1 ) && len === ( ommv[1]-ommv[0]+1 ) ) {
+		if ( len === ( cmmv[1]-cmmv[0]+1 ) && len === ( xmmv[1]-xmmv[0]+1 ) && len === ( ymmv[1]-ymmv[0]+1 ) && len === ( ommv[1]-ommv[0]+1 ) ) { // eslint-disable-line max-len
 			// Note: the above is equivalent to @stdlib/ndarray/base/assert/is-contiguous, but in-lined so we can retain computed values...
 			if ( ioc === 1 ) {
 				oc = cmmv[ 0 ];

lib/node_modules/@stdlib/ndarray/base/where/test/test.0d.js

@@ -25,6 +25,7 @@ var isSameFloat64Array = require( '@stdlib/assert/is-same-float64array' );
 var isSameAccessorArray = require( '@stdlib/assert/is-same-accessor-array' );
 var toAccessorArray = require( '@stdlib/array/base/to-accessor-array' );
 var Float64Array = require( '@stdlib/array/float64' );
+var Uint8Array = require( '@stdlib/array/uint8' );
 var scalar2ndarray = require( '@stdlib/ndarray/from-scalar' );
 var ndarray = require( '@stdlib/ndarray/ctor' );
 var where = require( './../lib' );
@@ -38,7 +39,7 @@ tape( 'main export is a function', function test( t ) {
 	t.end();
 });
 
-tape( 'the function assigns elements from n 0-dimensional input ndarray to an output ndarray', function test( t ) {
+tape( 'the function assigns elements from a 0-dimensional input ndarray to an output ndarray', function test( t ) {
 	var condition;
 	var expected;
 	var out;
@@ -66,13 +67,13 @@ tape( 'the function assigns elements from n 0-dimensional input ndarray to an ou
 	t.end();
 });
 
-tape( 'the function assigns elements from n 0-dimensional input ndarray to an output ndarray (accessors)', function test( t ) {
+tape( 'the function assigns elements from a 0-dimensional input ndarray to an output ndarray (accessors)', function test( t ) {
 	var condition;
 	var out;
 	var x;
 	var y;
 
-	condition = ndarray( 'uint8', toAccessorArray( [ 1 ] ), [], [ 0 ], 0, 'row-major' );
+	condition = ndarray( 'uint8', new Uint8Array( [ 1 ]), [], [ 0 ], 0, 'row-major' );
 	x = ndarray( 'generic', toAccessorArray( [ 1.0 ] ), [], [ 0 ], 0, 'row-major' );
 	y = ndarray( 'generic', toAccessorArray( [ -1.0 ] ), [], [ 0 ], 0, 'row-major' );
 	out = ndarray( 'generic', toAccessorArray( [ 0.0 ] ), [], [ 0 ], 0, 'row-major' );

lib/node_modules/@stdlib/ndarray/base/where/test/test.1d.js

@@ -173,12 +173,12 @@ tape( 'the function conditionally assigns elements from a 1-dimensional input nd
 	var x;
 	var y;
 
-	cbuf = [
+	cbuf = new Uint8Array([
 		0,
 		0,
 		0,
 		0
-	];
+	]);
 	xbuf = [
 		1.0,
 		2.0,
@@ -191,7 +191,7 @@ tape( 'the function conditionally assigns elements from a 1-dimensional input nd
 		-3.0,
 		-4.0
 	];
-	condition = ndarray( 'uint8', toAccessorArray( cbuf ), [ 4 ], [ 1 ], 0, 'row-major' );
+	condition = ndarray( 'uint8', cbuf, [ 4 ], [ 1 ], 0, 'row-major' );
 	x = ndarray( 'generic', toAccessorArray( xbuf ), [ 4 ], [ 1 ], 0, 'row-major' );
 	y = ndarray( 'generic', toAccessorArray( ybuf ), [ 4 ], [ 1 ], 0, 'row-major' );
 	out = ndarray( 'generic', toAccessorArray( zeros( 4, 'generic' ) ), [ 4 ], [ 1 ], 0, 'row-major' );