Skip to content

Commit 94aa3e2

Browse files
authored
Apply suggestions from code review
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
1 parent 5fe2660 commit 94aa3e2

2 files changed

Lines changed: 1 addition & 3 deletions

File tree

lib/node_modules/@stdlib/ndarray/to-rot90/lib/main.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
// MODULES //
2222

2323
var isIntegerArray = require( '@stdlib/assert/is-integer-array' ).primitives;
24-
var isEmptyCollection = require( '@stdlib/assert/is-empty-collection' );
2524
var isInteger = require( '@stdlib/assert/is-integer' ).isPrimitive;
2625
var isPlainObject = require( '@stdlib/assert/is-plain-object' );
2726
var isndarrayLike = require( '@stdlib/assert/is-ndarray-like' );
@@ -84,7 +83,7 @@ function toRot90( x, options ) {
8483
k = options.k;
8584
}
8685
if ( hasOwnProp( options, 'dims' ) ) {
87-
if ( !isIntegerArray( options.dims ) && !isEmptyCollection( options.dims ) ) { // eslint-disable-line max-len
86+
if ( !isIntegerArray( options.dims ) ) {
8887
throw new TypeError( format( 'invalid option. `%s` option must be an array of integers. Option: `%s`.', 'dims', options.dims ) );
8988
}
9089
dims = options.dims;

lib/node_modules/@stdlib/ndarray/to-rot90/test/test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,6 @@ tape( 'the function throws an error if provided a `dims` option which does not c
208208
x = new ndarray( 'float64', [ 1, 2, 3, 4 ], [ 2, 2 ], [ 2, 1 ], 0, 'row-major' );
209209

210210
values = [
211-
[],
212211
[ 0 ],
213212
[ 0, 1, 0 ]
214213
];

0 commit comments

Comments
 (0)