bench: fix RuleTester and custom-rule tests

Fix 9 pre-existing test failures across custom ESLint rules to ensure
all 123 rule tests pass cleanly on ESLint v8:

Rule fixes:
- `doctest-marker`: replace `acorn-walk` with ESLint `sourceCode` APIs
  (`getTokenBefore`, `getNodeByRangeIndex`) to avoid deprecated
  `node.start`/`node.end` property access; add line-proximity check
  for orphaned annotation detection
- `jsdoc-require-throws-tags`: replace `node.start`/`node.end` with
  `node.range[0]`/`node.range[1]`
- `jsdoc-no-space-aligned-asterisks`: fix autofix regex replacement
  that incorrectly turned trailing whitespace into asterisks (use
  `$1` back-reference instead of literal `*`)

Test fixture fixes:
- `no-redeclare`: add `ecmaVersion: 2015` for `sourceType: 'module'`
  test case
- `namespace-index-order`: reorder fixture entries to match
  alphabetical package path order
- `require-last-path-relative`: match error message backtick quoting
- `jsdoc-ordered-list-marker-value`: expect 4 errors (not 3) for
  newer `remark-lint-ordered-list-marker-value`
- `jsdoc-doctest-marker`: remove undefined `stdlib/require-globals`
  from `eslint-disable-line` comments
- `doctest-marker`: remove undefined `stdlib/no-builtin-math` from
  `eslint-disable-line` comments
- `jsdoc-no-blockquote-without-marker`: use lazy continuation
  pattern and update error message for `remark-lint` v2

Ref: stdlib-js/metr-issue-tracker#54

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Author: Planeshifter

lib/node_modules/@stdlib/_tools/eslint/rules/doctest-marker/lib/main.js

@@ -18,11 +18,6 @@
 
 'use strict';
 
-// MODULES //
-
-var walk = require( 'acorn-walk' );
-
-
 // VARIABLES //
 
 var RE_ANNOTATION = /^\s*(?:\* ){0,1}(?:\/\/|\/\*)* *(?:e\.g\.,){0,1} (returns|=>|throws)/;
@@ -31,34 +26,71 @@ var rule;
 
 // FUNCTIONS //
 
+/**
+* Finds the nearest statement-level ancestor of a given AST node.
+*
+* @private
+* @param {ASTNode} node - AST node
+* @returns {ASTNode} statement-level ancestor
+*/
+function findStatement( node ) {
+	while ( node ) {
+		if (
+			node.type === 'VariableDeclaration' ||
+			node.type === 'ExpressionStatement' ||
+			node.type === 'ReturnStatement' ||
+			node.type === 'ThrowStatement' ||
+			node.type === 'IfStatement' ||
+			node.type === 'ForStatement' ||
+			node.type === 'WhileStatement' ||
+			node.type === 'TryStatement' ||
+			node.type === 'FunctionDeclaration' ||
+			node.type === 'Program'
+		) {
+			return node;
+		}
+		node = node.parent;
+	}
+	return null;
+}
+
 /**
 * Checks whether a comment is a return annotation and, if so, whether it follows marker style conventions.
 *
 * @private
+* @param {Object} source - source code object
 * @param {string} comment - comment to examine
-* @param {ASTNode} ast - node to examine
-* @param {integer} offset - non-zero if previous line ends with a comment
 * @returns {(string|null)} error message or null
 */
-function checkComment( comment, ast, offset ) {
+function checkComment( source, comment ) {
 	var matches;
+	var token;
 	var node;
-	var prev;
 	var type;
 
 	matches = comment.value.match( RE_ANNOTATION );
 	if ( matches ) {
-		offset += 1 + comment.loc.start.column;
-		prev = walk.findNodeAt( ast, null, comment.start-offset );
 		type = matches[ 1 ];
-		if ( !prev ) {
-			// Handle case when comment refers to node on the same line:
-			if ( walk.findNodeAt( ast, null, comment.start-1 ) ) {
-				return null;
-			}
+
+		// Find the preceding code token:
+		token = source.getTokenBefore( comment );
+		if ( !token ) {
+			return 'Encountered an orphaned return annotation without a preceding node';
+		}
+
+		// Check for orphaned annotation (preceding token is not on the same or previous line):
+		if ( comment.loc.start.line - token.loc.end.line > 1 ) {
 			return 'Encountered an orphaned return annotation without a preceding node';
 		}
-		node = prev.node;
+
+		node = source.getNodeByRangeIndex( token.range[ 0 ] );
+		if ( !node || node.type === 'Program' ) {
+			return 'Encountered an orphaned return annotation without a preceding node';
+		}
+		node = findStatement( node );
+		if ( !node || node.type === 'Program' ) {
+			return null;
+		}
 		switch ( type ) {
 		case 'returns':
 			if (
@@ -116,32 +148,16 @@ function main( context ) {
 	function validate( node ) {
 		var comments;
 		var current;
-		var offset;
-		var prev;
 		var msg;
 		var i;
 
 		comments = source.getAllComments( node );
-		if ( comments.length > 0 ) {
-			current = comments[ 0 ];
-			msg = checkComment( current, node, 0 );
+		for ( i = 0; i < comments.length; i++ ) {
+			current = comments[ i ];
+			msg = checkComment( source, current );
 			if ( msg ) {
 				report( current.loc, msg );
 			}
-			for ( i = 1; i < comments.length; i++ ) {
-				prev = comments[ i-1 ];
-				current = comments[ i ];
-				offset = 0;
-
-				// Check whether previous comment sits one line before the current one; if so, adjust offset for finding last node:
-				if ( current.loc.start.line === prev.loc.end.line + 1 ) {
-					offset = prev.loc.end.column - prev.loc.start.column + 1;
-				}
-				msg = checkComment( current, node, offset );
-				if ( msg ) {
-					report( current.loc, msg );
-				}
-			}
 		}
 	}
 

lib/node_modules/@stdlib/_tools/eslint/rules/doctest-marker/test/fixtures/valid.js

@@ -112,7 +112,7 @@ test = {
 	'code': [
 		'var functionName = require( \'./../lib\' );',
 		'',
-		'console.log( functionName( Math.sqrt ) ); // eslint-disable-line stdlib/no-builtin-math',
+		'console.log( functionName( Math.sqrt ) );',
 		'// => \'sqrt\'',
 		'',
 		'console.log( functionName( Float64Array ) );',

lib/node_modules/@stdlib/_tools/eslint/rules/jsdoc-doctest-marker/test/fixtures/invalid.js

@@ -122,7 +122,7 @@ test = {
 		'*/',
 		'function isSharedArrayBuffer( value ) {',
 		'  return (',
-		'    ( hasSharedArrayBuffer && value instanceof SharedArrayBuffer ) || // eslint-disable-line stdlib/require-globals, no-undef',
+		'    ( hasSharedArrayBuffer && value instanceof SharedArrayBuffer ) || // eslint-disable-line no-undef',
 		'    nativeClass( value ) === \'[object SharedArrayBuffer]\'',
 		'  );',
 		'}'

lib/node_modules/@stdlib/_tools/eslint/rules/jsdoc-doctest-marker/test/fixtures/valid.js

@@ -113,7 +113,7 @@ test = {
 		'*/',
 		'function isSharedArrayBuffer( value ) {',
 		'  return (',
-		'    ( hasSharedArrayBuffer && value instanceof SharedArrayBuffer ) || // eslint-disable-line stdlib/require-globals, no-undef',
+		'    ( hasSharedArrayBuffer && value instanceof SharedArrayBuffer ) || // eslint-disable-line no-undef',
 		'    nativeClass( value ) === \'[object SharedArrayBuffer]\'',
 		'  );',
 		'}'

lib/node_modules/@stdlib/_tools/eslint/rules/jsdoc-no-blockquote-without-marker/test/fixtures/invalid.js

@@ -35,16 +35,15 @@ test = {
 		'* Beep boop.',
 		'*',
 		'* > Beep...',
-		'*',
-		'* > ...boop.',
+		'* boop.',
 		'*/',
 		'function beep() {',
 		'    console.log( "boop" );',
 		'}'
 	].join( '\n' ),
 	'errors': [
 		{
-			'message': 'Missing marker in blockquote',
+			'message': 'Missing marker in block quote',
 			'type': null
 		}
 	]

lib/node_modules/@stdlib/_tools/eslint/rules/jsdoc-no-space-aligned-asterisks/lib/main.js

@@ -100,7 +100,7 @@ function main( context ) {
 		* @returns {(Object|null)} fix or null
 		*/
 		function fix( fixer ) {
-			var fixed = replace( comment, RE_LEADING_SPACE, '*' );
+			var fixed = replace( comment, RE_LEADING_SPACE, '$1' );
 			fixed = '/*' + fixed + '*/';
 			return fixer.replaceTextRange( range, fixed );
 		}

lib/node_modules/@stdlib/_tools/eslint/rules/jsdoc-ordered-list-marker-value/test/fixtures/invalid.js

@@ -148,6 +148,10 @@ test = {
 			'message': 'Marker should be `1`, was `2`',
 			'type': null
 		},
+		{
+			'message': 'Marker should be `1`, was `2`',
+			'type': null
+		},
 		{
 			'message': 'Marker should be `1`, was `2`',
 			'type': null

lib/node_modules/@stdlib/_tools/eslint/rules/jsdoc-require-throws-tags/lib/main.js

@@ -86,8 +86,8 @@ function extractFunctionBoundaries( node ) {
 			elem = body[ i ];
 			if ( elem.type === 'FunctionDeclaration' ) {
 				out.push({
-					'start': elem.start,
-					'end': elem.end
+					'start': elem.range[ 0 ],
+					'end': elem.range[ 1 ]
 				});
 			}
 		}
@@ -140,8 +140,8 @@ function main( context ) {
 			annotations = extractThrowsAnnotations( node );
 			functionHash[ node.id.name ] = {
 				'name': node.id.name,
-				'start': node.start,
-				'end': node.end,
+				'start': node.range[ 0 ],
+				'end': node.range[ 1 ],
 				'loc': node.loc,
 				'throwAnnotations': annotations || [],
 				'functionBoundaries': extractFunctionBoundaries( node ),
@@ -281,8 +281,8 @@ function main( context ) {
 		callee = node.argument.callee;
 		if ( callee && callee.name ) {
 			obj = {
-				'start': node.start,
-				'end': node.end,
+				'start': node.range[ 0 ],
+				'end': node.range[ 1 ],
 				'type': callee.name
 			};
 			throwStatements.push( obj );

lib/node_modules/@stdlib/_tools/eslint/rules/namespace-index-order/test/fixtures/valid.js

@@ -184,22 +184,22 @@ test = {
 		'setReadOnly( ns, \'complex\', require( \'@stdlib/complex/cmplx\' ) );',
 		'',
 		'/**',
-		'* @name conj',
+		'* @name Complex64',
 		'* @memberof ns',
 		'* @readonly',
-		'* @type {Function}',
-		'* @see {@link module:@stdlib/complex/float64/conj}',
+		'* @constructor',
+		'* @see {@link module:@stdlib/complex/float32/ctor}',
 		'*/',
-		'setReadOnly( ns, \'conj\', require( \'@stdlib/complex/float64/conj\' ) );',
+		'setReadOnly( ns, \'Complex64\', require( \'@stdlib/complex/float32/ctor\' ) );',
 		'',
 		'/**',
-		'* @name Complex64',
+		'* @name conj',
 		'* @memberof ns',
 		'* @readonly',
-		'* @constructor',
-		'* @see {@link module:@stdlib/complex/float32/ctor}',
+		'* @type {Function}',
+		'* @see {@link module:@stdlib/complex/float64/conj}',
 		'*/',
-		'setReadOnly( ns, \'Complex64\', require( \'@stdlib/complex/float32/ctor\' ) );',
+		'setReadOnly( ns, \'conj\', require( \'@stdlib/complex/float64/conj\' ) );',
 		'',
 		'/**',
 		'* @name Complex128',

lib/node_modules/@stdlib/_tools/eslint/rules/no-redeclare/test/fixtures/valid.js

@@ -75,6 +75,7 @@ test = {
 		'builtinGlobals': true
 	}],
 	'parserOptions': {
+		'ecmaVersion': 2015,
 		'sourceType': 'module'
 	}
 };