Skip to content

Commit b215eb8

Browse files
headlessNodeheadlessNode
committed
fix: apply suggestions from code review
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 941561f commit b215eb8

9 files changed

Lines changed: 329 additions & 329 deletions

‎lib/node_modules/@stdlib/blas/ext/base/ssort/benchmark/benchmark.unsorted_random.js‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@
2222

2323
var bench = require( '@stdlib/bench' );
2424
var uniform = require( '@stdlib/random/array/uniform' );
25-
var isnan = require( '@stdlib/math/base/assert/is-nan' );
26-
var pow = require( '@stdlib/math/base/special/pow' );
27-
var floor = require( '@stdlib/math/base/special/floor' );
25+
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
26+
var powf = require( '@stdlib/math/base/special/powf' );
27+
var floorf = require( '@stdlib/math/base/special/floorf' );
2828
var Float32Array = require( '@stdlib/array/float32' );
2929
var scopy = require( '@stdlib/blas/base/scopy' );
3030
var format = require( '@stdlib/string/format' );
@@ -74,12 +74,12 @@ function createBenchmark( iter, len ) {
7474
b.tic();
7575
for ( i = 0; i < b.iterations; i++ ) {
7676
y = ssort( len, 1, xc[ i ], 1 );
77-
if ( isnan( y[ i%len ] ) ) {
77+
if ( isnanf( y[ i%len ] ) ) {
7878
b.fail( 'should not return NaN' );
7979
}
8080
}
8181
b.toc();
82-
if ( isnan( y[ i%len ] ) ) {
82+
if ( isnanf( y[ i%len ] ) ) {
8383
b.fail( 'should not return NaN' );
8484
}
8585
b.pass( 'benchmark finished' );
@@ -109,13 +109,13 @@ function main() {
109109
max = 4; // 10^max
110110

111111
for ( i = min; i <= max; i++ ) {
112-
len = pow( 10, i );
112+
len = powf( 10, i );
113113
f = createBenchmark( iter, len );
114114
opts = {
115115
'iterations': iter
116116
};
117117
bench( format( '%s::unsorted,random:len=%d', pkg, len ), opts, f );
118-
iter = floor( pow( iter, 3.0/4.0 ) );
118+
iter = floorf( powf( iter, 3.0/4.0 ) );
119119
}
120120
}
121121

‎lib/node_modules/@stdlib/blas/ext/base/ssort/benchmark/benchmark.unsorted_random.native.js‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
2525
var uniform = require( '@stdlib/random/array/uniform' );
26-
var isnan = require( '@stdlib/math/base/assert/is-nan' );
27-
var pow = require( '@stdlib/math/base/special/pow' );
28-
var floor = require( '@stdlib/math/base/special/floor' );
26+
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
27+
var powf = require( '@stdlib/math/base/special/powf' );
28+
var floorf = require( '@stdlib/math/base/special/floorf' );
2929
var Float32Array = require( '@stdlib/array/float32' );
3030
var scopy = require( '@stdlib/blas/base/scopy' );
3131
var tryRequire = require( '@stdlib/utils/try-require' );
@@ -83,12 +83,12 @@ function createBenchmark( iter, len ) {
8383
b.tic();
8484
for ( i = 0; i < b.iterations; i++ ) {
8585
y = ssort( len, 1, xc[ i ], 1 );
86-
if ( isnan( y[ i%len ] ) ) {
86+
if ( isnanf( y[ i%len ] ) ) {
8787
b.fail( 'should not return NaN' );
8888
}
8989
}
9090
b.toc();
91-
if ( isnan( y[ i%len ] ) ) {
91+
if ( isnanf( y[ i%len ] ) ) {
9292
b.fail( 'should not return NaN' );
9393
}
9494
b.pass( 'benchmark finished' );
@@ -118,14 +118,14 @@ function main() {
118118
max = 4; // 10^max
119119

120120
for ( i = min; i <= max; i++ ) {
121-
len = pow( 10, i );
121+
len = powf( 10, i );
122122
f = createBenchmark( iter, len );
123123
bopts = {
124124
'skip': opts.skip,
125125
'iterations': iter
126126
};
127127
bench( format( '%s::native,unsorted,random:len=%d', pkg, len ), bopts, f );
128-
iter = floor( pow( iter, 3.0/4.0 ) );
128+
iter = floorf( powf( iter, 3.0/4.0 ) );
129129
}
130130
}
131131

‎lib/node_modules/@stdlib/blas/ext/base/ssort/benchmark/benchmark.unsorted_random.ndarray.js‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@
2222

2323
var bench = require( '@stdlib/bench' );
2424
var uniform = require( '@stdlib/random/array/uniform' );
25-
var isnan = require( '@stdlib/math/base/assert/is-nan' );
26-
var pow = require( '@stdlib/math/base/special/pow' );
27-
var floor = require( '@stdlib/math/base/special/floor' );
25+
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
26+
var powf = require( '@stdlib/math/base/special/powf' );
27+
var floorf = require( '@stdlib/math/base/special/floorf' );
2828
var Float32Array = require( '@stdlib/array/float32' );
2929
var scopy = require( '@stdlib/blas/base/scopy' );
3030
var format = require( '@stdlib/string/format' );
@@ -74,12 +74,12 @@ function createBenchmark( iter, len ) {
7474
b.tic();
7575
for ( i = 0; i < b.iterations; i++ ) {
7676
y = ssort( len, 1, xc[ i ], 1, 0 );
77-
if ( isnan( y[ i%len ] ) ) {
77+
if ( isnanf( y[ i%len ] ) ) {
7878
b.fail( 'should not return NaN' );
7979
}
8080
}
8181
b.toc();
82-
if ( isnan( y[ i%len ] ) ) {
82+
if ( isnanf( y[ i%len ] ) ) {
8383
b.fail( 'should not return NaN' );
8484
}
8585
b.pass( 'benchmark finished' );
@@ -109,13 +109,13 @@ function main() {
109109
max = 4; // 10^max
110110

111111
for ( i = min; i <= max; i++ ) {
112-
len = pow( 10, i );
112+
len = powf( 10, i );
113113
f = createBenchmark( iter, len );
114114
opts = {
115115
'iterations': iter
116116
};
117117
bench( format( '%s::unsorted,random:ndarray:len=%d', pkg, len ), opts, f );
118-
iter = floor( pow( iter, 3.0/4.0 ) );
118+
iter = floorf( powf( iter, 3.0/4.0 ) );
119119
}
120120
}
121121

‎lib/node_modules/@stdlib/blas/ext/base/ssort/benchmark/benchmark.unsorted_random.ndarray.native.js‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
2525
var uniform = require( '@stdlib/random/array/uniform' );
26-
var isnan = require( '@stdlib/math/base/assert/is-nan' );
27-
var pow = require( '@stdlib/math/base/special/pow' );
28-
var floor = require( '@stdlib/math/base/special/floor' );
26+
var isnan = require( '@stdlib/math/base/assert/is-nanf' );
27+
var powf = require( '@stdlib/math/base/special/powf' );
28+
var floorf = require( '@stdlib/math/base/special/floorf' );
2929
var Float32Array = require( '@stdlib/array/float32' );
3030
var scopy = require( '@stdlib/blas/base/scopy' );
3131
var tryRequire = require( '@stdlib/utils/try-require' );
@@ -118,14 +118,14 @@ function main() {
118118
max = 4; // 10^max
119119

120120
for ( i = min; i <= max; i++ ) {
121-
len = pow( 10, i );
121+
len = powf( 10, i );
122122
f = createBenchmark( iter, len );
123123
bopts = {
124124
'skip': opts.skip,
125125
'iterations': iter
126126
};
127127
bench( format( '%s::native,unsorted,random:ndarray:len=%d', pkg, len ), bopts, f );
128-
iter = floor( pow( iter, 3.0/4.0 ) );
128+
iter = floorf( powf( iter, 3.0/4.0 ) );
129129
}
130130
}
131131

‎lib/node_modules/@stdlib/blas/ext/base/ssort/test/fixtures/ascending.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
// MODULES //
2222

2323
var isnan = require( '@stdlib/math/base/assert/is-nan' );
24-
var isNegativeZero = require( '@stdlib/math/base/assert/is-negative-zero' );
24+
var isNegativeZerof = require( '@stdlib/math/base/assert/is-negative-zerof' );
2525

2626

2727
// MAIN //
@@ -52,10 +52,10 @@ function ascending( a, b ) {
5252
}
5353
// Sort negative 0s to the left...
5454
if ( a === b && a === 0 ) {
55-
if ( isNegativeZero( a ) ) {
55+
if ( isNegativeZerof( a ) ) {
5656
return -1;
5757
}
58-
if ( isNegativeZero( b ) ) {
58+
if ( isNegativeZerof( b ) ) {
5959
return 1;
6060
}
6161
return 0;

0 commit comments

Comments
 (0)