Skip to content

Commit c581849

Browse files
Lokeshranjan8kgryte
Lokeshranjan8
and
kgryte
authored
bench: update random value generation for stats/base/dists/uniform
PR-URL: #10010 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com>
1 parent 647b041 commit c581849

File tree

12 files changed

+122
-158
lines changed

12 files changed

+122
-158
lines changed

‎lib/node_modules/@stdlib/stats/base/dists/uniform/mgf/benchmark/benchmark.js‎

Lines changed: 15 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var Float64Array = require( '@stdlib/array/float64' );
25-
var uniform = require( '@stdlib/random/base/uniform' );
24+
var uniform = require( '@stdlib/random/array/uniform' );
2625
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2726
var format = require( '@stdlib/string/format' );
2827
var pkg = require( './../package.json' ).name;
@@ -32,26 +31,23 @@ var mgf = require( './../lib' );
3231
// MAIN //
3332

3433
bench( pkg, function benchmark( b ) {
34+
var opts;
3535
var min;
3636
var max;
37-
var len;
3837
var t;
3938
var y;
4039
var i;
4140

42-
len = 100;
43-
t = new Float64Array( len );
44-
min = new Float64Array( len );
45-
max = new Float64Array( len );
46-
for ( i = 0; i < len; i++ ) {
47-
t[ i ] = uniform( -10.0, 10.0 );
48-
min[ i ] = uniform( -20.0, 0.0 );
49-
max[ i ] = uniform( min[ i ], min[ i ] + 40.0 );
50-
}
41+
opts = {
42+
'dtype': 'float64'
43+
};
44+
t = uniform( 100, -10.0, 10.0, opts );
45+
min = uniform( 100, -20.0, 0.0, opts );
46+
max = uniform( 100, 20.0, 40.0, opts );
5147

5248
b.tic();
5349
for ( i = 0; i < b.iterations; i++ ) {
54-
y = mgf( t[ i % len ], min[ i % len ], max[ i % len ] );
50+
y = mgf( t[ i % t.length ], min[ i % min.length ], max[ i % max.length ] );
5551
if ( isnan( y ) ) {
5652
b.fail( 'should not return NaN' );
5753
}
@@ -66,25 +62,24 @@ bench( pkg, function benchmark( b ) {
6662

6763
bench( format( '%s::factory', pkg ), function benchmark( b ) {
6864
var mymgf;
65+
var opts;
6966
var min;
7067
var max;
71-
var len;
7268
var t;
7369
var y;
7470
var i;
7571

72+
opts = {
73+
'dtype': 'float64'
74+
};
7675
min = -1.5;
7776
max = 1.5;
7877
mymgf = mgf.factory( min, max );
79-
len = 100;
80-
t = new Float64Array( len );
81-
for ( i = 0; i < len; i++ ) {
82-
t[ i ] = uniform( -2.0, 0.0 );
83-
}
78+
t = uniform( 100, -2.0, 0.0, opts );
8479

8580
b.tic();
8681
for ( i = 0; i < b.iterations; i++ ) {
87-
y = mymgf( t[ i % len ] );
82+
y = mymgf( t[ i % t.length ] );
8883
if ( isnan( y ) ) {
8984
b.fail( 'should not return NaN' );
9085
}

‎lib/node_modules/@stdlib/stats/base/dists/uniform/mgf/benchmark/benchmark.native.js‎

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var Float64Array = require( '@stdlib/array/float64' );
26-
var uniform = require( '@stdlib/random/base/uniform' );
25+
var uniform = require( '@stdlib/random/array/uniform' );
2726
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2827
var tryRequire = require( '@stdlib/utils/try-require' );
2928
var format = require( '@stdlib/string/format' );
@@ -41,26 +40,23 @@ var opts = {
4140
// MAIN //
4241

4342
bench( format( '%s::native', pkg ), opts, function benchmark( b ) {
44-
var len;
43+
var opts;
4544
var min;
4645
var max;
4746
var t;
4847
var y;
4948
var i;
5049

51-
len = 100;
52-
t = new Float64Array( len );
53-
min = new Float64Array( len );
54-
max = new Float64Array( len );
55-
for ( i = 0; i < len; i++ ) {
56-
t[ i ] = uniform( -10.0, 10.0 );
57-
min[ i ] = uniform( -20.0, 0.0 );
58-
max[ i ] = uniform( min[ i ], min[ i ] + 40.0 );
59-
}
50+
opts = {
51+
'dtype': 'float64'
52+
};
53+
t = uniform( 100, -10.0, 10.0, opts );
54+
min = uniform( 100, -20.0, 0.0, opts );
55+
max = uniform( 100, 20.0, 40.0, opts );
6056

6157
b.tic();
6258
for ( i = 0; i < b.iterations; i++ ) {
63-
y = mgf( t[ i % len ], min[ i % len ], max[ i % len ] );
59+
y = mgf( t[ i % t.length ], min[ i % min.length ], max[ i % max.length ] );
6460
if ( isnan( y ) ) {
6561
b.fail( 'should not return NaN' );
6662
}

‎lib/node_modules/@stdlib/stats/base/dists/uniform/pdf/benchmark/benchmark.js‎

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var Float64Array = require( '@stdlib/array/float64' );
2524
var uniform = require( '@stdlib/random/array/uniform' );
2625
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2726
var format = require( '@stdlib/string/format' );
@@ -32,24 +31,23 @@ var pdf = require( './../lib' );
3231
// MAIN //
3332

3433
bench( pkg, function benchmark( b ) {
35-
var len;
34+
var opts;
3635
var min;
3736
var max;
3837
var x;
3938
var y;
4039
var i;
4140

42-
len = 100;
43-
x = uniform(len, -10.0, 10.0);
44-
min = uniform(len, -20.0, 0.0);
45-
max = new Float64Array(len);
46-
for ( i = 0; i < len; i++ ) {
47-
max[i] = uniform(1, min[i], min[i] + 40.0)[0];
48-
}
41+
opts = {
42+
'dtype': 'float64'
43+
};
44+
x = uniform( 100, -10.0, 10.0, opts );
45+
min = uniform( 100, -20.0, 0.0, opts );
46+
max = uniform( 100, 20.0, 40.0, opts );
4947

5048
b.tic();
5149
for ( i = 0; i < b.iterations; i++ ) {
52-
y = pdf( x[ i % len ], min[ i % len ], max[ i % len ] );
50+
y = pdf( x[ i % x.length ], min[ i % min.length ], max[ i % max.length ] );
5351
if ( isnan( y ) ) {
5452
b.fail( 'should not return NaN' );
5553
}

‎lib/node_modules/@stdlib/stats/base/dists/uniform/pdf/benchmark/benchmark.native.js‎

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,7 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var Float64Array = require( '@stdlib/array/float64' );
2625
var uniform = require( '@stdlib/random/array/uniform' );
27-
var runif = require( '@stdlib/random/base/uniform' );
2826
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2927
var tryRequire = require( '@stdlib/utils/try-require' );
3028
var format = require( '@stdlib/string/format' );
@@ -42,24 +40,23 @@ var opts = {
4240
// MAIN //
4341

4442
bench( format( '%s::native', pkg ), opts, function benchmark( b ) {
45-
var len;
43+
var opts;
4644
var min;
4745
var max;
4846
var x;
4947
var y;
5048
var i;
5149

52-
len = 100;
53-
x = uniform( len, -10.0, 10.0 );
54-
min = uniform( len, -20.0, 0.0 );
55-
max = new Float64Array( len );
56-
for ( i = 0; i < len; i++ ) {
57-
max[ i ] = runif( min[ i ], min[ i ] + 40.0 );
58-
}
50+
opts = {
51+
'dtype': 'float64'
52+
};
53+
x = uniform( 100, -10.0, 10.0, opts );
54+
min = uniform( 100, -20.0, 0.0, opts );
55+
max = uniform( 100, 20.0, 40.0, opts );
5956

6057
b.tic();
6158
for ( i = 0; i < b.iterations; i++ ) {
62-
y = pdf( x[ i % len ], min[ i % len ], max[ i % len ] );
59+
y = pdf( x[ i % x.length ], min[ i % min.length ], max[ i % max.length ] );
6360
if ( isnan( y ) ) {
6461
b.fail( 'should not return NaN' );
6562
}

‎lib/node_modules/@stdlib/stats/base/dists/uniform/quantile/benchmark/benchmark.js‎

Lines changed: 17 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -21,36 +21,33 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var Float64Array = require( '@stdlib/array/float64' );
25-
var uniform = require( '@stdlib/random/base/uniform' );
24+
var uniform = require( '@stdlib/random/array/uniform' );
2625
var isnan = require( '@stdlib/math/base/assert/is-nan' );
26+
var format = require( '@stdlib/string/format' );
2727
var pkg = require( './../package.json' ).name;
2828
var quantile = require( './../lib' );
2929

3030

3131
// MAIN //
3232

3333
bench( pkg, function benchmark( b ) {
34+
var opts;
3435
var min;
3536
var max;
36-
var len;
3737
var p;
3838
var y;
3939
var i;
4040

41-
len = 100;
42-
p = new Float64Array( len );
43-
min = new Float64Array( len );
44-
max = new Float64Array( len );
45-
for ( i = 0; i < len; i++ ) {
46-
p[ i ] = uniform( 0.0, 1.0 );
47-
min[ i ] = uniform( -20.0, 0.0 );
48-
max[ i ] = uniform( min[ i ], min[ i ] + 40.0 );
49-
}
41+
opts = {
42+
'dtype': 'float64'
43+
};
44+
p = uniform( 100, 0.0, 1.0, opts );
45+
min = uniform( 100, -20.0, 0.0, opts );
46+
max = uniform( 100, 20.0, 40.0, opts );
5047

5148
b.tic();
5249
for ( i = 0; i < b.iterations; i++ ) {
53-
y = quantile( p[ i % len ], min[ i % len ], max[ i % len ] );
50+
y = quantile( p[ i % p.length ], min[ i % min.length ], max[ i % max.length ] );
5451
if ( isnan( y ) ) {
5552
b.fail( 'should not return NaN' );
5653
}
@@ -63,27 +60,26 @@ bench( pkg, function benchmark( b ) {
6360
b.end();
6461
});
6562

66-
bench( pkg+':factory', function benchmark( b ) {
63+
bench( format( '%s::factory', pkg ), function benchmark( b ) {
6764
var myquantile;
65+
var opts;
6866
var min;
6967
var max;
70-
var len;
7168
var p;
7269
var y;
7370
var i;
7471

72+
opts = {
73+
'dtype': 'float64'
74+
};
7575
min = -1.5;
7676
max = 1.5;
7777
myquantile = quantile.factory( min, max );
78-
len = 100;
79-
p = new Float64Array( len );
80-
for ( i = 0; i < len; i++ ) {
81-
p[ i ] = uniform( 0.0, 1.0 );
82-
}
78+
p = uniform( 100, 0.0, 1.0, opts );
8379

8480
b.tic();
8581
for ( i = 0; i < b.iterations; i++ ) {
86-
y = myquantile( p[ i % len ] );
82+
y = myquantile( p[ i % p.length ] );
8783
if ( isnan( y ) ) {
8884
b.fail( 'should not return NaN' );
8985
}

‎lib/node_modules/@stdlib/stats/base/dists/uniform/quantile/benchmark/benchmark.native.js‎

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var Float64Array = require( '@stdlib/array/float64' );
26-
var uniform = require( '@stdlib/random/base/uniform' );
25+
var uniform = require( '@stdlib/random/array/uniform' );
2726
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2827
var tryRequire = require( '@stdlib/utils/try-require' );
28+
var format = require( '@stdlib/string/format' );
2929
var pkg = require( './../package.json' ).name;
3030

3131

@@ -39,27 +39,24 @@ var opts = {
3939

4040
// MAIN //
4141

42-
bench( pkg+'::native', opts, function benchmark( b ) {
43-
var len;
42+
bench( format( '%s::native', pkg ), opts, function benchmark( b ) {
43+
var opts;
4444
var min;
4545
var max;
4646
var p;
4747
var y;
4848
var i;
4949

50-
len = 100;
51-
p = new Float64Array( len );
52-
min = new Float64Array( len );
53-
max = new Float64Array( len );
54-
for ( i = 0; i < len; i++ ) {
55-
p[ i ] = uniform( 0.0, 1.0 );
56-
min[ i ] = uniform( -20.0, 0.0 );
57-
max[ i ] = uniform( min[ i ], min[ i ] + 40.0 );
58-
}
50+
opts = {
51+
'dtype': 'float64'
52+
};
53+
p = uniform( 100, 0.0, 1.0, opts );
54+
min = uniform( 100, -20.0, 0.0, opts );
55+
max = uniform( 100, 20.0, 40.0, opts );
5956

6057
b.tic();
6158
for ( i = 0; i < b.iterations; i++ ) {
62-
y = quantile( p[ i % len ], min[ i % len ], max[ i % len ] );
59+
y = quantile( p[ i % p.length ], min[ i % min.length ], max[ i % max.length ] );
6360
if ( isnan( y ) ) {
6461
b.fail( 'should not return NaN' );
6562
}

‎lib/node_modules/@stdlib/stats/base/dists/uniform/skewness/benchmark/benchmark.js‎

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var Float64Array = require( '@stdlib/array/float64' );
25-
var uniform = require( '@stdlib/random/base/uniform' );
24+
var uniform = require( '@stdlib/random/array/uniform' );
2625
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2726
var pkg = require( './../package.json' ).name;
2827
var skewness = require( './../lib' );
@@ -31,23 +30,21 @@ var skewness = require( './../lib' );
3130
// MAIN //
3231

3332
bench( pkg, function benchmark( b ) {
33+
var opts;
3434
var min;
3535
var max;
36-
var len;
3736
var y;
3837
var i;
3938

40-
len = 100;
41-
min = new Float64Array( len );
42-
max = new Float64Array( len );
43-
for ( i = 0; i < len; i++ ) {
44-
min[ i ] = uniform( 0.0, 10.0 );
45-
max[ i ] = uniform( min[ i ], 10.0 + min[ i ] );
46-
}
39+
opts = {
40+
'dtype': 'float64'
41+
};
42+
min = uniform( 100, 0.0, 10.0, opts );
43+
max = uniform( 100, 10.0, 20.0, opts );
4744

4845
b.tic();
4946
for ( i = 0; i < b.iterations; i++ ) {
50-
y = skewness( min[ i % len ], max[ i % len ] );
47+
y = skewness( min[ i % min.length ], max[ i % max.length ] );
5148
if ( isnan( y ) ) {
5249
b.fail( 'should not return NaN' );
5350
}

0 commit comments

Comments
 (0)