Skip to content

Commit ceb5cf5

Browse files
authored
fix: add missing isNumber assertion in plot/vega/axis/ctor/lib/*-opacity
PR-URL: #11010 Reviewed-by: Athan Reines <kgryte@gmail.com>
1 parent dcd3ae4 commit ceb5cf5

File tree

5 files changed

+10
-5
lines changed

5 files changed

+10
-5
lines changed

lib/node_modules/@stdlib/plot/vega/axis/ctor/lib/domain-opacity/set.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
var logger = require( 'debug' );
2626
var isBetween = require( '@stdlib/assert/is-between' );
27+
var isNumber = require( '@stdlib/assert/is-number' ).isPrimitive;
2728
var format = require( '@stdlib/string/format' );
2829
var changeEvent = require( './../change_event.js' );
2930
var prop = require( './properties.js' );
@@ -45,7 +46,7 @@ var debug = logger( 'vega:axis:set:'+prop.name );
4546
* @returns {void}
4647
*/
4748
function set( value ) {
48-
if ( !isBetween( value, 0.0, 1.0 ) ) {
49+
if ( !( isNumber( value ) && isBetween( value, 0.0, 1.0 ) ) ) {
4950
throw new TypeError( format( 'invalid assignment. `%s` must be on the interval: [0, 1]. Value: `%s`.', prop.name, value ) );
5051
}
5152
if ( value !== this[ prop.private ] ) {

lib/node_modules/@stdlib/plot/vega/axis/ctor/lib/grid-opacity/set.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
var logger = require( 'debug' );
2626
var isBetween = require( '@stdlib/assert/is-between' );
27+
var isNumber = require( '@stdlib/assert/is-number' ).isPrimitive;
2728
var format = require( '@stdlib/string/format' );
2829
var changeEvent = require( './../change_event.js' );
2930
var prop = require( './properties.js' );
@@ -45,7 +46,7 @@ var debug = logger( 'vega:axis:set:'+prop.name );
4546
* @returns {void}
4647
*/
4748
function set( value ) {
48-
if ( !isBetween( value, 0.0, 1.0 ) ) {
49+
if ( !( isNumber( value ) && isBetween( value, 0.0, 1.0 ) ) ) {
4950
throw new TypeError( format( 'invalid assignment. `%s` must be on the interval: [0, 1]. Value: `%s`.', prop.name, value ) );
5051
}
5152
if ( value !== this[ prop.private ] ) {

lib/node_modules/@stdlib/plot/vega/axis/ctor/lib/label-opacity/set.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
var logger = require( 'debug' );
2626
var isBetween = require( '@stdlib/assert/is-between' );
27+
var isNumber = require( '@stdlib/assert/is-number' ).isPrimitive;
2728
var format = require( '@stdlib/string/format' );
2829
var changeEvent = require( './../change_event.js' );
2930
var prop = require( './properties.js' );
@@ -45,7 +46,7 @@ var debug = logger( 'vega:axis:set:'+prop.name );
4546
* @returns {void}
4647
*/
4748
function set( value ) {
48-
if ( !isBetween( value, 0.0, 1.0 ) ) {
49+
if ( !( isNumber( value ) && isBetween( value, 0.0, 1.0 ) ) ) {
4950
throw new TypeError( format( 'invalid assignment. `%s` must be on the interval: [0, 1]. Value: `%s`.', prop.name, value ) );
5051
}
5152
if ( value !== this[ prop.private ] ) {

lib/node_modules/@stdlib/plot/vega/axis/ctor/lib/tick-opacity/set.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
var logger = require( 'debug' );
2626
var isBetween = require( '@stdlib/assert/is-between' );
27+
var isNumber = require( '@stdlib/assert/is-number' ).isPrimitive;
2728
var format = require( '@stdlib/string/format' );
2829
var changeEvent = require( './../change_event.js' );
2930
var prop = require( './properties.js' );
@@ -45,7 +46,7 @@ var debug = logger( 'vega:axis:set:'+prop.name );
4546
* @returns {void}
4647
*/
4748
function set( value ) {
48-
if ( !isBetween( value, 0.0, 1.0 ) ) {
49+
if ( !( isNumber( value ) && isBetween( value, 0.0, 1.0 ) ) ) {
4950
throw new TypeError( format( 'invalid assignment. `%s` must be on the interval: [0, 1]. Value: `%s`.', prop.name, value ) );
5051
}
5152
if ( value !== this[ prop.private ] ) {

lib/node_modules/@stdlib/plot/vega/axis/ctor/lib/title-opacity/set.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
var logger = require( 'debug' );
2626
var isBetween = require( '@stdlib/assert/is-between' );
27+
var isNumber = require( '@stdlib/assert/is-number' ).isPrimitive;
2728
var format = require( '@stdlib/string/format' );
2829
var changeEvent = require( './../change_event.js' );
2930
var prop = require( './properties.js' );
@@ -45,7 +46,7 @@ var debug = logger( 'vega:axis:set:'+prop.name );
4546
* @returns {void}
4647
*/
4748
function set( value ) {
48-
if ( !isBetween( value, 0.0, 1.0 ) ) {
49+
if ( !( isNumber( value ) && isBetween( value, 0.0, 1.0 ) ) ) {
4950
throw new TypeError( format( 'invalid assignment. `%s` must be on the interval: [0, 1]. Value: `%s`.', prop.name, value ) );
5051
}
5152
if ( value !== this[ prop.private ] ) {

0 commit comments

Comments
 (0)