Skip to content

Commit dca1108

Browse files
authored
chore: use format for error messages in datasets/* build scripts
PR-URL: #12157 Reviewed-by: Athan Reines <kgryte@gmail.com>
1 parent dff4820 commit dca1108

7 files changed

Lines changed: 17 additions & 10 deletions

File tree

lib/node_modules/@stdlib/datasets/berndt-cps-wages-1985/scripts/build_json.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
var resolve = require( 'path' ).resolve;
2424
var writeFileSync = require( '@stdlib/fs/write-file' ).sync;
2525
var readFileSync = require( '@stdlib/fs/read-file' ).sync;
26+
var format = require( '@stdlib/string/format' );
2627
var RE_EOL = require( '@stdlib/regexp/eol' ).REGEXP;
2728

2829

@@ -66,7 +67,7 @@ function main() {
6667
} else {
6768
tmp = file[ i ].split( ',' );
6869
if ( tmp.length !== headers.length ) {
69-
throw new Error( 'number of columns does not match number of columns for row '+i+'.' );
70+
throw new Error( format( 'number of columns does not match number of columns for row %d.', i ) );
7071
}
7172
row = {};
7273
for ( j = 0; j < headers.length; j++ ) {

lib/node_modules/@stdlib/datasets/cdc-nchs-us-births-1969-1988/scripts/build.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
var resolve = require( 'path' ).resolve;
2424
var readFile = require( '@stdlib/fs/read-file' ).sync;
2525
var writeFile = require( '@stdlib/fs/write-file' ).sync;
26+
var format = require( '@stdlib/string/format' );
2627
var RE_EOL = require( '@stdlib/regexp/eol' ).REGEXP;
2728

2829

@@ -67,7 +68,7 @@ function main() {
6768
for ( i = 0; i < data.length; i++ ) {
6869
d = data[ i ].split( ',' );
6970
if ( d.length !== fields.length ) {
70-
throw new Error( 'unexpected error. Number of row values ('+d.length+') does not match the expected number of fields ('+fields.length+').' );
71+
throw new Error( format( 'unexpected error. Number of row values (%d) does not match the expected number of fields (%d).', d.length, fields.length ) );
7172
}
7273
for ( j = 0; j < d.length; j++ ) {
7374
d[ j ] = parseFloat( d[ j ] );

lib/node_modules/@stdlib/datasets/cdc-nchs-us-births-1994-2003/scripts/build.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
var resolve = require( 'path' ).resolve;
2424
var readFile = require( '@stdlib/fs/read-file' ).sync;
2525
var writeFile = require( '@stdlib/fs/write-file' ).sync;
26+
var format = require( '@stdlib/string/format' );
2627
var RE_EOL = require( '@stdlib/regexp/eol' ).REGEXP;
2728

2829

@@ -67,7 +68,7 @@ function main() {
6768
for ( i = 0; i < data.length; i++ ) {
6869
d = data[ i ].split( ',' );
6970
if ( d.length !== fields.length ) {
70-
throw new Error( 'unexpected error. Number of row values ('+d.length+') does not match the expected number of fields ('+fields.length+').' );
71+
throw new Error( format( 'unexpected error. Number of row values (%d) does not match the expected number of fields (%d).', d.length, fields.length ) );
7172
}
7273
for ( j = 0; j < d.length; j++ ) {
7374
d[ j ] = parseFloat( d[ j ] );

lib/node_modules/@stdlib/datasets/emoji-code-picto/scripts/build.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var writeFile = require( '@stdlib/fs/write-file' ).sync;
25+
var format = require( '@stdlib/string/format' );
2526
var dataset = require( '@stdlib/datasets/emoji' );
2627

2728

@@ -63,7 +64,7 @@ function main() {
6364
for ( j = 0; j < codes.length; j++ ) {
6465
c = codes[ j ];
6566
if ( json[ c ] ) {
66-
throw new Error( 'unexpected error. Duplicate emoji code: `' + c + '`.' );
67+
throw new Error( format( 'unexpected error. Duplicate emoji code: `%s`.', c ) );
6768
}
6869
json[ c ] = d.emoji;
6970
}

lib/node_modules/@stdlib/datasets/fivethirtyeight-ffq/scripts/build.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
var resolve = require( 'path' ).resolve;
2424
var readFile = require( '@stdlib/fs/read-file' ).sync;
2525
var writeFile = require( '@stdlib/fs/write-file' ).sync;
26+
var format = require( '@stdlib/string/format' );
2627
var RE_EOL = require( '@stdlib/regexp/eol' ).REGEXP;
2728
var meta = require( './../datapackage.json' );
2829

@@ -78,7 +79,7 @@ function main() {
7879
for ( i = 0; i < data.length; i++ ) {
7980
d = data[ i ];
8081
if ( d.length !== fields.length ) {
81-
throw new Error( 'unexpected error. Number of expected fields ('+fields.length+') does not match number of data fields ('+d.length+').' );
82+
throw new Error( format( 'unexpected error. Number of expected fields (%d) does not match number of data fields (%d).', fields.length, d.length ) );
8283
}
8384
tmp = {};
8485
for ( j = 0; j < fields.length; j++ ) {

lib/node_modules/@stdlib/datasets/frb-sf-wage-rigidity/scripts/build_json.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
var resolve = require( 'path' ).resolve;
2424
var writeFileSync = require( '@stdlib/fs/write-file' ).sync;
2525
var readFileSync = require( '@stdlib/fs/read-file' ).sync;
26+
var format = require( '@stdlib/string/format' );
2627
var RE_EOL = require( '@stdlib/regexp/eol' ).REGEXP;
2728

2829

@@ -66,7 +67,7 @@ function main() {
6667
} else {
6768
tmp = file[ i ].split( ',' );
6869
if ( tmp.length !== headers.length ) {
69-
throw new Error( 'number of columns does not match number of columns for row '+i+'.' );
70+
throw new Error( format( 'number of columns does not match number of columns for row %d.', i ) );
7071
}
7172
row = {};
7273
for ( j = 0; j < headers.length; j++ ) {

lib/node_modules/@stdlib/datasets/moby-dick/scripts/to_json.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
var resolve = require( 'path' ).resolve;
2727
var readFileSync = require( '@stdlib/fs/read-file' ).sync;
2828
var writeFileSync = require( '@stdlib/fs/write-file' ).sync;
29+
var format = require( '@stdlib/string/format' );
2930
var replace = require( '@stdlib/string/replace' );
3031
var FILE_LIST = require( './../data/file_list.json' );
3132

@@ -68,28 +69,28 @@ function main() {
6869
} else if ( f === 'epilogue.txt' ) {
6970
tmp = RE_TITLE.exec( file );
7071
if ( !tmp ) {
71-
throw new Error( 'Unexpected file content for file '+f+'.' );
72+
throw new Error( format( 'Unexpected file content for file %s.', f ) );
7273
}
7374
out.chapter = 'Epilogue';
7475
out.title = tmp[ 1 ];
7576
} else if ( f === 'etymology.txt' ) {
7677
tmp = RE_TITLE.exec( file );
7778
if ( !tmp ) {
78-
throw new Error( 'Unexpected file content for file '+f+'.' );
79+
throw new Error( format( 'Unexpected file content for file %s.', f ) );
7980
}
8081
out.chapter = 'Etymology';
8182
out.title = tmp[ 1 ];
8283
} else if ( f === 'extracts.txt' ) {
8384
tmp = RE_TITLE.exec( file );
8485
if ( !tmp ) {
85-
throw new Error( 'Unexpected file content for file '+f+'.' );
86+
throw new Error( format( 'Unexpected file content for file %s.', f ) );
8687
}
8788
out.chapter = 'Extracts';
8889
out.title = tmp[ 1 ];
8990
} else {
9091
tmp = RE_CHAPTER_TITLE.exec( file );
9192
if ( !tmp ) {
92-
throw new Error( 'Unexpected file content for file '+f+'.' );
93+
throw new Error( format( 'Unexpected file content for file %s.', f ) );
9394
}
9495
out.chapter = tmp[ 1 ];
9596
out.title = tmp[ 2 ];

0 commit comments

Comments
 (0)