refactor: apply suggestions from code review

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: skipped
  - task: lint_license_headers
    status: passed
---

Author: headlessNode

lib/node_modules/@stdlib/ndarray/rot90/README.md

@@ -76,6 +76,7 @@ The function accepts the following options:
 
 -   If `k > 0`, the function rotates the plane from the first specified dimension toward the second specified dimension. This means that, for a two-dimensional ndarray and `dims = [0, 1]`, the function rotates the plane counterclockwise.
 -   If `k < 0`, the function rotates the plane from the second specified dimension toward the first specified dimension. This means that, for a two-dimensional ndarray and `dims = [1, 0]`, the function rotates the plane clockwise.
+-   Each provided dimension index must reside on the interval `[-ndims, ndims-1]`.
 
 </section>
 

lib/node_modules/@stdlib/ndarray/rot90/docs/repl.txt

@@ -3,6 +3,18 @@
     Returns a read-only view of an input ndarray rotated 90 degrees in a
     specified plane.
 
+    If `k > 0`, the function rotates the plane from the first specified
+    dimension toward the second specified dimension. This means that, for a
+    two-dimensional ndarray and `dims = [0, 1]`, the function rotates the plane
+    counterclockwise.
+
+    If `k < 0`, the function rotates the plane from the second specified
+    dimension toward the first specified dimension. This means that, for a
+    two-dimensional ndarray and `dims = [1, 0]`, the function rotates the plane
+    clockwise.
+
+    Each provided dimension index must reside on the interval [-ndims, ndims-1].
+
     Parameters
     ----------
     x: ndarray
@@ -16,7 +28,9 @@
 
     options.dims: ArrayLikeObject<integer> (optional)
         Dimension indices defining the plane of rotation. Must contain exactly
-        two unique dimension indices. Default: [ -2, -1 ].
+        two unique dimension indices. If less than zero, an index is resolved
+        relative to the last dimension, with the last dimension corresponding to
+        the value `-1`. Default: [ -2, -1 ].
 
     Returns
     -------

lib/node_modules/@stdlib/ndarray/rot90/docs/types/index.d.ts

@@ -21,7 +21,7 @@
 /// <reference types="@stdlib/types"/>
 
 import { ndarray } from '@stdlib/types/ndarray';
-import { Collection } from '@stdlib/types/array';
+import { ArrayLike } from '@stdlib/types/array';
 
 /**
 * Interface defining function options.
@@ -35,17 +35,21 @@ interface Options {
 	/**
 	* Dimension indices defining the plane of rotation (default: [-2, -1]).
 	*/
-	dims?: Collection<number>;
+	dims?: ArrayLike<number>;
 }
 
 /**
 * Returns a read-only view of an input ndarray rotated 90 degrees in a specified plane.
 *
+* ## Notes
+*
+* -   Each provided dimension index must reside on the interval `[-ndims, ndims-1]`.
+*
 * @param x - input array
 * @param options - function options
 * @param options.k - number of times to rotate by 90 degrees (default: 1)
 * @param options.dims - dimension indices defining the plane of rotation (default: [-2, -1])
-* @returns ndarray view
+* @returns output array
 *
 * @example
 * var array = require( '@stdlib/ndarray/array' );

lib/node_modules/@stdlib/ndarray/rot90/lib/main.js

@@ -20,10 +20,11 @@
 
 // MODULES //
 
-var isPlainObject = require( '@stdlib/assert/is-plain-object' );
+var isIntegerArray = require( '@stdlib/assert/is-integer-array' ).primitives;
+var isEmptyCollection = require( '@stdlib/assert/is-empty-collection' );
 var isInteger = require( '@stdlib/assert/is-integer' ).isPrimitive;
+var isPlainObject = require( '@stdlib/assert/is-plain-object' );
 var isndarrayLike = require( '@stdlib/assert/is-ndarray-like' );
-var isCollection = require( '@stdlib/assert/is-collection' );
 var hasOwnProp = require( '@stdlib/assert/has-own-property' );
 var base = require( '@stdlib/ndarray/base/rot90' );
 var format = require( '@stdlib/string/format' );
@@ -34,14 +35,18 @@ var format = require( '@stdlib/string/format' );
 /**
 * Returns a read-only view of an input ndarray rotated 90 degrees in a specified plane.
 *
+* ## Notes
+*
+* -   Each provided dimension index must reside on the interval `[-ndims, ndims-1]`.
+*
 * @param {ndarray} x - input array
 * @param {Options} [options] - function options
 * @param {integer} [options.k=1] - number of times to rotate by 90 degrees
 * @param {IntegerArray} [options.dims=[-2,-1]] - dimension indices defining the plane of rotation
 * @throws {TypeError} first argument must be an ndarray
 * @throws {TypeError} options argument must be an object
 * @throws {TypeError} `k` option must be an integer
-* @throws {TypeError} `dims` option must be an array-like object of integers
+* @throws {TypeError} `dims` option must be an array of integers
 * @throws {RangeError} must provide exactly two dimension indices
 * @throws {RangeError} input ndarray must have at least two dimensions
 * @throws {RangeError} must provide valid dimension indices
@@ -77,8 +82,8 @@ function rot90( x, options ) {
 			k = options.k;
 		}
 		if ( hasOwnProp( options, 'dims' ) ) {
-			if ( !isCollection( options.dims ) ) {
-				throw new TypeError( format( 'invalid option. `%s` option must be an array-like object. Option: `%s`.', 'dims', options.dims ) );
+			if ( !isIntegerArray( options.dims ) && !isEmptyCollection( options.dims ) ) { // eslint-disable-line max-len
+				throw new TypeError( format( 'invalid option. `%s` option must be an array of integers. Option: `%s`.', 'dims', options.dims ) );
 			}
 			dims = options.dims;
 		}

lib/node_modules/@stdlib/ndarray/rot90/test/test.js

@@ -170,6 +170,36 @@ tape( 'the function throws an error if provided a `dims` option which is not an
 	}
 });
 
+tape( 'the function throws an error if provided a `dims` option which is not an array of integers', function test( t ) {
+	var values;
+	var x;
+	var i;
+
+	x = new ndarray( 'float64', [ 1, 2, 3, 4 ], [ 2, 2 ], [ 2, 1 ], 0, 'row-major' );
+
+	values = [
+		[ '0', '1' ],
+		[ 0.5, 1.5 ],
+		[ NaN, NaN ],
+		[ null, null ],
+		[ true, false ],
+		[ {}, {} ]
+	];
+
+	for ( i = 0; i < values.length; i++ ) {
+		t.throws( badValue( values[ i ] ), TypeError, 'throws an error when provided [' + values[ i ] + ']' );
+	}
+	t.end();
+
+	function badValue( value ) {
+		return function badValue() {
+			rot90( x, {
+				'dims': value
+			});
+		};
+	}
+});
+
 tape( 'the function throws an error if provided a `dims` option which does not contain exactly two dimension indices', function test( t ) {
 	var values;
 	var x;