Skip to content

Commit e28dc9f

Browse files
chore: update according to code review
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Nakul Krishnakumar <nakulkrishnakumar86@gmail.com>
1 parent 1f04cf2 commit e28dc9f

5 files changed

Lines changed: 10 additions & 5 deletions

File tree

lib/node_modules/@stdlib/stats/strided/distances/dminkowski/benchmark/benchmark.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ var isnan = require( '@stdlib/math/base/assert/is-nan' );
2626
var Float64Array = require( '@stdlib/array/float64' );
2727
var pow = require( '@stdlib/math/base/special/pow' );
2828
var format = require( '@stdlib/string/format' );
29+
var PINF = require( '@stdlib/constants/float64/pinf' );
2930
var pkg = require( './../package.json' ).name;
3031
var dminkowski = require( './../lib/dminkowski.js' );
3132

@@ -97,7 +98,7 @@ function main() {
9798

9899
min = 1; // 10^min
99100
max = 6; // 10^max
100-
p = new Float64Array( [ 1.0, 2.0, 10.0, Infinity ] );
101+
p = new Float64Array( [ 1.0, 2.0, 10.0, PINF ] );
101102

102103
for ( i = 0; i < p.length; i++ ) {
103104
for ( j = min; j <= max; j++ ) {

lib/node_modules/@stdlib/stats/strided/distances/dminkowski/benchmark/benchmark.native.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ var Float64Array = require( '@stdlib/array/float64' );
2828
var pow = require( '@stdlib/math/base/special/pow' );
2929
var tryRequire = require( '@stdlib/utils/try-require' );
3030
var format = require( '@stdlib/string/format' );
31+
var PINF = require( '@stdlib/constants/float64/pinf' );
3132
var pkg = require( './../package.json' ).name;
3233

3334

@@ -102,7 +103,7 @@ function main() {
102103

103104
min = 1; // 10^min
104105
max = 6; // 10^max
105-
p = new Float64Array( [ 1.0, 2.0, 10.0, Infinity ] );
106+
p = new Float64Array( [ 1.0, 2.0, 10.0, PINF ] );
106107

107108
for ( i = 0; i < p.length; i++ ) {
108109
for ( j = min; j <= max; j++ ) {

lib/node_modules/@stdlib/stats/strided/distances/dminkowski/benchmark/benchmark.ndarray.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ var isnan = require( '@stdlib/math/base/assert/is-nan' );
2626
var Float64Array = require( '@stdlib/array/float64' );
2727
var pow = require( '@stdlib/math/base/special/pow' );
2828
var format = require( '@stdlib/string/format' );
29+
var PINF = require( '@stdlib/constants/float64/pinf' );
2930
var pkg = require( './../package.json' ).name;
3031
var dminkowski = require( './../lib/ndarray.js' );
3132

@@ -97,7 +98,7 @@ function main() {
9798

9899
min = 1; // 10^min
99100
max = 6; // 10^max
100-
p = new Float64Array( [ 1.0, 2.0, 10.0, Infinity ] );
101+
p = new Float64Array( [ 1.0, 2.0, 10.0, PINF ] );
101102

102103
for ( i = 0; i < p.length; i++ ) {
103104
for ( j = min; j <= max; j++ ) {

lib/node_modules/@stdlib/stats/strided/distances/dminkowski/benchmark/benchmark.ndarray.native.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ var Float64Array = require( '@stdlib/array/float64' );
2828
var pow = require( '@stdlib/math/base/special/pow' );
2929
var tryRequire = require( '@stdlib/utils/try-require' );
3030
var format = require( '@stdlib/string/format' );
31+
var PINF = require( '@stdlib/constants/float64/pinf' );
3132
var pkg = require( './../package.json' ).name;
3233

3334

@@ -102,7 +103,7 @@ function main() {
102103

103104
min = 1; // 10^min
104105
max = 6; // 10^max
105-
p = new Float64Array( [ 1.0, 2.0, 10.0, Infinity ] );
106+
p = new Float64Array( [ 1.0, 2.0, 10.0, PINF ] );
106107

107108
for ( i = 0; i < p.length; i++ ) {
108109
for ( j = min; j <= max; j++ ) {

lib/node_modules/@stdlib/stats/strided/distances/dminkowski/benchmark/c/benchmark.length.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
*/
1818

1919
#include "stdlib/stats/strided/distances/dminkowski.h"
20+
#include "stdlib/constants/float64/pinf.h"
2021
#include <stdlib.h>
2122
#include <stdio.h>
2223
#include <math.h>
@@ -173,7 +174,7 @@ static double benchmark2( int iterations, int len, double p ) {
173174
* Main execution sequence.
174175
*/
175176
int main( void ) {
176-
const double powers[ 4 ] = { 1.0, 2.0, 10.0, INFINITY };
177+
const double powers[ 4 ] = { 1.0, 2.0, 10.0, STDLIB_CONSTANT_FLOAT64_PINF };
177178
double elapsed;
178179
int count;
179180
int iter;

0 commit comments

Comments
 (0)