Merge remote-tracking branch 'upstream/develop' into fix/band-storage-mismatch

Author: stdlib-bot

.editorconfig

@@ -165,6 +165,15 @@ indent_style = tab
 indent_style = space
 indent_size = 2
 
+# Ignore generated lock files for GitHub Agentic Workflows:
+[*.lock.yml]
+charset = unset
+end_of_line = unset
+indent_style = unset
+indent_size = unset
+trim_trailing_whitespace = unset
+insert_final_newline = unset
+
 # Set properties for GYP files:
 [binding.gyp]
 indent_style = space

.gitattributes

@@ -64,3 +64,5 @@ Makefile linguist-vendored
 
 # Configure files which should be included in GitHub language statistics:
 docs/types/*.d.ts -linguist-documentation
+
+.github/workflows/*.lock.yml linguist-generated=true merge=ours

.github/aw/actions-lock.json

@@ -0,0 +1,14 @@
+{
+  "entries": {
+    "actions/github-script@v8": {
+      "repo": "actions/github-script",
+      "version": "v8",
+      "sha": "ed597411d8f924073f98dfc5c65a23a2325f34cd"
+    },
+    "github/gh-aw-actions/setup@v0.61.2": {
+      "repo": "github/gh-aw-actions/setup",
+      "version": "v0.61.2",
+      "sha": "71cfb3cbe2002225f9d5afa180669fff36b86ea2"
+    }
+  }
+}

.github/workflows/check_pr_issue_references.lock.yml

@@ -0,0 +1,136 @@
+---
+description: >
+  Checks whether issue/PR references in a PR body are actually related to the PR.
+  Posts an informational comment when suspicious references are detected.
+
+run-name: check_pr_issue_references
+
+on:
+  schedule: every 6h
+  workflow_dispatch:
+    inputs:
+      pr_numbers:
+        description: 'Comma-separated PR numbers to check (leave empty to auto-discover recent PRs)'
+        required: false
+        type: string
+
+permissions:
+  contents: read
+  issues: read
+  pull-requests: read
+
+engine:
+  id: copilot
+
+tools:
+  github:
+    toolsets: [issues, pull_requests, repos]
+    lockdown: false
+    min-integrity: none
+    repos: all
+
+network:
+  allowed:
+    - defaults
+
+safe-outputs:
+  add-comment:
+    max: 10
+  noop:
+    max: 10
+
+timeout-minutes: 10
+---
+
+# Check PR Issue References
+
+You are a reference validator for the stdlib-js/stdlib repository. Your task is
+to check whether issue/PR references in pull request descriptions are actually
+related to the PRs.
+
+## Step 1: Discover PRs to Check
+
+If `${{ github.event.inputs.pr_numbers }}` is provided, parse it as a
+comma-separated list of PR numbers and fetch those PRs.
+
+Otherwise, use the GitHub tool to list open pull requests in `stdlib-js/stdlib`,
+sorted by `updated` in descending order. Filter to PRs whose `updated_at` is
+within the last 7 hours. If no PRs match, call `noop` with "No recently updated
+PRs found" and stop.
+
+Process at most 10 PRs per run.
+
+## Step 2: Check for Existing Comments (Deduplication)
+
+For each PR, before analyzing it:
+
+1. List comments on the PR using the GitHub tool.
+2. If any comment body contains the heading `**Issue Reference Review**`, this
+   PR was already checked. Skip it and call `noop` with "PR #X already has an
+   Issue Reference Review comment. Skipping."
+3. If no such comment exists, proceed to Step 3.
+
+## Step 3: Extract and Assess References
+
+For each PR that passes deduplication:
+
+1. **Extract all issue/PR references** from the PR body. Look for:
+   - `#123` (bare references)
+   - `stdlib-js/stdlib#123` (qualified references)
+   - `https://github.com/stdlib-js/stdlib/issues/123` (URL references)
+   - Pay special attention to closing keywords: Resolves, Closes, Fixes (and variants)
+
+2. **For each referenced issue/PR**, fetch its title and body using the GitHub tool.
+
+3. **Assess whether each reference is plausibly related** to the pull request:
+   - **related**: Clear topical connection (same package, same feature area, PR addresses the issue)
+   - **suspicious**: Connection is unclear or tenuous
+   - **unrelated**: Completely different topics, packages, or feature areas
+
+## Assessment Guidelines
+
+- stdlib is a large numerical/scientific computing library with thousands of packages
+  (e.g., `@stdlib/math/base/special/sin`, `@stdlib/stats/incr/mean`)
+- A PR adding a new package often references the issue that requested it — this is VALID
+- A PR fixing tests/benchmarks/docs for a package may reference the original creation issue — VALID
+- References to "Tracking Issues" (issues listing many sub-tasks) are usually VALID
+- PRs may reference broad project-wide issues — give benefit of the doubt
+- **When in doubt, lean toward "related".** False positives are worse than false negatives.
+- If a PR has no issue references at all, that is fine — call noop.
+- If a PR has more than 10 references, call noop (too many to meaningfully assess).
+
+## Safe Outputs
+
+When calling `add-comment`, you **MUST** set the `item_number` parameter to the
+PR number so the comment is posted on the correct PR.
+
+- **If ALL references appear related** (or there are no references): Call `noop` with a
+  brief explanation like "All N issue references in PR #X appear related."
+
+- **If any references appear suspicious or unrelated**: Use `add-comment` to post a
+  comment on the PR:
+
+  > ⚠️ **Issue Reference Review**
+  >
+  > An automated check found potentially unrelated issue/PR references in this PR:
+  >
+  > | Reference | Assessment | Reasoning |
+  > | --- | --- | --- |
+  > | #123 | suspicious | PR adds math/sin but issue is about string/trim |
+  >
+  > **Why this matters:** GitHub automatically closes issues referenced with closing
+  > keywords (Resolves, Closes, Fixes) when the PR is merged. Incorrect references
+  > can accidentally close unrelated issues.
+  >
+  > **What to do:**
+  > - If the reference is correct, no action needed. This check may produce false positives.
+  > - If the reference is incorrect, please update your PR description.
+  >
+  > *This assessment was generated by an AI model and is informational only.*
+
+  Only include suspicious/unrelated references in the table, not related ones.
+
+## Important Notes
+
+- Process each PR independently. A failure on one PR should not prevent checking others.
+- A `noop` call is expected for each PR that is skipped or has all-valid references.

.github/workflows/check_pr_issue_references.md

@@ -147,7 +147,7 @@ jobs:
       - name: 'Lint Markdown files'
         if: success() || failure()
         run: |
-          files=$(echo "${{ steps.changed-files.outputs.files }}" | tr ' ' '\n' | grep -E '\.md$' | tr '\n' ' ' | sed 's/ $//')
+          files=$(echo "${{ steps.changed-files.outputs.files }}" | tr ' ' '\n' | grep -E '\.md$' | grep -v '^\.github/workflows/.*\.md$' | tr '\n' ' ' | sed 's/ $//')
           if [ -n "${files}" ]; then
             make lint-markdown-files FILES="${files}"
           fi
@@ -345,7 +345,7 @@ jobs:
       - name: 'Lint license headers'
         if: success() || failure()
         run: |
-          files=$(echo "${{ steps.changed-files.outputs.files }}")
+          files=$(echo "${{ steps.changed-files.outputs.files }}" | tr ' ' '\n' | grep -v '\.github/workflows/.*\.md$' | grep -v '\.lock\.yml$' | tr '\n' ' ' | sed 's/ $//')
           if [[ -n "${files}" ]]; then
             make lint-license-headers-files FILES="${files}"
           fi

.github/workflows/lint_changed_files.yml

@@ -30,7 +30,7 @@
 #   LOG_FILE       Log file.
 #
 
-# shellcheck disable=SC2034,SC2153,SC2317
+# shellcheck disable=SC2034,SC2086,SC2153,SC2317
 
 # Ensure that the exit status of pipelines is non-zero in the event that at least one of the commands in a pipeline fails:
 set -o pipefail
@@ -141,7 +141,8 @@ main() {
 
 	# Run JS benchmarks:
 	if [ -n "${js_bench_files}" ]; then
-		make benchmark-javascript-files FILES="${js_bench_files}"
+		# Invoke make in batches to avoid "Argument list too long" errors:
+		printf '%s\n' ${js_bench_files} | xargs sh -c 'make benchmark-javascript-files FILES="$*"' _
 	else
 		echo 'No JavaScript benchmarks to run.' >&2
 	fi
@@ -172,7 +173,8 @@ main() {
 	fi
 
 	if [ -n "${c_bench_files}" ]; then
-		make benchmark-c-files FILES="${c_bench_files}"
+		# Invoke make in batches to avoid "Argument list too long" errors:
+		printf '%s\n' ${c_bench_files} | xargs sh -c 'make benchmark-c-files FILES="$*"' _
 	else
 		echo 'No C benchmarks to run.' >&2
 	fi

.github/workflows/scripts/run_affected_benchmarks/run

@@ -165,7 +165,8 @@ main() {
 	files=$(echo "${files}" | grep -v '/fixtures/') || true
 
 	if [[ -n "${files}" ]]; then
-		make test-javascript-files-min FILES="${files}"
+		# Invoke make in batches to avoid "Argument list too long" errors:
+		printf '%s\n' ${files} | xargs sh -c 'make test-javascript-files-min FILES="$*"' _
 	fi
 
 	cleanup

.github/workflows/scripts/run_affected_tests/run

@@ -18,21 +18,7 @@ limitations under the License.
 
 -->
 
-<!-- lint disable first-heading-level -->
-
-<!-- FIXME: the following two empty sections are merely to satisfy the linter for `expected-html-sections` which cannot, atm, be turned off -->
-
-<section class="usage">
-
-</section>
-
-<!-- /.usage -->
-
-<section class="examples">
-
-</section>
-
-<!-- /.examples -->
+<!-- lint disable first-heading-level expected-html-sections -->
 
 <!-- Section to include announcements. If section is included, add a horizontal rule *after* the section. Make sure to keep an empty line after the `section` element and another before the `/section` close. -->
 

README.md

@@ -30,6 +30,47 @@ var keys = require( '@stdlib/utils/keys' );
 var debug = logger( 'remark-lint-expected-html-sections' );
 var RE_SECTION_START = /<section(?:\s+class="([^"]*)")?>/;
 var RE_SECTION_END = /<\/section>/;
+var RE_HTML_COMMENT = /^\s*<!--[\s\S]*-->\s*$/;
+
+
+// FUNCTIONS //
+
+/**
+* Returns a message anchor node.
+*
+* @private
+* @param {Node} tree - abstract syntax tree (AST)
+* @returns {Node} anchor node
+*/
+function getAnchorNode( tree ) {
+	var node;
+	var i;
+
+	for ( i = 0; i < tree.children.length; i++ ) {
+		node = tree.children[ i ];
+		if ( node.type === 'yaml' ) {
+			continue;
+		}
+		if ( node.type === 'html' && RE_HTML_COMMENT.test( node.value ) ) {
+			continue;
+		}
+		return node;
+	}
+	return tree;
+}
+
+/**
+* Reports a lint message.
+*
+* @private
+* @param {File} file - virtual file
+* @param {Node} node - anchor node
+* @param {string} msg - message
+* @returns {void}
+*/
+function reportMessage( file, node, msg ) {
+	file.message( msg, node, 'remark-lint:expected-html-sections' );
+}
 
 
 // MAIN //
@@ -60,6 +101,7 @@ function factory( options ) {
 		var sectionsFound;
 		var sectionStack;
 		var missingRoot;
+		var anchorNode;
 		var missingC;
 		var schema;
 		var msg;
@@ -78,6 +120,9 @@ function factory( options ) {
 			'c': {}
 		};
 
+		// Anchor messages to content nodes so inline lint comments can control reporting:
+		anchorNode = getAnchorNode( tree );
+
 		// Visit all HTML nodes to build section structure:
 		visit( tree, 'html', visitor );
 
@@ -101,7 +146,7 @@ function factory( options ) {
 		if ( missingRoot.length > 0 ) {
 			msg = 'Missing required root-level sections: `' + missingRoot.join( '`, `' ) + '`. Required sections are: `' + requiredRootSections.join( '`, `' ) + '`.   missing-required-sections';
 			debug( msg );
-			file.message( msg, tree, 'remark-lint:expected-html-sections' );
+			reportMessage( file, anchorNode, msg );
 		}
 
 		// If 'c' section exists, check its requirements:
@@ -119,7 +164,7 @@ function factory( options ) {
 			if ( missingC.length > 0 ) {
 				msg = 'Missing required sections in "c" section: `' + missingC.join( '`, `' ) + '`. Required C sections are: `' + requiredCSections.join( '`, `' ) + '`.   missing-required-c-sections';
 				debug( msg );
-				file.message( msg, sectionsFound.root.c.node, 'remark-lint:expected-html-sections' );
+				reportMessage( file, sectionsFound.root.c.node, msg );
 			}
 		}