fix: update according to code review

Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Nakul Krishnakumar <nakulkrishnakumar86@gmail.com>

Author: nakul-krishnakumar

lib/node_modules/@stdlib/stats/strided/distances/dminkowski/benchmark/benchmark.js

@@ -103,7 +103,7 @@ function main() {
 		for ( j = min; j <= max; j++ ) {
 			len = pow( 10, i );
 			f = createBenchmark( len, p[ i ] );
-			bench( format( '%s:len=%d:p=%.2f', pkg, len, p[ i ] ), f );
+			bench( format( '%s:len=%d,p=%.2f', pkg, len, p[ i ] ), f );
 		}
 	}
 }

lib/node_modules/@stdlib/stats/strided/distances/dminkowski/benchmark/benchmark.native.js

@@ -108,7 +108,7 @@ function main() {
 		for ( j = min; j <= max; j++ ) {
 			len = pow( 10, i );
 			f = createBenchmark( len, p[ i ] );
-			bench( format( '%s::native:len=%d:p=%.2f', pkg, len, p[ i ] ), opts, f );
+			bench( format( '%s::native:len=%d,p=%.2f', pkg, len, p[ i ] ), opts, f );
 		}
 	}
 }

lib/node_modules/@stdlib/stats/strided/distances/dminkowski/benchmark/benchmark.ndarray.js

@@ -103,7 +103,7 @@ function main() {
 		for ( j = min; j <= max; j++ ) {
 			len = pow( 10, i );
 			f = createBenchmark( len, p[ i ] );
-			bench( format( '%s:ndarray:len=%d:p=%.2f', pkg, len, p[ i ] ), f );
+			bench( format( '%s:ndarray:len=%d,p=%.2f', pkg, len, p[ i ] ), f );
 		}
 	}
 }

lib/node_modules/@stdlib/stats/strided/distances/dminkowski/benchmark/benchmark.ndarray.native.js

@@ -108,7 +108,7 @@ function main() {
 		for ( j = min; j <= max; j++ ) {
 			len = pow( 10, i );
 			f = createBenchmark( len, p[ i ] );
-			bench( format( '%s::native:ndarray:len=%d:p=%.2f', pkg, len, p[ i ] ), opts, f );
+			bench( format( '%s::native:ndarray:len=%d,p=%.2f', pkg, len, p[ i ] ), opts, f );
 		}
 	}
 }

lib/node_modules/@stdlib/stats/strided/distances/dminkowski/benchmark/c/benchmark.length.c

@@ -94,7 +94,7 @@ static double random_uniform( const double min, const double max ) {
 *
 * @param iterations   number of iterations
 * @param len          array length
-* @param p			  power
+* @param p            power
 * @return             elapsed time in seconds
 */
 static double benchmark1( int iterations, int len, double p ) {
@@ -134,7 +134,7 @@ static double benchmark1( int iterations, int len, double p ) {
 *
 * @param iterations   number of iterations
 * @param len          array length
-* @param p			  power
+* @param p            power
 * @return             elapsed time in seconds
 */
 static double benchmark2( int iterations, int len, double p ) {
@@ -194,14 +194,14 @@ int main( void ) {
 		for ( p = 0; p < 4; p++ ) {
 			for ( j = 0; j < REPEATS; j++ ) {
 				count += 1;
-				printf( "# c::%s:len=%d:p=%.2f\n", NAME, len, powers[ p ] );
+				printf( "# c::%s:len=%d,p=%.2f\n", NAME, len, powers[ p ] );
 				elapsed = benchmark1( iter, len, powers[ p ] );
 				print_results( iter, elapsed );
 				printf( "ok %d benchmark finished\n", count );
 			}
 			for ( j = 0; j < REPEATS; j++ ) {
 				count += 1;
-				printf( "# c::%s:ndarray:len=%d:p=%.2f\n", NAME, len, powers[ p ] );
+				printf( "# c::%s:ndarray:len=%d,p=%.2f\n", NAME, len, powers[ p ] );
 				elapsed = benchmark2( iter, len, powers[ p ] );
 				print_results( iter, elapsed );
 				printf( "ok %d benchmark finished\n", count );

lib/node_modules/@stdlib/stats/strided/distances/dminkowski/docs/types/test.ts

@@ -246,7 +246,7 @@ import dminkowski = require( './index' );
 	dminkowski.ndarray( x.length, 3, x, 1, 0, y, ( x: number ): number => x, 0 ); // $ExpectError
 }
 
-// The compiler throws an error if the `ndarray` method is provided a eighth argument which is not a number...
+// The compiler throws an error if the `ndarray` method is provided an eighth argument which is not a number...
 {
 	const x = new Float64Array( 10 );
 	const y = new Float64Array( 10 );

lib/node_modules/@stdlib/stats/strided/distances/dminkowski/examples/c/example.c

@@ -27,8 +27,10 @@ int main( void ) {
 	// Specify the number of elements:
 	const int N = 8;
 
-	// Specify strides:
+	// Specify the order of the Minkowski norm:
 	const double p = 3.0;
+
+	// Specify strides:
 	const int strideX = 1;
 	const int strideY = -1;
 

lib/node_modules/@stdlib/stats/strided/distances/dminkowski/lib/dminkowski.js

@@ -30,7 +30,7 @@ var ndarray = require( './ndarray.js' );
 * Computes the Minkowski distance between two double-precision floating-point strided arrays.
 *
 * @param {NonNegativeInteger} N - number of indexed elements
-* @param {PositiveInteger} p - order of the Minkowski norm
+* @param {number} p - order of the Minkowski norm
 * @param {Float64Array} x - first input array
 * @param {integer} strideX - stride length of `x`
 * @param {Float64Array} y - second input array

lib/node_modules/@stdlib/stats/strided/distances/dminkowski/lib/dminkowski.native.js

@@ -29,7 +29,7 @@ var addon = require( './../src/addon.node' );
 * Computes the Minkowski distance between two double-precision floating-point strided arrays.
 *
 * @param {NonNegativeInteger} N - number of indexed elements
-* @param {PositiveInteger} p - order of the Minkowski norm
+* @param {number} p - order of the Minkowski norm
 * @param {Float64Array} x - first input array
 * @param {integer} strideX - stride length of `x`
 * @param {Float64Array} y - second input array

lib/node_modules/@stdlib/stats/strided/distances/dminkowski/lib/ndarray.js

@@ -25,6 +25,7 @@ var pow = require( '@stdlib/math/base/special/pow' );
 var dcityblock = require( '@stdlib/stats/strided/distances/dcityblock' ).ndarray;
 var deuclidean = require( '@stdlib/stats/strided/distances/deuclidean' ).ndarray;
 var dchebyshev = require( '@stdlib/stats/strided/distances/dchebyshev' ).ndarray;
+var PINF = require( '@stdlib/constants/float64/pinf' );
 
 
 // MAIN //
@@ -33,7 +34,7 @@ var dchebyshev = require( '@stdlib/stats/strided/distances/dchebyshev' ).ndarray
 * Computes the Minkowski distance between two double-precision floating-point strided arrays using alternative indexing semantics.
 *
 * @param {NonNegativeInteger} N - number of indexed elements
-* @param {PositiveInteger} p - order of the Minkowski norm
+* @param {number} p - order of the Minkowski norm
 * @param {Float64Array} x - first input array
 * @param {integer} strideX - stride length of `x`
 * @param {NonNegativeInteger} offsetX - starting index for `x`
@@ -61,29 +62,26 @@ function dminkowski( N, p, x, strideX, offsetX, y, strideY, offsetY ) {
 	if ( N <= 0 ) {
 		return NaN;
 	}
-	if ( p === 1 ) {
+	if ( p === 1.0 ) {
 		return dcityblock( N, x, strideX, offsetX, y, strideY, offsetY );
 	}
-	if ( p === 2 ) {
+	if ( p === 2.0 ) {
 		return deuclidean( N, x, strideX, offsetX, y, strideY, offsetY );
 	}
-	if ( p === Infinity ) {
+	if ( p === PINF ) {
 		return dchebyshev( N, x, strideX, offsetX, y, strideY, offsetY );
 	}
 	ox = offsetX;
 	oy = offsetY;
 
-	s = abs( x[ ox ] - y[ oy ] );
-	d = pow( s, p );
-	ox += strideX;
-	oy += strideY;
-	for ( i = 1; i < N; i++ ) {
+	d = 0.0;
+	for ( i = 0; i < N; i++ ) {
 		s = abs( x[ ox ] - y[ oy ] );
 		d += pow( s, p );
 		ox += strideX;
 		oy += strideY;
 	}
-	return pow( d, 1/p );
+	return pow( d, 1.0/p );
 }