Skip to content

Commit e823856

Browse files
headlessNodeheadlessNode
committed
refactor: apply suggestions from code review
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---
1 parent e5f23f4 commit e823856

4 files changed

Lines changed: 90 additions & 84 deletions

File tree

‎lib/node_modules/@stdlib/ndarray/base/to-reversed-dimension/benchmark/benchmark.js‎

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -63,17 +63,17 @@ bench( pkg+'::1d,non-base', function benchmark( b ) {
6363
var v;
6464
var i;
6565

66-
/* eslint-disable object-curly-newline */
66+
/* eslint-disable object-curly-newline, stdlib/line-closing-bracket-spacing */
6767

6868
values = [
69-
empty( [ 2 ], { 'dtype': 'float64' }),
70-
empty( [ 2 ], { 'dtype': 'float32' }),
71-
empty( [ 2 ], { 'dtype': 'int32' }),
72-
empty( [ 2 ], { 'dtype': 'complex128' }),
73-
empty( [ 2 ], { 'dtype': 'generic' })
69+
empty( [ 2 ], { 'dtype': 'float64' } ),
70+
empty( [ 2 ], { 'dtype': 'float32' } ),
71+
empty( [ 2 ], { 'dtype': 'int32' } ),
72+
empty( [ 2 ], { 'dtype': 'complex128' } ),
73+
empty( [ 2 ], { 'dtype': 'generic' } )
7474
];
7575

76-
/* eslint-enable object-curly-newline */
76+
/* eslint-enable object-curly-newline, stdlib/line-closing-bracket-spacing */
7777

7878
b.tic();
7979
for ( i = 0; i < b.iterations; i++ ) {
@@ -123,17 +123,17 @@ bench( pkg+'::2d,non-base', function benchmark( b ) {
123123
var v;
124124
var i;
125125

126-
/* eslint-disable object-curly-newline */
126+
/* eslint-disable object-curly-newline, stdlib/line-closing-bracket-spacing */
127127

128128
values = [
129-
empty( [ 2, 2 ], { 'dtype': 'float64' }),
130-
empty( [ 2, 2 ], { 'dtype': 'float32' }),
131-
empty( [ 2, 2 ], { 'dtype': 'int32' }),
132-
empty( [ 2, 2 ], { 'dtype': 'complex128' }),
133-
empty( [ 2, 2 ], { 'dtype': 'generic' })
129+
empty( [ 2, 2 ], { 'dtype': 'float64' } ),
130+
empty( [ 2, 2 ], { 'dtype': 'float32' } ),
131+
empty( [ 2, 2 ], { 'dtype': 'int32' } ),
132+
empty( [ 2, 2 ], { 'dtype': 'complex128' } ),
133+
empty( [ 2, 2 ], { 'dtype': 'generic' } )
134134
];
135135

136-
/* eslint-enable object-curly-newline */
136+
/* eslint-enable object-curly-newline, stdlib/line-closing-bracket-spacing */
137137

138138
b.tic();
139139
for ( i = 0; i < b.iterations; i++ ) {
@@ -183,17 +183,17 @@ bench( pkg+'::3d,non-base', function benchmark( b ) {
183183
var v;
184184
var i;
185185

186-
/* eslint-disable object-curly-newline */
186+
/* eslint-disable object-curly-newline, stdlib/line-closing-bracket-spacing */
187187

188188
values = [
189-
empty( [ 2, 2, 2 ], { 'dtype': 'float64' }),
190-
empty( [ 2, 2, 2 ], { 'dtype': 'float32' }),
191-
empty( [ 2, 2, 2 ], { 'dtype': 'int32' }),
192-
empty( [ 2, 2, 2 ], { 'dtype': 'complex128' }),
193-
empty( [ 2, 2, 2 ], { 'dtype': 'generic' })
189+
empty( [ 2, 2, 2 ], { 'dtype': 'float64' } ),
190+
empty( [ 2, 2, 2 ], { 'dtype': 'float32' } ),
191+
empty( [ 2, 2, 2 ], { 'dtype': 'int32' } ),
192+
empty( [ 2, 2, 2 ], { 'dtype': 'complex128' } ),
193+
empty( [ 2, 2, 2 ], { 'dtype': 'generic' } )
194194
];
195195

196-
/* eslint-enable object-curly-newline */
196+
/* eslint-enable object-curly-newline, stdlib/line-closing-bracket-spacing */
197197

198198
b.tic();
199199
for ( i = 0; i < b.iterations; i++ ) {
@@ -243,17 +243,17 @@ bench( pkg+'::4d,non-base', function benchmark( b ) {
243243
var v;
244244
var i;
245245

246-
/* eslint-disable object-curly-newline */
246+
/* eslint-disable object-curly-newline, stdlib/line-closing-bracket-spacing */
247247

248248
values = [
249-
empty( [ 2, 2, 2, 2 ], { 'dtype': 'float64' }),
250-
empty( [ 2, 2, 2, 2 ], { 'dtype': 'float32' }),
251-
empty( [ 2, 2, 2, 2 ], { 'dtype': 'int32' }),
252-
empty( [ 2, 2, 2, 2 ], { 'dtype': 'complex128' }),
253-
empty( [ 2, 2, 2, 2 ], { 'dtype': 'generic' })
249+
empty( [ 2, 2, 2, 2 ], { 'dtype': 'float64' } ),
250+
empty( [ 2, 2, 2, 2 ], { 'dtype': 'float32' } ),
251+
empty( [ 2, 2, 2, 2 ], { 'dtype': 'int32' } ),
252+
empty( [ 2, 2, 2, 2 ], { 'dtype': 'complex128' } ),
253+
empty( [ 2, 2, 2, 2 ], { 'dtype': 'generic' } )
254254
];
255255

256-
/* eslint-enable object-curly-newline */
256+
/* eslint-enable object-curly-newline, stdlib/line-closing-bracket-spacing */
257257

258258
b.tic();
259259
for ( i = 0; i < b.iterations; i++ ) {
@@ -303,17 +303,17 @@ bench( pkg+'::5d,non-base', function benchmark( b ) {
303303
var v;
304304
var i;
305305

306-
/* eslint-disable object-curly-newline */
306+
/* eslint-disable object-curly-newline, stdlib/line-closing-bracket-spacing */
307307

308308
values = [
309-
empty( [ 2, 2, 2, 2, 2 ], { 'dtype': 'float64' }),
310-
empty( [ 2, 2, 2, 2, 2 ], { 'dtype': 'float32' }),
311-
empty( [ 2, 2, 2, 2, 2 ], { 'dtype': 'int32' }),
312-
empty( [ 2, 2, 2, 2, 2 ], { 'dtype': 'complex128' }),
313-
empty( [ 2, 2, 2, 2, 2 ], { 'dtype': 'generic' })
309+
empty( [ 2, 2, 2, 2, 2 ], { 'dtype': 'float64' } ),
310+
empty( [ 2, 2, 2, 2, 2 ], { 'dtype': 'float32' } ),
311+
empty( [ 2, 2, 2, 2, 2 ], { 'dtype': 'int32' } ),
312+
empty( [ 2, 2, 2, 2, 2 ], { 'dtype': 'complex128' } ),
313+
empty( [ 2, 2, 2, 2, 2 ], { 'dtype': 'generic' } )
314314
];
315315

316-
/* eslint-enable object-curly-newline */
316+
/* eslint-enable object-curly-newline, stdlib/line-closing-bracket-spacing */
317317

318318
b.tic();
319319
for ( i = 0; i < b.iterations; i++ ) {

‎lib/node_modules/@stdlib/ndarray/base/to-reversed-dimension/docs/types/test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ import toReversedDimension = require( './index' );
3838
toReversedDimension( empty( 'uint16', sh, order ), 0 ); // $ExpectType uint16ndarray
3939
toReversedDimension( empty( 'uint8', sh, order ), 0 ); // $ExpectType uint8ndarray
4040
toReversedDimension( empty( 'uint8c', sh, order ), 0 ); // $ExpectType uint8cndarray
41+
toReversedDimension( empty( 'generic', sh, order ), 0 ); // $ExpectType genericndarray<number>
4142
}
4243

4344
// The compiler throws an error if the function is provided a first argument which is not an ndarray...

‎lib/node_modules/@stdlib/ndarray/base/to-reversed-dimension/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
"ndarray",
6060
"matrix",
6161
"reverse",
62-
"dimenions",
62+
"dimensions",
6363
"flip",
6464
"numpy.flip"
6565
]

‎lib/node_modules/@stdlib/ndarray/base/to-reversed-dimension/test/test.js‎

Lines changed: 53 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,11 @@ var zeroTo = require( '@stdlib/array/base/zero-to' );
2626
var typedarray = require( '@stdlib/array/typed' );
2727
var ndarray2array = require( '@stdlib/ndarray/to-array' );
2828
var ctor = require( '@stdlib/ndarray/ctor' );
29+
var ndims = require( '@stdlib/ndarray/base/ndims' );
30+
var getDType = require( '@stdlib/ndarray/base/dtype' );
31+
var getData = require( '@stdlib/ndarray/base/data-buffer' );
32+
var getShape = require( '@stdlib/ndarray/base/shape' );
33+
var numel = require( '@stdlib/ndarray/base/numel' );
2934
var toReverseDimension = require( './../lib' );
3035

3136

@@ -59,10 +64,10 @@ tape( 'the function returns a new ndarray where the order of elements of an inpu
5964
actual = toReverseDimension( x, 0 );
6065

6166
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
62-
t.strictEqual( actual.ndims, 1, 'returns expected value' );
63-
t.strictEqual( actual.length, 6, 'returns expected value' );
64-
t.strictEqual( actual.dtype, x.dtype, 'returns expected value' );
65-
t.notEqual( actual.data, x.data, 'returns expected value' );
67+
t.strictEqual( ndims( actual ), 1, 'returns expected value' );
68+
t.strictEqual( numel( getShape( actual ) ), 6, 'returns expected value' );
69+
t.strictEqual( String( getDType( actual ) ), String( getDType( x ) ), 'returns expected value' );
70+
t.notEqual( getData( actual ), getData( x ), 'returns expected value' );
6671

6772
expected = [ 14, 12, 10, 8, 6, 4 ];
6873
for ( i = 0; i < expected.length; i++ ) {
@@ -72,10 +77,10 @@ tape( 'the function returns a new ndarray where the order of elements of an inpu
7277
actual = toReverseDimension( x, -1 );
7378

7479
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
75-
t.strictEqual( actual.ndims, 1, 'returns expected value' );
76-
t.strictEqual( actual.length, 6, 'returns expected value' );
77-
t.strictEqual( actual.dtype, x.dtype, 'returns expected value' );
78-
t.notEqual( actual.data, x.data, 'returns expected value' );
80+
t.strictEqual( ndims( actual ), 1, 'returns expected value' );
81+
t.strictEqual( numel( getShape( actual ) ), 6, 'returns expected value' );
82+
t.strictEqual( String( getDType( actual ) ), String( getDType( x ) ), 'returns expected value' );
83+
t.notEqual( getData( actual ), getData( x ), 'returns expected value' );
7984

8085
expected = [ 14, 12, 10, 8, 6, 4 ];
8186
for ( i = 0; i < expected.length; i++ ) {
@@ -105,10 +110,10 @@ tape( 'the function returns a new ndarray where the order of elements of an inpu
105110
actual = toReverseDimension( x, 0 );
106111

107112
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
108-
t.strictEqual( actual.ndims, 2, 'returns expected value' );
109-
t.deepEqual( actual.shape, [ 4, 3 ], 'returns expected value' );
110-
t.strictEqual( actual.dtype, x.dtype, 'returns expected value' );
111-
t.notEqual( actual.data, x.data, 'returns expected value' );
113+
t.strictEqual( ndims( actual ), 2, 'returns expected value' );
114+
t.deepEqual( getShape( actual ), [ 4, 3 ], 'returns expected value' );
115+
t.strictEqual( String( getDType( actual ) ), String( getDType( x ) ), 'returns expected value' );
116+
t.notEqual( getData( actual ), getData( x ), 'returns expected value' );
112117

113118
expected = [
114119
[ 22, 24, 26 ],
@@ -122,10 +127,10 @@ tape( 'the function returns a new ndarray where the order of elements of an inpu
122127
actual = toReverseDimension( x, -2 );
123128

124129
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
125-
t.strictEqual( actual.ndims, 2, 'returns expected value' );
126-
t.deepEqual( actual.shape, [ 4, 3 ], 'returns expected value' );
127-
t.strictEqual( actual.dtype, x.dtype, 'returns expected value' );
128-
t.notEqual( actual.data, x.data, 'returns expected value' );
130+
t.strictEqual( ndims( actual ), 2, 'returns expected value' );
131+
t.deepEqual( getShape( actual ), [ 4, 3 ], 'returns expected value' );
132+
t.strictEqual( String( getDType( actual ) ), String( getDType( x ) ), 'returns expected value' );
133+
t.notEqual( getData( actual ), getData( x ), 'returns expected value' );
129134

130135
expected = [
131136
[ 22, 24, 26 ],
@@ -139,10 +144,10 @@ tape( 'the function returns a new ndarray where the order of elements of an inpu
139144
actual = toReverseDimension( x, 1 );
140145

141146
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
142-
t.strictEqual( actual.ndims, 2, 'returns expected value' );
143-
t.deepEqual( actual.shape, [ 4, 3 ], 'returns expected value' );
144-
t.strictEqual( actual.dtype, x.dtype, 'returns expected value' );
145-
t.notEqual( actual.data, x.data, 'returns expected value' );
147+
t.strictEqual( ndims( actual ), 2, 'returns expected value' );
148+
t.deepEqual( getShape( actual ), [ 4, 3 ], 'returns expected value' );
149+
t.strictEqual( String( getDType( actual ) ), String( getDType( x ) ), 'returns expected value' );
150+
t.notEqual( getData( actual ), getData( x ), 'returns expected value' );
146151

147152
expected = [
148153
[ 8, 6, 4 ],
@@ -156,10 +161,10 @@ tape( 'the function returns a new ndarray where the order of elements of an inpu
156161
actual = toReverseDimension( x, -1 );
157162

158163
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
159-
t.strictEqual( actual.ndims, 2, 'returns expected value' );
160-
t.deepEqual( actual.shape, [ 4, 3 ], 'returns expected value' );
161-
t.strictEqual( actual.dtype, x.dtype, 'returns expected value' );
162-
t.notEqual( actual.data, x.data, 'returns expected value' );
164+
t.strictEqual( ndims( actual ), 2, 'returns expected value' );
165+
t.deepEqual( getShape( actual ), [ 4, 3 ], 'returns expected value' );
166+
t.strictEqual( String( getDType( actual ) ), String( getDType( x ) ), 'returns expected value' );
167+
t.notEqual( getData( actual ), getData( x ), 'returns expected value' );
163168

164169
expected = [
165170
[ 8, 6, 4 ],
@@ -193,10 +198,10 @@ tape( 'the function returns a new ndarray where the order of elements of an inpu
193198
actual = toReverseDimension( x, 0 );
194199

195200
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
196-
t.strictEqual( actual.ndims, 3, 'returns expected value' );
197-
t.deepEqual( actual.shape, [ 2, 4, 3 ], 'returns expected value' );
198-
t.strictEqual( actual.dtype, x.dtype, 'returns expected value' );
199-
t.notEqual( actual.data, x.data, 'returns expected value' );
201+
t.strictEqual( ndims( actual ), 3, 'returns expected value' );
202+
t.deepEqual( getShape( actual ), [ 2, 4, 3 ], 'returns expected value' );
203+
t.strictEqual( String( getDType( actual ) ), String( getDType( x ) ), 'returns expected value' );
204+
t.notEqual( getData( actual ), getData( x ), 'returns expected value' );
200205

201206
expected = [
202207
[
@@ -218,10 +223,10 @@ tape( 'the function returns a new ndarray where the order of elements of an inpu
218223
actual = toReverseDimension( x, -3 );
219224

220225
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
221-
t.strictEqual( actual.ndims, 3, 'returns expected value' );
222-
t.deepEqual( actual.shape, [ 2, 4, 3 ], 'returns expected value' );
223-
t.strictEqual( actual.dtype, x.dtype, 'returns expected value' );
224-
t.notEqual( actual.data, x.data, 'returns expected value' );
226+
t.strictEqual( ndims( actual ), 3, 'returns expected value' );
227+
t.deepEqual( getShape( actual ), [ 2, 4, 3 ], 'returns expected value' );
228+
t.strictEqual( String( getDType( actual ) ), String( getDType( x ) ), 'returns expected value' );
229+
t.notEqual( getData( actual ), getData( x ), 'returns expected value' );
225230

226231
expected = [
227232
[
@@ -243,10 +248,10 @@ tape( 'the function returns a new ndarray where the order of elements of an inpu
243248
actual = toReverseDimension( x, 1 );
244249

245250
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
246-
t.strictEqual( actual.ndims, 3, 'returns expected value' );
247-
t.deepEqual( actual.shape, [ 2, 4, 3 ], 'returns expected value' );
248-
t.strictEqual( actual.dtype, x.dtype, 'returns expected value' );
249-
t.notEqual( actual.data, x.data, 'returns expected value' );
251+
t.strictEqual( ndims( actual ), 3, 'returns expected value' );
252+
t.deepEqual( getShape( actual ), [ 2, 4, 3 ], 'returns expected value' );
253+
t.strictEqual( String( getDType( actual ) ), String( getDType( x ) ), 'returns expected value' );
254+
t.notEqual( getData( actual ), getData( x ), 'returns expected value' );
250255

251256
expected = [
252257
[
@@ -268,10 +273,10 @@ tape( 'the function returns a new ndarray where the order of elements of an inpu
268273
actual = toReverseDimension( x, -2 );
269274

270275
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
271-
t.strictEqual( actual.ndims, 3, 'returns expected value' );
272-
t.deepEqual( actual.shape, [ 2, 4, 3 ], 'returns expected value' );
273-
t.strictEqual( actual.dtype, x.dtype, 'returns expected value' );
274-
t.notEqual( actual.data, x.data, 'returns expected value' );
276+
t.strictEqual( ndims( actual ), 3, 'returns expected value' );
277+
t.deepEqual( getShape( actual ), [ 2, 4, 3 ], 'returns expected value' );
278+
t.strictEqual( String( getDType( actual ) ), String( getDType( x ) ), 'returns expected value' );
279+
t.notEqual( getData( actual ), getData( x ), 'returns expected value' );
275280

276281
expected = [
277282
[
@@ -293,10 +298,10 @@ tape( 'the function returns a new ndarray where the order of elements of an inpu
293298
actual = toReverseDimension( x, 2 );
294299

295300
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
296-
t.strictEqual( actual.ndims, 3, 'returns expected value' );
297-
t.deepEqual( actual.shape, [ 2, 4, 3 ], 'returns expected value' );
298-
t.strictEqual( actual.dtype, x.dtype, 'returns expected value' );
299-
t.notEqual( actual.data, x.data, 'returns expected value' );
301+
t.strictEqual( ndims( actual ), 3, 'returns expected value' );
302+
t.deepEqual( getShape( actual ), [ 2, 4, 3 ], 'returns expected value' );
303+
t.strictEqual( String( getDType( actual ) ), String( getDType( x ) ), 'returns expected value' );
304+
t.notEqual( getData( actual ), getData( x ), 'returns expected value' );
300305

301306
expected = [
302307
[
@@ -318,10 +323,10 @@ tape( 'the function returns a new ndarray where the order of elements of an inpu
318323
actual = toReverseDimension( x, -1 );
319324

320325
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
321-
t.strictEqual( actual.ndims, 3, 'returns expected value' );
322-
t.deepEqual( actual.shape, [ 2, 4, 3 ], 'returns expected value' );
323-
t.strictEqual( actual.dtype, x.dtype, 'returns expected value' );
324-
t.notEqual( actual.data, x.data, 'returns expected value' );
326+
t.strictEqual( ndims( actual ), 3, 'returns expected value' );
327+
t.deepEqual( getShape( actual ), [ 2, 4, 3 ], 'returns expected value' );
328+
t.strictEqual( String( getDType( actual ) ), String( getDType( x ) ), 'returns expected value' );
329+
t.notEqual( getData( actual ), getData( x ), 'returns expected value' );
325330

326331
expected = [
327332
[

0 commit comments

Comments
 (0)