Skip to content

Commit e943036

Browse files
committed
refactor: use explicit utility for returning the rank of an array
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 7aa3592 commit e943036

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

  • lib/node_modules/@stdlib/blas/ext/join/lib

lib/node_modules/@stdlib/blas/ext/join/lib/main.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ var maybeBroadcastArray = require( '@stdlib/ndarray/base/maybe-broadcast-array'
2828
var nonCoreShape = require( '@stdlib/ndarray/base/complement-shape' );
2929
var getShape = require( '@stdlib/ndarray/shape' );
3030
var getOrder = require( '@stdlib/ndarray/order' );
31+
var ndims = require( '@stdlib/ndarray/base/ndims' );
3132
var format = require( '@stdlib/string/format' );
3233
var base = require( './base.js' );
3334

@@ -111,7 +112,7 @@ function join( x, options ) {
111112
// When not provided `dims`, the operation is performed across all dimensions and `s` must be a zero-dimensional ndarray; when `dims` is provided, we need to broadcast `s` to match the shape of the non-core dimensions...
112113
if ( hasOwnProp( opts, 'dims' ) ) {
113114
s = maybeBroadcastArray( s, nonCoreShape( getShape( x ), opts.dims ) ); // eslint-disable-line max-len
114-
} else if ( getShape( s ).length !== 0 ) {
115+
} else if ( ndims( s ) !== 0 ) {
115116
throw new TypeError( format( 'invalid option. `%s` option must be a zero-dimensional ndarray.', 'sep' ) );
116117
}
117118
} else {

0 commit comments

Comments
 (0)