refactor: apply suggestions from code review

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Author: headlessNode

lib/node_modules/@stdlib/blas/ext/base/dvander/lib/base.js

@@ -54,9 +54,9 @@ var dfill = require( '@stdlib/blas/ext/base/dfill' ).ndarray;
 * // out => <Float64Array>[ 1.0, 1.0, 1.0, 4.0, 2.0, 1.0, 9.0, 3.0, 1.0 ]
 */
 function dvander( mode, M, N, x, strideX, offsetX, out, strideOut1, strideOut2, offsetOut ) {
+	var isrm;
 	var do0;
 	var do1;
-	var rm;
 	var S0;
 	var S1;
 	var sx;
@@ -66,11 +66,10 @@ function dvander( mode, M, N, x, strideX, offsetX, out, strideOut1, strideOut2,
 	var i1;
 
 	// Note on variable naming convention: S#, do#, io, i# where # corresponds to the loop number, with `0` being the innermost loop...
-	rm = isRowMajor( [ strideOut1, strideOut2 ] );
+	isrm = isRowMajor( [ strideOut1, strideOut2 ] );
 	sx = strideX;
 
-	// For a Vandermonde matrix, each row `i` contains powers of `x[i]`:
-	if ( rm && mode > 0 ) {
+	if ( isrm && mode > 0 ) {
 		// Row-major, increasing: x^0, x^1, ..., x^(N-1)
 		S0 = N;
 		S1 = M;
@@ -88,7 +87,7 @@ function dvander( mode, M, N, x, strideX, offsetX, out, strideOut1, strideOut2,
 			ix += sx;
 			io += do1;
 		}
-	} else if ( rm ) {
+	} else if ( isrm ) {
 		// Row-major, decreasing: x^(N-1), x^(N-2), ..., x^0
 		S0 = N;
 		S1 = M;
@@ -114,7 +113,7 @@ function dvander( mode, M, N, x, strideX, offsetX, out, strideOut1, strideOut2,
 		do1 = strideOut2 - ( S0*strideOut1 );
 		io = offsetOut;
 		dfill( S0, 1.0, out, do0, io );
-		io += ( S0 * do0 ) + do1;
+		io += strideOut2;
 		for ( i1 = 1; i1 < S1; i1++ ) {
 			ix = offsetX;
 			for ( i0 = 0; i0 < S0; i0++ ) {
@@ -128,15 +127,14 @@ function dvander( mode, M, N, x, strideX, offsetX, out, strideOut1, strideOut2,
 		// Column-major, decreasing: column 0 contains x^(N-1), last column all ones
 		S0 = M;
 		S1 = N;
-		do0 = strideOut1;
-		dfill( S0, 1.0, out, do0, offsetOut + ( ( S1-1 ) * strideOut2 ) );
+		dfill( S0, 1.0, out, strideOut1, offsetOut + ( ( S1-1 ) * strideOut2 ) );
 		for ( i1 = S1 - 2; i1 >= 0; i1-- ) {
 			io = offsetOut + ( i1 * strideOut2 );
 			ix = offsetX;
 			for ( i0 = 0; i0 < S0; i0++ ) {
 				out[ io ] = out[ io + strideOut2 ] * x[ ix ];
 				ix += sx;
-				io += do0;
+				io += strideOut1;
 			}
 		}
 	}

lib/node_modules/@stdlib/blas/ext/base/dvander/src/main.c

@@ -108,9 +108,9 @@ void API_SUFFIX(stdlib_strided_dvander)( const CBLAS_LAYOUT order, const double
 */
 void API_SUFFIX(stdlib_strided_dvander_ndarray)( const double mode, const CBLAS_INT M, const CBLAS_INT N, const double *X, const CBLAS_INT strideX, const CBLAS_INT offsetX, double *Out, const CBLAS_INT strideOut1, const CBLAS_INT strideOut2, const CBLAS_INT offsetOut ) {
 	int64_t sa[ 2 ];
+	CBLAS_INT isrm;
 	CBLAS_INT do0;
 	CBLAS_INT do1;
-	CBLAS_INT rm;
 	CBLAS_INT S0;
 	CBLAS_INT S1;
 	CBLAS_INT sx;
@@ -140,13 +140,13 @@ void API_SUFFIX(stdlib_strided_dvander_ndarray)( const double mode, const CBLAS_
 	sa[ 0 ] = strideOut1;
 	sa[ 1 ] = strideOut2;
 	if ( stdlib_ndarray_is_row_major( 2, sa ) ) {
-		rm = 1;
+		isrm = 1;
 	} else {
-		rm = 0;
+		isrm = 0;
 	}
 	sx = strideX;
 
-	if ( rm && mode > 0 ) {
+	if ( isrm && mode > 0 ) {
 		// Row-major, increasing: x^0, x^1, ..., x^(N-1)
 		S0 = N;
 		S1 = M;
@@ -164,7 +164,7 @@ void API_SUFFIX(stdlib_strided_dvander_ndarray)( const double mode, const CBLAS_
 			ix += sx;
 			io += do1;
 		}
-	} else if ( rm ) {
+	} else if ( isrm ) {
 		// Row-major, decreasing: x^(N-1), x^(N-2), ..., x^0
 		S0 = N;
 		S1 = M;
@@ -190,7 +190,7 @@ void API_SUFFIX(stdlib_strided_dvander_ndarray)( const double mode, const CBLAS_
 		do1 = strideOut2 - ( S0 * strideOut1 );
 		io = offsetOut;
 		API_SUFFIX(stdlib_strided_dfill_ndarray)( S0, 1.0, Out, do0, io );
-		io += ( S0 * do0 ) + do1;
+		io += strideOut2;
 		for ( i1 = 1; i1 < S1; i1++ ) {
 			ix = offsetX;
 			for ( i0 = 0; i0 < S0; i0++ ) {
@@ -204,15 +204,14 @@ void API_SUFFIX(stdlib_strided_dvander_ndarray)( const double mode, const CBLAS_
 		// Column-major, decreasing: column 0 contains x^(N-1), last column all ones
 		S0 = M;
 		S1 = N;
-		do0 = strideOut1;
-		API_SUFFIX(stdlib_strided_dfill_ndarray)( S0, 1.0, Out, do0, offsetOut + ( ( S1-1 ) * strideOut2 ) );
+		API_SUFFIX(stdlib_strided_dfill_ndarray)( S0, 1.0, Out, strideOut1, offsetOut + ( ( S1-1 ) * strideOut2 ) );
 		for ( i1 = S1 - 2; i1 >= 0; i1-- ) {
 			io = offsetOut + ( i1 * strideOut2 );
 			ix = offsetX;
 			for ( i0 = 0; i0 < S0; i0++ ) {
 				Out[ io ] = Out[ io + strideOut2 ] * X[ ix ];
 				ix += sx;
-				io += do0;
+				io += strideOut1;
 			}
 		}
 	}