fix: apply suggestions from code review

Author: headlessNode

lib/node_modules/@stdlib/ndarray/base/reverse-dimensions/docs/repl.txt

@@ -9,9 +9,9 @@
         Input array.
 
     dims: ArrayLikeObject<integer>
-        Dimension indices along which to reverse elements. If less than zero,
-        the index is resolved relative to the last dimension, with the last
-        dimension corresponding to the value `-1`.
+        Dimension indices along which to reverse elements. If provided an
+        integer less than zero, the dimension index is resolved relative to the
+        last dimension, with the last dimension corresponding to the value `-1`.
 
     writable: boolean
         Boolean indicating whether a returned ndarray should be writable. This

lib/node_modules/@stdlib/ndarray/base/reverse-dimensions/docs/types/index.d.ts

@@ -40,7 +40,7 @@ import { ndarray } from '@stdlib/types/ndarray';
 * var y = reverseDimensions( x, [ 0, 1 ], false );
 * // returns <ndarray>[ [ 6.0, 5.0 ], [ 4.0, 3.0 ], [ 2.0, 1.0 ] ]
 */
-declare function reverseDimensions<T extends ndarray>( x: T, dims: Collection<number>, writable: boolean ): T;
+declare function reverseDimensions<T extends ndarray = ndarray>( x: T, dims: Collection<number>, writable: boolean ): T;
 
 
 // EXPORTS //

lib/node_modules/@stdlib/ndarray/base/reverse-dimensions/lib/main.js

@@ -25,7 +25,7 @@ var Slice = require( '@stdlib/slice/ctor' );
 var slice = require( '@stdlib/ndarray/base/slice' );
 var nulls = require( '@stdlib/array/base/nulls' );
 var ndims = require( '@stdlib/ndarray/base/ndims' );
-var toNormalizedIndices = require( '@stdlib/ndarray/base/to-unique-normalized-indices' );
+var toUniqueNormalizedIndices = require( '@stdlib/ndarray/base/to-unique-normalized-indices' );
 var format = require( '@stdlib/string/format' );
 
 
@@ -39,6 +39,7 @@ var format = require( '@stdlib/string/format' );
 * @param {boolean} writable - boolean indicating whether a returned array should be writable
 * @throws {TypeError} first argument must be an ndarray having one or more dimensions
 * @throws {RangeError} dimension index exceeds the number of dimensions
+* @throws {Error} must provide unique dimension indices
 * @returns {ndarray} ndarray view
 *
 * @example
@@ -64,10 +65,13 @@ function reverseDimensions( x, dims, writable ) {
 		throw new TypeError( format( 'invalid argument. First argument must be an ndarray having one or more dimensions. Number of dimensions: %d.', N ) );
 	}
 	// Normalize the dimension indices...
-	d = toNormalizedIndices( dims, N-1 );
+	d = toUniqueNormalizedIndices( dims, N-1 );
 	if ( d === null ) {
 		throw new RangeError( format( 'invalid argument. Dimension index exceeds the number of dimensions. Number of dimensions: %d. Value: `%s`.', N, dims ) );
 	}
+	if ( d.length !== dims.length ) {
+		throw new Error( format( 'invalid argument. Must provide unique dimension indices. Value: `[%s]`.', dims ) );
+	}
 	// Define a list of MultiSlice constructor arguments:
 	args = nulls( N );
 	for ( i = 0; i < d.length; i++ ) {

lib/node_modules/@stdlib/ndarray/base/reverse-dimensions/test/test.js

@@ -87,6 +87,33 @@ tape( 'the function throws an error if the dimension index exceeds the number of
 	}
 });
 
+tape( 'the function throws an error if provided duplicate dimension indices', function test( t ) {
+	var values;
+	var x;
+	var i;
+
+	x = zeros( [ 2, 2, 2 ] );
+
+	values = [
+		[ 0, 0 ],
+		[ 1, 1 ],
+		[ 2, 2 ],
+		[ 0, -3 ],
+		[ -2, 1 ],
+		[ -1, 2 ]
+	];
+	for ( i = 0; i < values.length; i++ ) {
+		t.throws( badValue( values[ i ] ), Error, 'throws an error when provided dimension indices ['+values[ i ]+']' );
+	}
+	t.end();
+
+	function badValue( dims ) {
+		return function badValue() {
+			reverseDimensions( x, dims, false );
+		};
+	}
+});
+
 tape( 'the function returns a view of a provided input array (ndims=1)', function test( t ) {
 	var expected;
 	var actual;