chore: fix JavaScript lint errors (issue #10000)#10004
Closed
24archit wants to merge 1 commit intostdlib-js:developfrom
Closed
chore: fix JavaScript lint errors (issue #10000)#1000424archit wants to merge 1 commit intostdlib-js:developfrom
24archit wants to merge 1 commit intostdlib-js:developfrom
Conversation
stdlib-bot
added
Good First PR
kgryte
requested changes
Jan 31, 2026
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
All of the spacing changes in this PR need to be reverted. Otherwise, we will not be able to accept this PR.
kgryte
added
difficulty: 1
stdlib-bot
added
the
Potential Duplicate
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
24archit
force-pushed
the
chore/fix-lint-makie-install-addons
branch
from
2360c34 to
80ebdd9
Compare
Author
|
Hi @kgryte , I have reverted the unintended spacing changes. The PR now contains only the necessary fix for the no-undef error (importing process) and adheres to the project's spacing guidelines. I believe this addresses your feedback. Thanks! |
Member
|
Ref: #10307 |
kgryte
added
autoclose: Already Resolved
Contributor
|
Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit. Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10000.
Description
This pull request:
no-undeflinting error inlib/node_modules/@stdlib/_tools/makie/plugins/makie-install-node-addons/lib/main.jsby defining theprocvariable.requirecalls forprocessandchild_processto satisfystdlib/require-spacesrules.make lintand the relevant test suite.Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
N.A
@stdlib-js/reviewers