feat: add `math/base/special/factorialf` by DivyanshuVortex · Pull Request #10032 · stdlib-js/stdlib

DivyanshuVortex · 2026-02-01T09:48:57Z

Description

feat: add math/base/special/factorialf

Related Issues

#649

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

DivyanshuVortex · 2026-02-01T09:50:40Z

/stdlib update-copyright-years

stdlib-bot · 2026-02-01T09:51:42Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/factorialf	$\color{green}223/223$ $\color{green}+0.00%$	$\color{green}13/13$ $\color{green}+0.00%$	$\color{green}2/2$ $\color{green}+0.00%$	$\color{green}223/223$ $\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

hrshya · 2026-02-02T17:55:40Z

+	return (double)now.tv_sec + (double)now.tv_usec/1.0e6;
+}
+
+/**


Can you update this to use random_uniform instead? You can refer to tanf for this

hrshya · 2026-02-02T17:57:28Z

+*/
+static double benchmark( void ) {
+	double elapsed;
+	int32_t x;


Variables x and y should be float here.

hrshya · 2026-02-02T17:57:52Z

+
+	t = tic();
+	for ( i = 0; i < ITERATIONS; i++ ) {
+		x = (int32_t)floor( 33.0 * rand_double() );


should be outside the loop. you can refer to tanf

hrshya · 2026-02-02T17:58:53Z

+#include <time.h>
+#include <sys/time.h>
+
+#define NAME "factorial"


Suggested change

#define NAME "factorial"

#define NAME "factorialf"

hrshya · 2026-02-02T18:05:53Z

+
+// MAIN //
+
+bench( pkg+'::integers', function benchmark( b ) {


we have moved away from string concatenation to string interpolation. The formatting change is described in #8647. Applies here and below.

hrshya · 2026-02-02T18:06:58Z

+
+var resolve = require( 'path' ).resolve;
+var bench = require( '@stdlib/bench' );
+var isnanf = require( '@stdlib/math/base/assert/is-nan' );


Suggested change

var isnanf = require( '@stdlib/math/base/assert/is-nan' );

var isnanf = require( '@stdlib/math/base/assert/is-nanf' );

hrshya · 2026-02-02T18:14:47Z

+			continue;
+		}
+		v = factorialf( x[ i ] );
+		if ( v === float64ToFloat32( expected[ i ] ) ) {


Can you refactor this to use @stdlib/number/float32/base/assert/is-almost-same-value instead?

Same comment applies below and for test.native.js

hrshya · 2026-02-02T18:18:10Z

+
+<section class="related">
+
+* * *


You can remove this section as it is auto generated.

See also section.

hrshya · 2026-02-02T18:19:25Z

+
+<!-- <related-links> -->
+
+[@stdlib/math/base/special/factorial]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/math/base/special/factorial


related links section is also auto-generated

nirmaljb · 2026-03-03T16:02:24Z

+		}
+		return STDLIB_CONSTANT_FLOAT32_PINF;
+	}
+	return (float)stdlib_base_gamma( (double)x + 1.0 );


I believe you should wait for gammaf to be merged

nirmaljb · 2026-03-06T10:07:25Z

+var gamma = require( '@stdlib/math/base/special/gamma' );
+var PINF = require( '@stdlib/constants/float32/pinf' );
+var FLOAT32_MAX_NTH_FACTORIAL = require( '@stdlib/constants/float32/max-nth-factorial' );
+var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );


Shorten the variable to f32 instead, other packages follow this pattern.

DivyanshuVortex · 2026-03-06T13:18:27Z

/stdlib merge

feat(factorialf):implementation for math/base/special/factorialf

a4bc58d

stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Feb 1, 2026

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 1, 2026

chore: update copyright years

838ed64

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 1, 2026

DivyanshuVortex added 2 commits February 1, 2026 10:06

chores

b16219c

chores

215e1cd

DivyanshuVortex marked this pull request as draft February 1, 2026 10:14

stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 1, 2026

DivyanshuVortex added 3 commits February 1, 2026 14:16

chores

7534bf4

fix:lint

faa5fee

lint_fix

49608f5

DivyanshuVortex marked this pull request as ready for review February 1, 2026 15:01

stdlib-bot added the Needs Review A pull request which needs code review. label Feb 1, 2026

hrshya suggested changes Feb 2, 2026

View reviewed changes

Fix:Format and other chores

289d989

DivyanshuVortex requested a review from hrshya February 2, 2026 19:22

chores

d62ea4d

stdlib-bot added the Needs Review A pull request which needs code review. label Feb 2, 2026

DivyanshuVortex added 3 commits February 3, 2026 04:19

chores

64067c2

remove unuse variables

5dae202

fix

8e4a109

nirmaljb reviewed Mar 3, 2026

View reviewed changes

nirmaljb reviewed Mar 6, 2026

View reviewed changes

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 6, 2026

Merge remote-tracking branch 'upstream/develop' into factorialf

24bacc7

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 6, 2026

chores

f67f8c3

DivyanshuVortex mentioned this pull request Mar 26, 2026

[RFC]: Array API Compliance Layer for stdlib ndarray stdlib-js/google-summer-of-code#208

Open

7 tasks


		// MAIN //

		bench( pkg+'::integers', function benchmark( b ) {

	var isnanf = require( '@stdlib/math/base/assert/is-nan' );
	var isnanf = require( '@stdlib/math/base/assert/is-nanf' );


		<!-- <related-links> -->

		[@stdlib/math/base/special/factorial]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/math/base/special/factorial


		<section class="related">

		* * *

Uh oh!

Conversation

DivyanshuVortex commented Feb 1, 2026

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

DivyanshuVortex commented Feb 1, 2026

Uh oh!

stdlib-bot commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nirmaljb Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DivyanshuVortex commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stdlib-bot commented Feb 1, 2026 •

edited

Loading

nirmaljb Mar 3, 2026 •

edited

Loading