Skip to content

bench: refactor to use string interpolation in lapack/base/crot#10094

Merged
Planeshifter merged 1 commit intostdlib-js:developfrom
prajjwalbajpai:ref_bench_crot
Feb 14, 2026
Merged

bench: refactor to use string interpolation in lapack/base/crot#10094
Planeshifter merged 1 commit intostdlib-js:developfrom
prajjwalbajpai:ref_bench_crot

Conversation

@prajjwalbajpai
Copy link
Copy Markdown
Contributor

@prajjwalbajpai prajjwalbajpai commented Feb 5, 2026

Progresses #8647.

Description

What is the purpose of this pull request?

This pull request:

  • Updates benchmark files for lapack/base/crot to use string interpolation in JavaScript benchmarks for the benchmark name.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Feb 5, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
lapack/base/crot $\color{green}299/299$
$\color{green}+100.00%$
$\color{green}12/12$
$\color{green}+100.00%$
$\color{green}2/2$
$\color{green}+100.00%$
$\color{green}299/299$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 14, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

PR Commit Message

bench: refactor to use string interpolation in `lapack/base/crot`

PR-URL: https://github.com/stdlib-js/stdlib/pull/10094
Ref: https://github.com/stdlib-js/stdlib/issues/8647

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

⚠️ Action Required: This PR references tracking issues. Please update the PR description to replace any "Closes", "Fixes", or "Resolves" keywords with "Ref" when referencing these issues.

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 14, 2026
@Planeshifter Planeshifter merged commit 143c2b8 into stdlib-js:develop Feb 14, 2026
93 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Feb 14, 2026
@prajjwalbajpai prajjwalbajpai deleted the ref_bench_crot branch February 16, 2026 09:13
DivitJain26 pushed a commit to DivitJain26/stdlib-divit that referenced this pull request Feb 25, 2026
PR-URL: stdlib-js#10094
Ref: stdlib-js#8647

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants