-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add c implementation of math/base/special/kernel-betainc
#10279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nirmaljb
wants to merge
23
commits into
stdlib-js:develop
Choose a base branch
from
nirmaljb:feat/kernel-betainc
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
8f7a4c1
feat: add c implementation of kernal betainc
nirmaljb 725981a
chore: update copyright years
stdlib-bot 4d067da
fix: removed trailing whitespace
nirmaljb 8b09879
fix: removed unnecessary assigned variable
nirmaljb c9ec37f
test: added fixture
nirmaljb c398869
style: remove trailing space after ;
nirmaljb d0f93fa
test: added test, test.native, runner
nirmaljb a00b9f3
Apply suggestion from @gunjjoshi
nirmaljb 2e13ea5
fix: added format for bench interpolation
nirmaljb 05814a9
fix: added powm1 instead of pow() - 1
nirmaljb 45bb984
test: added test for ibeta
nirmaljb 5281ab1
test: remove some the output.json and it's fixtures, because it range…
nirmaljb 49227ca
test: removed redundant test cases
nirmaljb de9851e
test: commented out assign method test
nirmaljb 4fc832d
test: changed to isAlmostEqual
nirmaljb 386b749
refactor: made some changes to the implementation
nirmaljb 17edfe9
test: moved from isAlmostEqual to isAlmostSameValue
nirmaljb 8165e41
fix: address changes suggestion
nirmaljb e6cb1fe
fix: update the namespace to correct convention
nirmaljb 21d3954
test: revert back the date to original file
nirmaljb e5fdc8d
docs: use correct example and spacing
nirmaljb 167fc92
bench: refactor C benchmark and update main.c formating
Neerajpathak07 8446c6a
chore: update macro name
Neerajpathak07 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 changes: 68 additions & 0 deletions
68
lib/node_modules/@stdlib/math/base/special/kernel-betainc/benchmark/benchmark.native.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| /** | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2026 The Stdlib Authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| // MODULES // | ||
|
|
||
| var resolve = require( 'path' ).resolve; | ||
| var bench = require( '@stdlib/bench' ); | ||
| var uniform = require( '@stdlib/random/array/uniform' ); | ||
| var isnan = require( '@stdlib/math/base/assert/is-nan' ); | ||
| var tryRequire = require( '@stdlib/utils/try-require' ); | ||
| var format = require( '@stdlib/string/format' ); | ||
| var EPS = require( '@stdlib/constants/float64/eps' ); | ||
| var pkg = require( './../package.json' ).name; | ||
|
|
||
|
|
||
| // VARIABLES // | ||
|
|
||
| var kernelBetainc = tryRequire( resolve( __dirname, './../lib/native.js' ) ); | ||
| var opts = { | ||
| 'skip': ( kernelBetainc instanceof Error ) | ||
| }; | ||
|
|
||
|
|
||
| // MAIN // | ||
|
|
||
| bench( format( '%s::regularized,upper', pkg ), opts, function benchmark( assert ) { | ||
| var out; | ||
| var x; | ||
| var a; | ||
| var b; | ||
| var i; | ||
|
|
||
| x = uniform( 100, 0.0, 1.0 ); | ||
| a = uniform( 100, EPS, 1000.0 ); | ||
| b = uniform( 100, EPS, 1000.0 ); | ||
|
|
||
| out = [ 0.0, 0.0 ]; | ||
| assert.tic(); | ||
| for ( i = 0; i < assert.iterations; i++ ) { | ||
| out = kernelBetainc( x[ i%x.length ], a[ i%a.length ], b[ i%b.length ], true, true ); | ||
| if ( isnan( out[ 0 ] ) || isnan( out[ 1 ] ) ) { | ||
| assert.fail( 'should not return NaN' ); | ||
| } | ||
| } | ||
| assert.toc(); | ||
| if ( isnan( out[ 0 ] ) || isnan( out[ 1 ] ) ) { | ||
| assert.fail( 'should not return NaN' ); | ||
| } | ||
| assert.pass( 'benchmark finished' ); | ||
| assert.end(); | ||
| }); | ||
146 changes: 146 additions & 0 deletions
146
lib/node_modules/@stdlib/math/base/special/kernel-betainc/benchmark/c/native/Makefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,146 @@ | ||
| #/ | ||
| # @license Apache-2.0 | ||
| # | ||
| # Copyright (c) 2026 The Stdlib Authors. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| #/ | ||
|
|
||
| # VARIABLES # | ||
|
|
||
| ifndef VERBOSE | ||
| QUIET := @ | ||
| else | ||
| QUIET := | ||
| endif | ||
|
|
||
| # Determine the OS ([1][1], [2][2]). | ||
| # | ||
| # [1]: https://en.wikipedia.org/wiki/Uname#Examples | ||
| # [2]: http://stackoverflow.com/a/27776822/2225624 | ||
| OS ?= $(shell uname) | ||
| ifneq (, $(findstring MINGW,$(OS))) | ||
| OS := WINNT | ||
| else | ||
| ifneq (, $(findstring MSYS,$(OS))) | ||
| OS := WINNT | ||
| else | ||
| ifneq (, $(findstring CYGWIN,$(OS))) | ||
| OS := WINNT | ||
| else | ||
| ifneq (, $(findstring Windows_NT,$(OS))) | ||
| OS := WINNT | ||
| endif | ||
| endif | ||
| endif | ||
| endif | ||
|
|
||
| # Define the program used for compiling C source files: | ||
| ifdef C_COMPILER | ||
| CC := $(C_COMPILER) | ||
| else | ||
| CC := gcc | ||
| endif | ||
|
|
||
| # Define the command-line options when compiling C files: | ||
| CFLAGS ?= \ | ||
| -std=c99 \ | ||
| -O3 \ | ||
| -Wall \ | ||
| -pedantic | ||
|
|
||
| # Determine whether to generate position independent code ([1][1], [2][2]). | ||
| # | ||
| # [1]: https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#Code-Gen-Options | ||
| # [2]: http://stackoverflow.com/questions/5311515/gcc-fpic-option | ||
| ifeq ($(OS), WINNT) | ||
| fPIC ?= | ||
| else | ||
| fPIC ?= -fPIC | ||
| endif | ||
|
|
||
| # List of includes (e.g., `-I /foo/bar -I /beep/boop/include`): | ||
| INCLUDE ?= | ||
|
|
||
| # List of source files: | ||
| SOURCE_FILES ?= | ||
|
|
||
| # List of libraries (e.g., `-lopenblas -lpthread`): | ||
| LIBRARIES ?= | ||
|
|
||
| # List of library paths (e.g., `-L /foo/bar -L /beep/boop`): | ||
| LIBPATH ?= | ||
|
|
||
| # List of C targets: | ||
| c_targets := benchmark.out | ||
|
|
||
|
|
||
| # RULES # | ||
|
|
||
| #/ | ||
| # Compiles source files. | ||
| # | ||
| # @param {string} [C_COMPILER] - C compiler (e.g., `gcc`) | ||
| # @param {string} [CFLAGS] - C compiler options | ||
| # @param {(string|void)} [fPIC] - compiler flag determining whether to generate position independent code (e.g., `-fPIC`) | ||
| # @param {string} [INCLUDE] - list of includes (e.g., `-I /foo/bar -I /beep/boop/include`) | ||
| # @param {string} [SOURCE_FILES] - list of source files | ||
| # @param {string} [LIBPATH] - list of library paths (e.g., `-L /foo/bar -L /beep/boop`) | ||
| # @param {string} [LIBRARIES] - list of libraries (e.g., `-lopenblas -lpthread`) | ||
| # | ||
| # @example | ||
| # make | ||
| # | ||
| # @example | ||
| # make all | ||
| #/ | ||
| all: $(c_targets) | ||
|
|
||
| .PHONY: all | ||
|
|
||
| #/ | ||
| # Compiles C source files. | ||
| # | ||
| # @private | ||
| # @param {string} CC - C compiler (e.g., `gcc`) | ||
| # @param {string} CFLAGS - C compiler options | ||
| # @param {(string|void)} fPIC - compiler flag determining whether to generate position independent code (e.g., `-fPIC`) | ||
| # @param {string} INCLUDE - list of includes (e.g., `-I /foo/bar`) | ||
| # @param {string} SOURCE_FILES - list of source files | ||
| # @param {string} LIBPATH - list of library paths (e.g., `-L /foo/bar`) | ||
| # @param {string} LIBRARIES - list of libraries (e.g., `-lopenblas`) | ||
| #/ | ||
| $(c_targets): %.out: %.c | ||
| $(QUIET) $(CC) $(CFLAGS) $(fPIC) $(INCLUDE) -o $@ $(SOURCE_FILES) $< $(LIBPATH) -lm $(LIBRARIES) | ||
|
|
||
| #/ | ||
| # Runs compiled benchmarks. | ||
| # | ||
| # @example | ||
| # make run | ||
| #/ | ||
| run: $(c_targets) | ||
| $(QUIET) ./$< | ||
|
|
||
| .PHONY: run | ||
|
|
||
| #/ | ||
| # Removes generated files. | ||
| # | ||
| # @example | ||
| # make clean | ||
| #/ | ||
| clean: | ||
| $(QUIET) -rm -f *.o *.out | ||
|
|
||
| .PHONY: clean |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.