Skip to content

test: add tests for Axis constructor and properties#10414

Open
Sachinn-64 wants to merge 13 commits intostdlib-js:refactor/plotfrom
Sachinn-64:test-plot-vega-axis
Open

test: add tests for Axis constructor and properties#10414
Sachinn-64 wants to merge 13 commits intostdlib-js:refactor/plotfrom
Sachinn-64:test-plot-vega-axis

Conversation

@Sachinn-64
Copy link
Copy Markdown
Member

@Sachinn-64 Sachinn-64 commented Feb 21, 2026

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • test: add tests for Axis constructor and properties

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@Sachinn-64 Sachinn-64 marked this pull request as draft February 21, 2026 22:03
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Feb 21, 2026
gururaj1512
gururaj1512 reviewed Feb 25, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.aria.js Outdated
gururaj1512
gururaj1512 reviewed Feb 25, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.band_position.js Outdated
@Sachinn-64 Sachinn-64 marked this pull request as ready for review March 7, 2026 06:07
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 7, 2026
@Sachinn-64 Sachinn-64 force-pushed the test-plot-vega-axis branch from 97db7a7 to 0d50848 Compare March 7, 2026 06:23
gururaj1512
gururaj1512 requested changes Mar 10, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.format_type.js
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.format_type.js
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.label_baseline.js
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.tick_band.js
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.title_align.js
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.label_limit.js
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.label_overlap.js
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.title_anchor.js
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.title_anchor.js Outdated
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.tick_count.js
gururaj1512
gururaj1512 requested changes Mar 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@gururaj1512 gururaj1512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM beside few changes

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Mar 22, 2026

@Sachinn-64 Would you also mind updating this PR to incorporate similar changes as made in your PR adding tests to the Padding constructor? Cheers!

@kgryte kgryte added Tests Pull requests specifically adding tests. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 22, 2026
@github-actions github-actions Bot mentioned this pull request Mar 22, 2026
Closed
Sachinn-64 and others added 8 commits March 28, 2026 00:05
@Sachinn-64
test: add tests for Axis constructor and properties
b77dc00
@Sachinn-64 @gururaj1512
Update lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.aria.js
60c07d5 
Co-authored-by: Gururaj Gurram <143020143+gururaj1512@users.noreply.github.com>
Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>
@Sachinn-64 @gururaj1512
Update lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.band_po…
37c64cb 
…sition.js

Co-authored-by: Gururaj Gurram <143020143+gururaj1512@users.noreply.github.com>
Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>
@Sachinn-64
update: revert changes
83e8bf9
@Sachinn-64
Fix formatting in axis example
1a4db27 
Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>
@Sachinn-64
update: revert changes
fe9183a
@Sachinn-64
chore: suggested changes
50ae1d6
@Sachinn-64
chore: suggested changes
eed4ff0
@Sachinn-64 Sachinn-64 force-pushed the test-plot-vega-axis branch from 0d50848 to eed4ff0 Compare March 27, 2026 20:29
@Sachinn-64 Sachinn-64 requested a review from kgryte March 27, 2026 20:33
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 27, 2026
kgryte
kgryte reviewed May 3, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.aria.js
@kgryte
style: address lint error
a0fe34f 
Signed-off-by: Athan <kgryte@gmail.com>
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented May 3, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
plot/vega/axis/ctor $\color{green}13051/13051$
$\color{green}+0.00%$ 		$\color{red}773/775$
$\color{green}+0.00%$ 		$\color{green}159/159$
$\color{green}+0.00%$ 		$\color{green}13051/13051$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@kgryte
test: fix grammar in descriptions
73640cc 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed May 4, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.aria.js Outdated
kgryte
kgryte reviewed May 4, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.description.js Outdated
kgryte
kgryte reviewed May 4, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.domain.js Outdated
kgryte
kgryte reviewed May 4, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.domain_cap.js Outdated
kgryte
kgryte reviewed May 4, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.domain_cap.js
kgryte
kgryte reviewed May 4, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.domain.js
kgryte
kgryte reviewed May 4, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.description.js
kgryte
kgryte reviewed May 4, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.band_position.js
kgryte
kgryte reviewed May 4, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.domain_color.js Outdated
kgryte
kgryte reviewed May 4, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.domain_color.js
@kgryte
Apply suggestions from code review
f8eeb15 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte requested changes May 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sachinn-64 I made initial changes, but they essentially apply to all your test files in this PR.

@kgryte kgryte added difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. review: 3 and removed Needs Review A pull request which needs code review. labels May 4, 2026
kgryte and others added 2 commits May 4, 2026 20:30
@kgryte
Merge branch 'refactor/plot' into test-plot-vega-axis
c4447dd
@Sachinn-64
chore: suggested changes
0c054f9 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte requested changes

@gururaj1512 gururaj1512 gururaj1512 requested changes

Assignees

No one assigned

Labels

difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Needs Changes Pull request which needs changes before being merged. review: 3 Tests Pull requests specifically adding tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Sachinn-64 @kgryte @stdlib-bot @gururaj1512