-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
test: add tests for Axis constructor and properties #10414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sachinn-64
wants to merge
13
commits into
stdlib-js:refactor/plot
Choose a base branch
from
Sachinn-64:test-plot-vega-axis
base: refactor/plot
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b77dc00
test: add tests for Axis constructor and properties
Sachinn-64 60c07d5
Update lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.aria.js
Sachinn-64 37c64cb
Update lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.band_po…
Sachinn-64 83e8bf9
update: revert changes
Sachinn-64 1a4db27
Fix formatting in axis example
Sachinn-64 fe9183a
update: revert changes
Sachinn-64 50ae1d6
chore: suggested changes
Sachinn-64 eed4ff0
chore: suggested changes
Sachinn-64 a0fe34f
style: address lint error
kgryte 73640cc
test: fix grammar in descriptions
kgryte f8eeb15
Apply suggestions from code review
kgryte c4447dd
Merge branch 'refactor/plot' into test-plot-vega-axis
kgryte 0c054f9
chore: suggested changes
Sachinn-64 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
151 changes: 151 additions & 0 deletions
151
lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.aria.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,151 @@ | ||
| /** | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2026 The Stdlib Authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| // MODULES // | ||
|
|
||
| var tape = require( 'tape' ); | ||
| var hasOwnProp = require( '@stdlib/assert/has-own-property' ); | ||
| var hasProp = require( '@stdlib/assert/has-property' ); | ||
| var isBoolean = require( '@stdlib/assert/is-boolean' ).isPrimitive; | ||
| var Axis = require( './../lib' ); | ||
|
|
||
|
|
||
| // TESTS // | ||
|
|
||
| tape( 'main export is a function', function test( t ) { | ||
| t.ok( true, __filename ); | ||
| t.strictEqual( typeof Axis, 'function', 'main export is a function' ); | ||
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the constructor returns an instance which has an `aria` property', function test( t ) { | ||
| var v; | ||
|
|
||
| v = new Axis({ | ||
| 'scale': 'xScale', | ||
| 'orient': 'bottom' | ||
| }); | ||
| t.strictEqual( hasOwnProp( v, 'aria' ), false, 'returns expected value' ); | ||
| t.strictEqual( hasProp( v, 'aria' ), true, 'returns expected value' ); | ||
| t.strictEqual( isBoolean( v.aria ), true, 'returns expected value' ); | ||
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the constructor returns an instance having an `aria` property which throws an error if set to a non-boolean value', function test( t ) { | ||
| var values; | ||
| var i; | ||
|
|
||
| values = [ | ||
| '5', | ||
| 5, | ||
| NaN, | ||
| null, | ||
| void 0, | ||
| [], | ||
| {}, | ||
| function noop() {} | ||
| ]; | ||
| for ( i = 0; i < values.length; i++ ) { | ||
| t.throws( badValue( values[ i ] ), TypeError, 'throws an error when provided ' + values[ i ] ); | ||
| } | ||
| t.end(); | ||
|
|
||
| function badValue( value ) { | ||
| return function badValue() { | ||
| var axis = new Axis({ | ||
| 'scale': 'xScale', | ||
| 'orient': 'bottom' | ||
| }); | ||
| axis.aria = value; | ||
| }; | ||
| } | ||
| }); | ||
|
|
||
| tape( 'the constructor returns an instance having an `aria` property', function test( t ) { | ||
| var axis; | ||
|
|
||
| axis = new Axis({ | ||
| 'scale': 'xScale', | ||
| 'orient': 'bottom' | ||
| }); | ||
| t.strictEqual( axis.aria, true, 'returns expected value' ); | ||
|
|
||
| axis = new Axis({ | ||
| 'scale': 'xScale', | ||
| 'orient': 'bottom', | ||
| 'aria': false | ||
| }); | ||
| t.strictEqual( axis.aria, false, 'returns expected value' ); | ||
|
|
||
| axis = new Axis({ | ||
| 'scale': 'xScale', | ||
| 'orient': 'bottom', | ||
| 'aria': true | ||
| }); | ||
| t.strictEqual( axis.aria, true, 'returns expected value' ); | ||
|
|
||
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the constructor returns an instance having an `aria` property which can be set to a boolean', function test( t ) { | ||
| var axis; | ||
|
|
||
| axis = new Axis({ | ||
| 'scale': 'xScale', | ||
| 'orient': 'bottom' | ||
| }); | ||
|
|
||
| axis.aria = true; | ||
| t.strictEqual( axis.aria, true, 'returns expected value' ); | ||
|
|
||
| axis.aria = false; | ||
| t.strictEqual( axis.aria, false, 'returns expected value' ); | ||
|
|
||
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the constructor returns an instance which emits an event when the `aria` property is set to a new value', function test( t ) { | ||
| var count; | ||
| var axis; | ||
|
|
||
| axis = new Axis({ | ||
| 'scale': 'xScale', | ||
| 'orient': 'bottom' | ||
| }); | ||
| count = 0; | ||
|
|
||
| axis.on( 'change', onChange ); | ||
|
|
||
| axis.aria = false; | ||
| t.strictEqual( count, 1, 'returns expected value' ); | ||
|
|
||
| axis.aria = true; | ||
| t.strictEqual( count, 2, 'returns expected value' ); | ||
|
|
||
| // Setting to the same value should not emit an event: | ||
| axis.aria = true; | ||
| t.strictEqual( count, 2, 'returns expected value' ); | ||
|
|
||
| t.end(); | ||
|
|
||
| function onChange() { | ||
| count += 1; | ||
| } | ||
| }); | ||
154 changes: 154 additions & 0 deletions
154
lib/node_modules/@stdlib/plot/vega/axis/ctor/test/test.band_position.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,154 @@ | ||
| /** | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2026 The Stdlib Authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| // MODULES // | ||
|
|
||
| var tape = require( 'tape' ); | ||
| var hasOwnProp = require( '@stdlib/assert/has-own-property' ); | ||
| var isUndefined = require( '@stdlib/assert/is-undefined' ); | ||
| var hasProp = require( '@stdlib/assert/has-property' ); | ||
| var isNumber = require( '@stdlib/assert/is-number' ).isPrimitive; | ||
| var Axis = require( './../lib' ); | ||
|
|
||
|
|
||
| // TESTS // | ||
|
kgryte marked this conversation as resolved.
|
||
|
|
||
| tape( 'main export is a function', function test( t ) { | ||
| t.ok( true, __filename ); | ||
| t.strictEqual( typeof Axis, 'function', 'main export is a function' ); | ||
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the constructor returns an instance which has a `bandPosition` property', function test( t ) { | ||
| var v; | ||
|
|
||
| v = new Axis({ | ||
| 'scale': 'xScale', | ||
| 'orient': 'bottom' | ||
| }); | ||
| t.strictEqual( hasOwnProp( v, 'bandPosition' ), false, 'returns expected value' ); | ||
| t.strictEqual( hasProp( v, 'bandPosition' ), true, 'returns expected value' ); | ||
| t.strictEqual( isUndefined( v.bandPosition ), true, 'returns expected value' ); | ||
|
|
||
| v = new Axis({ | ||
| 'scale': 'xScale', | ||
| 'orient': 'bottom', | ||
| 'bandPosition': 0.5 | ||
| }); | ||
| t.strictEqual( isNumber( v.bandPosition ), true, 'returns expected value' ); | ||
|
|
||
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the constructor returns an instance having a `bandPosition` property which throws an error if set to an invalid value', function test( t ) { | ||
| var values; | ||
| var i; | ||
|
|
||
| values = [ | ||
| 'beep', | ||
| -0.1, | ||
| 1.1, | ||
| NaN, | ||
| {}, | ||
| function noop() {} | ||
| ]; | ||
| for ( i = 0; i < values.length; i++ ) { | ||
| t.throws( badValue( values[ i ] ), TypeError, 'throws an error when provided ' + values[ i ] ); | ||
| } | ||
| t.end(); | ||
|
|
||
| function badValue( value ) { | ||
| return function badValue() { | ||
| var axis = new Axis({ | ||
| 'scale': 'xScale', | ||
| 'orient': 'bottom' | ||
| }); | ||
| axis.bandPosition = value; | ||
| }; | ||
| } | ||
| }); | ||
|
|
||
| tape( 'the constructor returns an instance having a `bandPosition` property', function test( t ) { | ||
| var axis; | ||
|
|
||
| axis = new Axis({ | ||
| 'scale': 'xScale', | ||
| 'orient': 'bottom' | ||
| }); | ||
| t.strictEqual( isUndefined( axis.bandPosition ), true, 'returns expected value' ); | ||
|
|
||
| axis = new Axis({ | ||
| 'scale': 'xScale', | ||
| 'orient': 'bottom', | ||
| 'bandPosition': 0.5 | ||
| }); | ||
| t.strictEqual( axis.bandPosition, 0.5, 'returns expected value' ); | ||
|
|
||
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the constructor returns an instance having a `bandPosition` property which can be set to a valid value', function test( t ) { | ||
| var axis; | ||
|
|
||
| axis = new Axis({ | ||
| 'scale': 'xScale', | ||
| 'orient': 'bottom' | ||
| }); | ||
|
|
||
| axis.bandPosition = 0.5; | ||
| t.strictEqual( axis.bandPosition, 0.5, 'returns expected value' ); | ||
|
|
||
| axis.bandPosition = 0; | ||
| t.strictEqual( axis.bandPosition, 0, 'returns expected value' ); | ||
|
|
||
| axis.bandPosition = 1; | ||
| t.strictEqual( axis.bandPosition, 1, 'returns expected value' ); | ||
|
|
||
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the constructor returns an instance which emits an event when the `bandPosition` property is set to a new value', function test( t ) { | ||
| var axis; | ||
| var count; | ||
|
|
||
| axis = new Axis({ | ||
| 'scale': 'xScale', | ||
| 'orient': 'bottom' | ||
| }); | ||
| count = 0; | ||
|
|
||
| axis.on( 'change', onChange ); | ||
|
|
||
| axis.bandPosition = 0.5; | ||
| t.strictEqual( count, 1, 'returns expected value' ); | ||
|
|
||
| axis.bandPosition = 0.3; | ||
| t.strictEqual( count, 2, 'returns expected value' ); | ||
|
|
||
| // Setting to the same value should not emit an event: | ||
| axis.bandPosition = 0.3; | ||
| t.strictEqual( count, 2, 'returns expected value' ); | ||
|
|
||
| t.end(); | ||
|
|
||
| function onChange() { | ||
| count += 1; | ||
| } | ||
| }); | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.