Skip to content

feat: add math/base/special/trunc10f#10421

Open
nirmaljb wants to merge 4 commits intostdlib-js:developfrom
nirmaljb:feat/trunc10f
Open

feat: add math/base/special/trunc10f#10421
nirmaljb wants to merge 4 commits intostdlib-js:developfrom
nirmaljb:feat/trunc10f

Conversation

@nirmaljb
Copy link
Copy Markdown
Contributor

@nirmaljb nirmaljb commented Feb 22, 2026 •
edited
Loading

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: passed
  • task: lint_c_examples status: passed
  • task: lint_c_benchmarks status: passed
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Progresses: #649 .

Description

What is the purpose of this pull request?

This pull request:

  • added single-precision float number value to trunc10
  • added test, benchmark, example and readme.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

@nirmaljb
feat: add c implementation for trunc10f
8147ce6 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Feb 22, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Feb 22, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/special/trunc10f $\color{green}169/169$
$\color{green}+0.00%$ 		$\color{green}12/12$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}169/169$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Feb 22, 2026

⚠️ Tracking Issue Closure Warning ⚠️

I noticed your PR description contains closing keywords ("Resolves", "Closes", or "Fixes") referencing a "Tracking Issue".

Why this matters:
Tracking issues should typically remain open until all related sub-issues are completed. GitHub automatically closes issues with such closing keywords when the PR is merged. For more information, see GitHub's documentation on using keywords in issues and pull requests.

Required action:
Use "Progresses" instead to reference the tracking issue without automatically closing it.

Thank you for your contribution to the project!

@nirmaljb
Copy link
Copy Markdown
Contributor Author

nirmaljb commented Feb 22, 2026

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 22, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 22, 2026
@gunjjoshi gunjjoshi changed the title feat: add C implementation for math/base/special/trunc10f feat: add math/base/special/trunc10f Feb 22, 2026
@gunjjoshi
Copy link
Copy Markdown
Member

gunjjoshi commented Feb 22, 2026

@nirmaljb Note that we are adding a new package in this PR, not adding the C implementation of an existing one. Thus, I've modified the PR title.

@nirmaljb
Copy link
Copy Markdown
Contributor Author

nirmaljb commented Feb 23, 2026

Alright!
I will keep that in mind from next time onwards.

hrshya
hrshya reviewed Feb 25, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/math/base/special/trunc10f/benchmark/c/native/benchmark.c Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/trunc10f/benchmark/benchmark.js
Comment thread lib/node_modules/@stdlib/math/base/special/trunc10f/benchmark/benchmark.native.js
Comment thread lib/node_modules/@stdlib/math/base/special/trunc10f/lib/main.js
@nirmaljb
bench: replaced rand_float with random_uniform
4afa586 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gunjjoshi gunjjoshi added status: Blocked Issue or pull request which is currently blocked. and removed Needs Review A pull request which needs code review. labels Mar 1, 2026
@nirmaljb
fix: fix some minor issues
932727f 
1. Removed the unnecessary note from README. Because f32(1e-44) = 9.809e-45 which is not a power of 10 — it's just the nearest float32 value (7 * 2^-149). Truncating it to 1.401e-45 (10^-45)
2. Remove the unnecessary test case.
3. Put a f32 wrapper around the return computation in main.js
4. Put f after floating number in main.c and readme.md

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@nirmaljb nirmaljb mentioned this pull request Mar 17, 2026
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hrshya hrshya hrshya left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Math Issue or pull request specific to math functionality. status: Blocked Issue or pull request which is currently blocked.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nirmaljb @stdlib-bot @gunjjoshi @hrshya