Skip to content

bench: refactor to use string interpolation in stats/min-by#10465

Merged
Planeshifter merged 2 commits intostdlib-js:developfrom
rautelaKamal:fix/benchmark-string-interpolation-min-by
Mar 4, 2026
Merged

bench: refactor to use string interpolation in stats/min-by#10465
Planeshifter merged 2 commits intostdlib-js:developfrom
rautelaKamal:fix/benchmark-string-interpolation-min-by

Conversation

@rautelaKamal
Copy link
Copy Markdown
Contributor

Ref: #8647.

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I used an AI coding assistant to quickly identify the locations of string concatenations in the benchmark files and to apply the @stdlib/string/format refactoring consistently across the package.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Feb 24, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Feb 24, 2026

Coverage Report

Package Statements Branches Functions Lines
stats/min-by $\color{green}161/161$
$\color{green}+100.00%$
$\color{green}2/2$
$\color{green}+100.00%$
$\color{green}0/0$
$\color{green}+100.00%$
$\color{green}161/161$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 4, 2026
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 4, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

PR Commit Message

bench: refactor to use string interpolation in `stats/min-by`

PR-URL: https://github.com/stdlib-js/stdlib/pull/10465
Ref: https://github.com/stdlib-js/stdlib/issues/8647

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

⚠️ Action Required: This PR references tracking issues. Please update the PR description to replace any "Closes", "Fixes", or "Resolves" keywords with "Ref" when referencing these issues.

@Planeshifter Planeshifter merged commit 361e9fb into stdlib-js:develop Mar 4, 2026
30 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Mar 4, 2026
Witty-31-06 pushed a commit to Witty-31-06/stdlib that referenced this pull request Mar 7, 2026
PR-URL: stdlib-js#10465
Ref: stdlib-js#8647

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants