Skip to content

feat : add symbol/split#10466

Open
Diyan-Dev wants to merge 1 commit intostdlib-js:developfrom
Diyan-Dev:feature/add-symbol-split
Open

feat : add symbol/split#10466
Diyan-Dev wants to merge 1 commit intostdlib-js:developfrom
Diyan-Dev:feature/add-symbol-split

Conversation

@Diyan-Dev
Copy link
Copy Markdown
Contributor

Resolves #8488.

Description

What is the purpose of this pull request?

This pull request:

  • This pull request adds the implementation of the package symbol/split according to conventions asked in the issue.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Feb 24, 2026
@Diyan-Dev
Copy link
Copy Markdown
Contributor Author

@kgryte As asked i implemented split. I creafully examined symbol/replace package for examples and symbol/has-instance for syntax and README.
Please examine this.

@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
symbol/split $\color{green}90/90$
$\color{green}+100.00%$
$\color{red}2/3$
$\color{green}+66.67%$
$\color{green}0/0$
$\color{green}+100.00%$
$\color{green}90/90$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@Diyan-Dev
Copy link
Copy Markdown
Contributor Author

Okay i think some tests are failing. Although my Linting checks in my local repo didn't show any errors. @kgryte can you please check.
Thanks!!!!

@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. Potential Duplicate There might be another pull request resolving the same issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add symbol/split

2 participants