Skip to content

bench: refactor to use string interpolation in stats/**/nanmax-by packages#10495

Merged
kgryte merged 6 commits intostdlib-js:developfrom
rautelaKamal:feature/stats/nanmax-by-bench-string-interpolation
Apr 11, 2026
Merged

bench: refactor to use string interpolation in stats/**/nanmax-by packages#10495
kgryte merged 6 commits intostdlib-js:developfrom
rautelaKamal:feature/stats/nanmax-by-bench-string-interpolation

Conversation

@rautelaKamal
Copy link
Copy Markdown
Contributor

@rautelaKamal rautelaKamal commented Feb 25, 2026

Ref #8647.

Description

What is the purpose of this pull request?

This pull request:

  • Refactors benchmark names in @stdlib/stats/nanmax-by to use string interpolation via @stdlib/string/format instead of string concatenation, improving readability and consistency with project standards.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I consulted an AI Assistant to help identify benchmark files requiring refactoring and to understand the preferred stdlib-js style for string interpolation. The code changes themselves follow established patterns in the repository.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Feb 25, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Feb 25, 2026

Coverage Report

Package Statements Branches Functions Lines
stats/base/ndarray/nanmax-by $\color{green}123/123$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}123/123$
$\color{green}+0.00%$
stats/nanmax-by $\color{green}161/161$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}0/0$
$\color{green}+0.00%$
$\color{green}161/161$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@rautelaKamal rautelaKamal force-pushed the feature/stats/nanmax-by-bench-string-interpolation branch 4 times, most recently from c148a3c to fe50d06 Compare February 25, 2026 19:13
@rautelaKamal
Copy link
Copy Markdown
Contributor Author

No description provided.

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Feb 27, 2026
@rautelaKamal rautelaKamal marked this pull request as draft March 13, 2026 08:38
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 13, 2026
@rautelaKamal rautelaKamal force-pushed the feature/stats/nanmax-by-bench-string-interpolation branch from 5f92b50 to 6aa678d Compare April 4, 2026 19:12
@rautelaKamal rautelaKamal marked this pull request as ready for review April 4, 2026 19:13
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 4, 2026
@rautelaKamal rautelaKamal force-pushed the feature/stats/nanmax-by-bench-string-interpolation branch from 6aa678d to 3cbc480 Compare April 4, 2026 19:22
Signed-off-by: Kamal Singh Rautela <e22cseu1624@bennett.edu.in>
@rautelaKamal rautelaKamal force-pushed the feature/stats/nanmax-by-bench-string-interpolation branch from 3cbc480 to c3ece04 Compare April 4, 2026 19:34
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels Apr 11, 2026
Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte kgryte changed the title bench: refactor to use string interpolation in stats/nanmax-by bench: refactor to use string interpolation in stats/**/nanmax-by packages Apr 11, 2026
@kgryte kgryte merged commit 2d4fd4e into stdlib-js:develop Apr 11, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. review: 2 Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants