bench: refactor to use string interpolation in stats/**/nanmax-by packages#10495
Merged
kgryte merged 6 commits intostdlib-js:developfrom Apr 11, 2026
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
c148a3c to
fe50d06
Compare
Contributor
Author
|
No description provided. |
5f92b50 to
6aa678d
Compare
6aa678d to
3cbc480
Compare
Signed-off-by: Kamal Singh Rautela <e22cseu1624@bennett.edu.in>
3cbc480 to
c3ece04
Compare
kgryte
reviewed
Apr 11, 2026
lib/node_modules/@stdlib/stats/base/ndarray/nanmax-by/benchmark/benchmark.js
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Apr 11, 2026
lib/node_modules/@stdlib/stats/strided/nanmax-by/benchmark/benchmark.ndarray.js
Show resolved
Hide resolved
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Apr 11, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Apr 11, 2026
lib/node_modules/@stdlib/stats/base/ndarray/nanmax-by/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
stats/**/nanmax-by packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #8647.
Description
This pull request:
@stdlib/stats/nanmax-byto use string interpolation via@stdlib/string/formatinstead of string concatenation, improving readability and consistency with project standards.Related Issues
No.
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I consulted an AI Assistant to help identify benchmark files requiring refactoring and to understand the preferred
stdlib-jsstyle for string interpolation. The code changes themselves follow established patterns in the repository.@stdlib-js/reviewers