feat: add C implementation for `stats/base/dists/lognormal/cdf` by bhargava-d16 · Pull Request #10809 · stdlib-js/stdlib

bhargava-d16 · 2026-03-08T11:39:51Z

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: passed
task: lint_package_json status: passed
task: lint_repl_help status: na
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: na
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: passed
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: missing_dependencies
task: lint_c_examples status: missing_dependencies
task: lint_c_benchmarks status: missing_dependencies
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: na
task: lint_license_headers status: passed ---

Resolves #3747

Description

What is the purpose of this pull request?

This pull request:

adds C implementation for @stdlib/stats/base/dists/lognormal/cdf

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

[RFC]: Add C implementation for @stdlib/stats/base/dists/lognormal/cdf #3747

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

Signed-off-by: Bhargav Dabhade <bhargava2005dabhade@gmail.com> --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot · 2026-03-08T11:43:32Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/lognormal/cdf	$\color{green}281/281$ $\color{green}+0.00%$	$\color{green}23/23$ $\color{green}+0.00%$	$\color{green}4/4$ $\color{green}+0.00%$	$\color{green}281/281$ $\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

Neerajpathak07

@bhargava-d16 Overall this looks great. Just a few comments and nitpicks.

Neerajpathak07 · 2026-03-25T07:08:32Z

+static double benchmark( void ) {
+	double elapsed;
+	double sigma[ 100 ];
+	double mu[ 100 ];
+	double x[ 100 ];


Suggested change

static double benchmark( void ) {

double elapsed;

double sigma[ 100 ];

double mu[ 100 ];

double x[ 100 ];

static double benchmark( void ) {

double sigma[ 100 ];

double mu[ 100 ];

double x[ 100 ];

double elapsed;

Ordering by length

Neerajpathak07 · 2026-03-25T07:12:29Z

+	x = uniform( 100, 0.1, 20.0, opts );
+	mu = uniform( 100, -5.0, 5.0, opts );
+	sigma = uniform( 100, EPS, 5.0, opts );


Normally what we want to do is align the C benchmark ranges to the corresponding range values opted in JS benchmark. Maybe we can follow it here as well!!!

Neerajpathak07 · 2026-03-25T07:13:32Z

+	x = uniform( 100, 0.1, 20.0, opts );
+	mu = uniform( 100, -5.0, 5.0, opts );
+	sigma = uniform( 100, EPS, 5.0, opts );


Same comment here as well. You can align these ranges to the ones used in benchmark.js

Neerajpathak07 · 2026-03-25T07:20:19Z

+	t.end();
+});
+
+tape( 'the function evaluates the cdf for `x` given positive `mu`', opts, function test( t ) {


nit: If possible could you pls modify these test cases to test against fixtures drawn from a singular json file namely data.json also to use isAlmostSameValue. This is also expected to be updated throughout the test files.

you can also take a look at:- https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/stats/base/dists/wald/pdf/test/test.pdf.js#L197

Neerajpathak07 · 2026-03-25T07:24:57Z

+	for ( i = 0; i < 25; i++ ) {
+		x = random_uniform( 0.0, 10.0 );
+		mu = random_uniform( -5.0, 5.0 );
+		sigma = random_uniform( STDLIB_CONSTANT_FLOAT64_EPS, 5.0 );


Corresponding JS example does not use eps in it's range values. Might be better to update it here as well.
Meaning you'll also have to update the documentation and the manifest eventually.

Ref:- https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/stats/base/dists/lognormal/cdf/examples/index.js#L30

Signed-off-by: Bhargav Dabhade <bhargava2005dabhade@gmail.com> --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

bhargava-d16 · 2026-04-03T06:54:58Z

@Planeshifter I have made the suggested changes. Please let me know if any further changes are required.

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 8, 2026

Neerajpathak07 requested changes Mar 25, 2026

View reviewed changes

github-actions Bot mentioned this pull request Mar 25, 2026

[aw] No-Op Runs #11033

Open

bhargava-d16 added 2 commits March 26, 2026 09:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add C implementation for `stats/base/dists/lognormal/cdf`#10809

feat: add C implementation for `stats/base/dists/lognormal/cdf`#10809
bhargava-d16 wants to merge 3 commits intostdlib-js:developfrom
bhargava-d16:feat-lognormal-cdf-c-implementation

bhargava-d16 commented Mar 8, 2026

Uh oh!

stdlib-bot commented Mar 8, 2026 •

edited

Loading

Uh oh!

Neerajpathak07 left a comment

Uh oh!

Neerajpathak07 Mar 25, 2026

Uh oh!

Neerajpathak07 Mar 25, 2026

Uh oh!

Neerajpathak07 Mar 25, 2026

Uh oh!

Neerajpathak07 Mar 25, 2026

Uh oh!

Neerajpathak07 Mar 25, 2026

Uh oh!

Neerajpathak07 Mar 25, 2026

Uh oh!

bhargava-d16 commented Apr 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

bhargava-d16 commented Mar 8, 2026

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Neerajpathak07 left a comment

Choose a reason for hiding this comment

Uh oh!

Neerajpathak07 Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Neerajpathak07 Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Neerajpathak07 Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Neerajpathak07 Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Neerajpathak07 Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Neerajpathak07 Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

bhargava-d16 commented Apr 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stdlib-bot commented Mar 8, 2026 •

edited

Loading