feat: add C implementation for stats/base/dists/lognormal/cdf#10883
feat: add C implementation for stats/base/dists/lognormal/cdf#10883rautelaKamal wants to merge 1 commit intostdlib-js:developfrom
Conversation
|
Hello! 👋 We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm! Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks. Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀 For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
db99cb5 to
31dab56
Compare
b5f205d to
8fd6468
Compare
8fd6468 to
58353a4
Compare
58353a4 to
82c5d79
Compare
| #define NAME "lognormal-cdf" | ||
| #define ITERATIONS 1000000 | ||
| #define REPEATS 3 | ||
|
|
There was a problem hiding this comment.
You are missing all the Doxygen comments. https://github.com/stdlib-js/stdlib/blob/develop/tools/snippets/benchmark/c/benchmark.c
There was a problem hiding this comment.
I've addressed the feedback in the latest push (added Doxygen comments, migrated to the new RNG, and updated isAlmostSameValue usage). This PR should be ready for re-review.
| t.strictEqual( y, expected[i], 'x: '+x[i]+', mu:'+mu[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); | ||
| } else { | ||
| delta = abs( y - expected[ i ] ); | ||
| tol = 1500.0 * EPS * abs( expected[ i ] ); |
There was a problem hiding this comment.
You should go ahead and migrate to using isAlmostSameValue for ULP-based difference testing.
stats/base/dists/lognormal/cdf
|
@rautelaKamal I updated your PR title. Would you mind updating your other PR titles similarly? This reduces the amount of busy work required from maintainers. Cheers! |
82c5d79 to
8b839ee
Compare
stats/base/dists/lognormal/cdf8b839ee to
5b610f2
Compare
5b610f2 to
f2b9171
Compare
|
I have updated the PR titles as requested and addressed the feedback regarding isAlmostSameValue, Doxygen, and RNG migration. This PR is now ready for re-review. |
Description
What is the purpose of this pull request?
This pull request:
@stdlib/stats/base/dists/lognormal/cdf). The implementation delegates to the nativestdlib_base_dists_normal_cdffunction after log-transforming the inputx, adhering to the modular C core approach.Related Issues
Does this pull request have any related issues?
This pull request has the following related issues:
Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
AI Assistance Disclosure
If yes, how was AI used?
I used an AI to speed up the translation of JS tests to native tests using the Julia fixtures, and to stub out the required C files (
addon.c,main.c, build configs). The generated code was then verified against project style guidelines.Checklist