Skip to content

chore: replace new Array() with array literal in binary_to_symbolic.js #10886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 4 commits into from
Apr 10, 2026
Merged

chore: replace new Array() with array literal in binary_to_symbolic.js #10886

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0c6e57
fix: resolve eslint linting failures
Daniel-1600 Mar 12, 2026
27f9378
chore: undo change
kgryte Apr 10, 2026
58498d0
fix: perform explicit push
kgryte Apr 10, 2026
a1a804c
Merge remote-tracking branch 'upstream/develop' into fix/eslint-no-ne…
stdlib-bot Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/process/umask/scripts/binary_to_symbolic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
TOTAL = 8 * 8 * 8 * 8;

// For each integer value (octal number), determine the symbolic notation equivalent to the value's binary representation...
masks = new Array( TOTAL );
masks = [];
for ( i = 0; i < TOTAL; i++ ) {
tmp = '';

Expand Down Expand Up @@ -79,14 +79,14 @@
}
}
// [ integer, octal, binary_string, symbolic_notation ]
masks[ i ] = [ i, lpad( i.toString( 8 ), 4, '0' ), bstr, tmp ];
masks.push( [ i, lpad( i.toString( 8 ), 4, '0' ), bstr, tmp ] );
}

if ( PRETTY_PRINT ) {
// Print the list of masks in symbolic notation:
for ( i = 0; i < TOTAL; i++ ) {
console.log( '%d = %s = %s = %s', masks[i][0], masks[i][1], masks[i][2], masks[i][3] );

Check warning on line 88 in lib/node_modules/@stdlib/process/umask/scripts/binary_to_symbolic.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected console statement
}
} else {
console.log( JSON.stringify( masks ) );

Check warning on line 91 in lib/node_modules/@stdlib/process/umask/scripts/binary_to_symbolic.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected console statement
}