Skip to content

feat: add ndarray/to-string#10899

Merged
kgryte merged 6 commits intostdlib-js:developfrom
headlessNode:ndarray-toString
Apr 6, 2026
Merged

feat: add ndarray/to-string#10899
kgryte merged 6 commits intostdlib-js:developfrom
headlessNode:ndarray-toString

Conversation

@headlessNode
Copy link
Copy Markdown
Member

@headlessNode headlessNode commented Mar 12, 2026

Resolves stdlib-js/metr-issue-tracker#188.

Description

What is the purpose of this pull request?

This pull request:

  • add ndarray/to-string

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Primarily written by Claude Code.

@stdlib-js/reviewers

@headlessNode headlessNode added Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project. labels Mar 12, 2026
@headlessNode
Copy link
Copy Markdown
Member Author

headlessNode commented Mar 12, 2026

Need to merge #10898 first.

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Apr 3, 2026

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 3, 2026
@kgryte kgryte marked this pull request as ready for review April 3, 2026 08:28
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 3, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 3, 2026
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Apr 3, 2026

@headlessNode Looks like this PR needs some work in order to get CI to pass.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Apr 3, 2026
@github-actions github-actions bot mentioned this pull request Apr 3, 2026
Open
@headlessNode
fix: apply suggestions from code review
feaff07 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Apr 3, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
ndarray/to-string $\color{red}285/287$
$\color{green}+0.00%$ 		$\color{red}28/31$
$\color{green}+0.00%$ 		$\color{green}4/4$
$\color{green}+0.00%$ 		$\color{red}285/287$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@headlessNode headlessNode requested a review from kgryte April 3, 2026 16:17
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 3, 2026
@headlessNode headlessNode removed the Needs Changes Pull request which needs changes before being merged. label Apr 3, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 4, 2026
kgryte
kgryte reviewed Apr 4, 2026
View reviewed changes
kgryte
kgryte requested changes Apr 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial comments.

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Apr 4, 2026

For METR,

review_time: 10 mins

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Apr 4, 2026
@headlessNode
refactor: apply suggestions from code review
498395e 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@headlessNode headlessNode added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Apr 4, 2026
@headlessNode headlessNode requested a review from kgryte April 4, 2026 11:10
kgryte
kgryte reviewed Apr 6, 2026
View reviewed changes
@kgryte
test: update description
a7deb43 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Apr 6, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 6, 2026
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Apr 6, 2026

For METR,

review_time: 5 mins

@kgryte kgryte merged commit 47e4985 into stdlib-js:develop Apr 6, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add ndarray/to-string

3 participants

@headlessNode @kgryte @stdlib-bot