bench: refactor to use string interpolation in @stdlib/stats/base/dists/discrete-uniform/mean#10985
Conversation
…rete-uniform/mean`
rautelaKamal
force-pushed
the
refactor/discrete-uniform-mean-benchmarks
branch
from
11df45b to
9f11332
Compare
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
stdlib-bot
added
Statistics
| var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ); | ||
| var Float64Array = require( '@stdlib/array/float64' ); | ||
| var isnan = require( '@stdlib/math/base/assert/is-nan' ); | ||
| var tryRequire = require( '@stdlib/utils/try-require' ); | ||
| var format = require( '@stdlib/string/format' ); |
There was a problem hiding this comment.
you just need to use string interpolation in JS benchmarks as suggested in the issue #8647
|
#10345 already addressed this, so closing this PR. For future reference, PR title here should have been "bench: refactor to use string interpolation in `stats/base/dists/discrete-uniform/mean`". |
4 participants
Description
This PR refactors the benchmark files to use string interpolation for benchmark names and corrects the variable sorting order in the main loop to follow the convention
len, max, min, i, y.Checklist