Skip to content

feat: add ndarray/base/full#11017

Merged
kgryte merged 7 commits intostdlib-js:developfrom
LoayAhmed304:feat/base-ndarray-full
Mar 24, 2026
Merged

feat: add ndarray/base/full#11017
kgryte merged 7 commits intostdlib-js:developfrom
LoayAhmed304:feat/base-ndarray-full

Conversation

@LoayAhmed304
Copy link
Copy Markdown
Contributor

Resolves #{{TODO: add issue number}}.

Description

What is the purpose of this pull request?

This pull request:

  • Implements the full function for ndarrays, which creates an ndarray having a specified shape, data type, and filled with a specified value.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • #{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 18, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Mar 18, 2026

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/full $\color{green}127/127$
$\color{green}+100.00%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}127/127$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Needs Changes Pull request which needs changes before being merged. difficulty: 3 Likely to be challenging but manageable. and removed Needs Review A pull request which needs code review. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. labels Mar 18, 2026
@LoayAhmed304 LoayAhmed304 requested a review from kgryte March 18, 2026 21:42
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 18, 2026
@github-actions github-actions bot mentioned this pull request Mar 21, 2026
@kgryte kgryte removed Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. labels Mar 23, 2026
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Mar 23, 2026

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 23, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 23, 2026
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Mar 24, 2026

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 24, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 24, 2026
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte kgryte merged commit 204c9d9 into stdlib-js:develop Mar 24, 2026
31 checks passed
@LoayAhmed304 LoayAhmed304 deleted the feat/base-ndarray-full branch March 24, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 3 Likely to be challenging but manageable. Feature Issue or pull request for adding a new feature. review: 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants