feat: add C implementation for stats/base/dists/erlang/cdf#11104
feat: add C implementation for stats/base/dists/erlang/cdf#11104Lokeshranjan8 wants to merge 1 commit intostdlib-js:developfrom
stats/base/dists/erlang/cdf#11104Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: passed
- task: lint_c_examples
status: passed
- task: lint_c_benchmarks
status: passed
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Coverage Report
The above coverage report was generated for the changes in this PR. |
Neerajpathak07
left a comment
There was a problem hiding this comment.
@Lokeshranjan8 Have left out an inital round of comments. Mainly you'll have to check your implementation and rectify which dtype k uses and which corresponding macro will be required for it.
To get a good idea of the current code convention for these pacakges take a look at:- https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/base/dists/wald/pdf
lib/node_modules/@stdlib/stats/base/dists/erlang/cdf/benchmark/c/benchmark.c
Show resolved
Hide resolved
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the function evaluates the cdf for `x` given large `k` and `lambda`', opts, function test( t ) { |
There was a problem hiding this comment.
could you streamline this test cases to adhere to the latest code convention which we follow for statistical distribution packages.
you can refer to:-
here you mainly have to update the upstream fixtures for the package to house them inside a single data.json file. After which it can be sourced to test various edge cases as per done in the ref above.
Another nitpick would be to use isAlmostSameValue.
Resolves #3568 .
Description
This pull request:
adds C implementation for stats/base/dists/erlang/cdf along with relevant docs, tests, examples and benchmarksRelated Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers