Skip to content

feat: add C implementation for stats/base/dists/erlang/cdf#11104

Draft
Lokeshranjan8 wants to merge 1 commit intostdlib-js:developfrom
Lokeshranjan8:erlang-cdf
Draft

feat: add C implementation for stats/base/dists/erlang/cdf#11104
Lokeshranjan8 wants to merge 1 commit intostdlib-js:developfrom
Lokeshranjan8:erlang-cdf

Conversation

@Lokeshranjan8
Copy link
Copy Markdown
Contributor

@Lokeshranjan8 Lokeshranjan8 commented Mar 23, 2026

Resolves #3568 .

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for stats/base/dists/erlang/cdf along with relevant docs, tests, examples and benchmarks

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Mar 23, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/erlang/cdf $\color{green}290/290$
$\color{green}+100.00%$
$\color{green}11/11$
$\color{green}+100.00%$
$\color{green}3/3$
$\color{green}+100.00%$
$\color{green}290/290$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@github-actions github-actions bot mentioned this pull request Mar 23, 2026
Copy link
Copy Markdown
Member

@Neerajpathak07 Neerajpathak07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lokeshranjan8 Have left out an inital round of comments. Mainly you'll have to check your implementation and rectify which dtype k uses and which corresponding macro will be required for it.
To get a good idea of the current code convention for these pacakges take a look at:- https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/base/dists/wald/pdf

t.end();
});

tape( 'the function evaluates the cdf for `x` given large `k` and `lambda`', opts, function test( t ) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you streamline this test cases to adhere to the latest code convention which we follow for statistical distribution packages.
you can refer to:-

tape( 'the function evaluates the pdf for `x` given parameters `mu` and `lambda`', function test( t ) {

here you mainly have to update the upstream fixtures for the package to house them inside a single data.json file. After which it can be sourced to test various edge cases as per done in the ref above.

Another nitpick would be to use isAlmostSameValue.

@Lokeshranjan8 Lokeshranjan8 marked this pull request as draft March 24, 2026 09:01
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/erlang/cdf

3 participants