feat: add stats/strided/dnanmeankbn#11129
Open
parthodas23 wants to merge 1 commit intostdlib-js:developfrom
Open
feat: add stats/strided/dnanmeankbn#11129parthodas23 wants to merge 1 commit intostdlib-js:developfrom
stats/strided/dnanmeankbn#11129parthodas23 wants to merge 1 commit intostdlib-js:developfrom
Conversation
stdlib-bot
added
Statistics
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
parthodas23
force-pushed
the
feat/stats-strided-dnanmeankbn
branch
from
0baf7d2 to
21625a5
Compare
kgryte
reviewed
Apr 4, 2026
Comment on lines
+64
to
+74
| for ( i = 0; i < N; i++ ) { | ||
| v = x[ ix ]; | ||
| if ( v === v ) { | ||
| count += 1; | ||
| } | ||
| ix += strideX; | ||
| } | ||
| if ( count === 0 ) { | ||
| return NaN; | ||
| } | ||
| sum = dnansumkbn( N, x, strideX, offsetX ); |
Member
There was a problem hiding this comment.
This is not what is desired. You are effectively doing two passes. You should be using https://github.com/stdlib-js/stdlib/tree/d479058e503f9625161a2666e308d6976902d0f6/lib/node_modules/%40stdlib/blas/ext/base/dnannsumkbn. Returning both the sum and the count is precisely the point of that package.
kgryte
added
Feature
parthodas23
force-pushed
the
feat/stats-strided-dnanmeankbn
branch
from
21625a5 to
aecc81a
Compare
parthodas23
force-pushed
the
feat/stats-strided-dnanmeankbn
branch
from
aecc81a to
6916a37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #345 .
Description
This pull request:
stats/strided/dnanmeankbnRelated Issues
This pull request has the following related issues:
stats/strided/dnanmeankbn#345Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers