Skip to content

feat: add blas/ext/base/gjoin-between#11140

Merged
kgryte merged 10 commits intostdlib-js:developfrom
headlessNode:blas/gjoin-between
Mar 27, 2026
Merged

feat: add blas/ext/base/gjoin-between#11140
kgryte merged 10 commits intostdlib-js:developfrom
headlessNode:blas/gjoin-between

Conversation

@headlessNode
Copy link
Copy Markdown
Member

@headlessNode headlessNode commented Mar 25, 2026

Resolves stdlib-js/metr-issue-tracker#208.

Description

What is the purpose of this pull request?

This pull request:

  • add blas/ext/base/gjoin-between

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Primarily written by Claude Code. It introduced a bug in accessors.js which was fixed manually and as usual the test files needed some fixing as well.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Mar 25, 2026
@headlessNode headlessNode added Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project. labels Mar 25, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Mar 25, 2026

Coverage Report

No coverage information available.

@headlessNode headlessNode requested a review from kgryte March 25, 2026 14:29
@github-actions github-actions bot mentioned this pull request Mar 25, 2026
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte added 2 commits March 25, 2026 23:46
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than updating descriptions and the REPL help file, this is looking good.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 26, 2026
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Mar 26, 2026

For METR,

review_time: 15 mins

@headlessNode headlessNode requested a review from kgryte March 26, 2026 17:31
@headlessNode headlessNode added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 26, 2026
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 27, 2026
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Mar 27, 2026

For METR,

review_time: 11 minutes

@kgryte kgryte merged commit 34c1828 into stdlib-js:develop Mar 27, 2026
14 checks passed
@headlessNode headlessNode deleted the blas/gjoin-between branch March 27, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add blas/ext/base/gjoin-between

3 participants