Skip to content

chore: fix JavaScript lint errors (issue #11193)#11199

Merged
kgryte merged 1 commit intostdlib-js:developfrom
Kartikeya-guthub:chore/fix-js-lint-11193
Apr 2, 2026
Merged

chore: fix JavaScript lint errors (issue #11193)#11199
kgryte merged 1 commit intostdlib-js:developfrom
Kartikeya-guthub:chore/fix-js-lint-11193

Conversation

@Kartikeya-guthub
Copy link
Copy Markdown
Contributor

@Kartikeya-guthub Kartikeya-guthub commented Mar 29, 2026

Resolves #11193.

Description

What is the purpose of this pull request?

This pull request:

  • fixes JavaScript lint errors in the ztest2 benchmark by replacing disallowed new Array(...) usage with array literals and push(...)
  • keeps benchmark behavior unchanged (same generated sample sizes and value initialization flow)

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • File locating
  • PR Documentation
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I used ChatGPT only to locate the relevant file. I completed the refactor and all subsequent changes manually, and reviewed and validated the final code before submission


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 29, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@github-actions github-actions bot mentioned this pull request Mar 29, 2026
@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 30, 2026
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels Apr 2, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

@kgryte kgryte merged commit 7a2753c into stdlib-js:develop Apr 2, 2026
148 checks passed
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Apr 2, 2026

Thank you for your contribution and congratulations on your first PR!

@Kartikeya-guthub
Copy link
Copy Markdown
Contributor Author

Thank you for your contribution and congratulations on your first PR!

Thank you for the review and merge! I appreciate it and look forward to further contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue. review: 5 Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants