chore: address commit comments for halfnormal logpdf#11290
Open
GuneetGill wants to merge 1 commit intostdlib-js:developfrom
Open
chore: address commit comments for halfnormal logpdf#11290GuneetGill wants to merge 1 commit intostdlib-js:developfrom
GuneetGill wants to merge 1 commit intostdlib-js:developfrom
Conversation
Contributor
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11289.
Description
This pull request:
halfnormal/logpdfREADME so the distribution name follows project prose style (half-normal, not “Half-Normal”) in the linked intro line.benchmark/benchmark.jsto generate benchmark data with@stdlib/random/array/uniforminstead of the olderrandu/manual array pattern.benchmark/benchmark.native.jsthe same way, usinguniformwith{ 'dtype': 'float64' }so the native benchmark matches current conventions used by similar packages (e.g.normal/logpdf).These changes address the review comments on commit
f4a07184f537ba8ef7928eb6cca51d0e1732f50ereferenced in #11289.Related Issues
This pull request has the following related issues:
f4a0718) #11289Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I used Cursor to understand the codebase to get a general sense of how the files I am touching work with one another. The code was written and tested by me.
@stdlib-js/reviewers