fix: propagate wrapped subcommand exit codes#11294
fix: propagate wrapped subcommand exit codes#11294saschabuehrle wants to merge 1 commit intostdlib-js:developfrom
Conversation
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
Hey @saschabuehrle — thanks for the quick fix! Use process.execPath instead of 'node' in spawn(...) so the child uses the same Node binary as the parent. Also, looks like check_contributing_guidelines_acceptance is failing due to the missing contributing-guidelines checkbox in the PR description. |
Better would be to use the corresponding |
@Vipeen-Kumar This is a separate issue and not applicable to the upstream issue which this PR is intended to address. Please ensure that whatever LLM code review you are running is actually tailored and scoped to the issue at hand. |
|
@kgryte Thanks for calling that out — you’re right. |
Fixes #11293
The wrapper was only handling process spawn errors, so non-zero exits from the delegated command were lost. This wires the child process close event and exits with the same status (or forwards the signal) so wrapper behavior matches direct command execution.
Greetings, saschabuehrle