Skip to content

fix: propagate wrapped subcommand exit codes #11294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saschabuehrle wants to merge 1 commit into
base: develop
Choose a base branch
from
+16 −0
Open

fix: propagate wrapped subcommand exit codes #11294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions bin/cli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ function main() {
// Invoke the command in a sub-process:
proc = spawn( 'node', subargs, opts );
proc.on( 'error', onError );
proc.on( 'close', onClose );

/**
* Callback invoked upon encountering an error while running a command.
Expand All @@ -190,6 +191,21 @@ function main() {
function onError( error ) {
cli.error( error );
}

/**
* Callback invoked upon command exit.
*
* @private
* @param {integer} code - exit code
* @param {(string|null)} signal - exit signal
*/
function onClose( code, signal ) {
if ( signal ) {
process.kill( process.pid, signal );
return;
}
process.exit( code || 0 );
}
}

main();
Loading