Skip to content

bench: refactor to use string interpolation in math/strided/special (batch 3/3)#11364

Merged
kgryte merged 1 commit intostdlib-js:developfrom
anandkaranubc:bench/math-strided-format3
Apr 11, 2026
Merged

bench: refactor to use string interpolation in math/strided/special (batch 3/3)#11364
kgryte merged 1 commit intostdlib-js:developfrom
anandkaranubc:bench/math-strided-format3

Conversation

@anandkaranubc
Copy link
Copy Markdown
Contributor

@anandkaranubc anandkaranubc commented Apr 11, 2026

Progresses #8647
Resolves stdlib-js/metr-issue-tracker#312

Description

What is the purpose of this pull request?

This pull request:

  • refactors to use string interpolation in math/strided/special

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Used a Cursor driven Skill+Workflow to achieve this migration with manual and automated sanity checks.

@stdlib-js/reviewers

@anandkaranubc
bench: refactor to use string interpolation in math/strided/special…
fcb0d34 
… (batch 3/3)

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc anandkaranubc added Math Issue or pull request specific to math functionality. Benchmarks Pull requests adding or improving benchmarks for measuring performance. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. METR Pull request associated with the METR project. labels Apr 11, 2026
@anandkaranubc anandkaranubc changed the title bench: refactor to use string interpolation in math/strided/special… bench: refactor to use string interpolation in math/strided/special (batch 3/3) Apr 11, 2026
@anandkaranubc
Copy link
Copy Markdown
Contributor Author

anandkaranubc commented Apr 11, 2026

This completes all the changes required for math/strided/special

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 11, 2026
kgryte
kgryte approved these changes Apr 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Apr 11, 2026

For METR,

review_time: 3 mins

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 11, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Apr 11, 2026

Coverage Report

Package Statements Branches Functions Lines
math/strided/special/smskabs $\color{green}402/402$
$\color{green}+100.00%$ 		$\color{green}16/16$
$\color{green}+100.00%$ 		$\color{green}4/4$
$\color{green}+100.00%$ 		$\color{green}402/402$
$\color{green}+100.00%$
math/strided/special/smskabs2 $\color{green}402/402$
$\color{green}+100.00%$ 		$\color{green}16/16$
$\color{green}+100.00%$ 		$\color{green}4/4$
$\color{green}+100.00%$ 		$\color{green}402/402$
$\color{green}+100.00%$
math/strided/special/smskcbrt $\color{green}402/402$
$\color{green}+100.00%$ 		$\color{green}16/16$
$\color{green}+100.00%$ 		$\color{green}4/4$
$\color{green}+100.00%$ 		$\color{green}402/402$
$\color{green}+100.00%$
math/strided/special/smskceil $\color{green}402/402$
$\color{green}+100.00%$ 		$\color{green}16/16$
$\color{green}+100.00%$ 		$\color{green}4/4$
$\color{green}+100.00%$ 		$\color{green}402/402$
$\color{green}+100.00%$
math/strided/special/smskdeg2rad $\color{green}402/402$
$\color{green}+100.00%$ 		$\color{green}16/16$
$\color{green}+100.00%$ 		$\color{green}4/4$
$\color{green}+100.00%$ 		$\color{green}402/402$
$\color{green}+100.00%$
math/strided/special/smskfloor $\color{green}402/402$
$\color{green}+100.00%$ 		$\color{green}16/16$
$\color{green}+100.00%$ 		$\color{green}4/4$
$\color{green}+100.00%$ 		$\color{green}402/402$
$\color{green}+100.00%$
math/strided/special/smskinv $\color{green}402/402$
$\color{green}+100.00%$ 		$\color{green}16/16$
$\color{green}+100.00%$ 		$\color{green}4/4$
$\color{green}+100.00%$ 		$\color{green}402/402$
$\color{green}+100.00%$
math/strided/special/smskramp $\color{green}402/402$
$\color{green}+100.00%$ 		$\color{green}16/16$
$\color{green}+100.00%$ 		$\color{green}4/4$
$\color{green}+100.00%$ 		$\color{green}402/402$
$\color{green}+100.00%$
math/strided/special/smskrsqrt $\color{green}402/402$
$\color{green}+100.00%$ 		$\color{green}16/16$
$\color{green}+100.00%$ 		$\color{green}4/4$
$\color{green}+100.00%$ 		$\color{green}402/402$
$\color{green}+100.00%$
math/strided/special/smsksqrt $\color{green}402/402$
$\color{green}+100.00%$ 		$\color{green}16/16$
$\color{green}+100.00%$ 		$\color{green}4/4$
$\color{green}+100.00%$ 		$\color{green}402/402$
$\color{green}+100.00%$
math/strided/special/smsktrunc $\color{green}402/402$
$\color{green}+100.00%$ 		$\color{green}16/16$
$\color{green}+100.00%$ 		$\color{green}4/4$
$\color{green}+100.00%$ 		$\color{green}402/402$
$\color{green}+100.00%$
math/strided/special/sqrt-by $\color{green}197/197$
$\color{green}+100.00%$ 		$\color{green}5/5$
$\color{green}+100.00%$ 		$\color{green}2/2$
$\color{green}+100.00%$ 		$\color{green}197/197$
$\color{green}+100.00%$
math/strided/special/sqrt $\color{green}528/528$
$\color{green}+100.00%$ 		$\color{green}12/12$
$\color{green}+100.00%$ 		$\color{green}2/2$
$\color{green}+100.00%$ 		$\color{green}528/528$
$\color{green}+100.00%$
math/strided/special/sramp $\color{green}374/374$
$\color{green}+100.00%$ 		$\color{green}15/15$
$\color{green}+100.00%$ 		$\color{green}4/4$
$\color{green}+100.00%$ 		$\color{green}374/374$
$\color{green}+100.00%$
math/strided/special/srsqrt $\color{green}374/374$
$\color{green}+100.00%$ 		$\color{green}15/15$
$\color{green}+100.00%$ 		$\color{green}4/4$
$\color{green}+100.00%$ 		$\color{green}374/374$
$\color{green}+100.00%$
math/strided/special/ssqrt $\color{green}374/374$
$\color{green}+100.00%$ 		$\color{green}15/15$
$\color{green}+100.00%$ 		$\color{green}4/4$
$\color{green}+100.00%$ 		$\color{green}374/374$
$\color{green}+100.00%$
math/strided/special/strunc $\color{green}374/374$
$\color{green}+100.00%$ 		$\color{green}15/15$
$\color{green}+100.00%$ 		$\color{green}4/4$
$\color{green}+100.00%$ 		$\color{green}374/374$
$\color{green}+100.00%$
math/strided/special/trunc $\color{green}551/551$
$\color{green}+100.00%$ 		$\color{green}12/12$
$\color{green}+100.00%$ 		$\color{green}2/2$
$\color{green}+100.00%$ 		$\color{green}551/551$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Apr 11, 2026

As the CI failure is expected, I'll go ahead and merge.

@kgryte kgryte merged commit a94a4ef into stdlib-js:develop Apr 11, 2026
105 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Math Issue or pull request specific to math functionality. METR Pull request associated with the METR project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: use string interpolation in JavaScript benchmarks for math/strided/special

3 participants

@anandkaranubc @kgryte @stdlib-bot