Skip to content

chore: fix JavaScript lint errors (issue #11495) #11498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bhumikasudarshani-cmd wants to merge 3 commits into from
+23 −13
Closed

chore: fix JavaScript lint errors (issue #11495) #11498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4049549
benchmark: replace Array constructor with literal and fix formatting
bhumikasudarshani-cmd Apr 17, 2026
29a384b
Merge branch 'develop' into fix-eslint-ignore
bhumikasudarshani-cmd Apr 17, 2026
5b98e03
fix: normalize changed dirs to benchmark root to reduce benchmark scope
bhumikasudarshani-cmd Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ reports/
# Node.js #
###########
/node_modules/
!/**/node_modules/*


# Git #
#######
Expand Down
20 changes: 18 additions & 2 deletions .github/workflows/run_affected_benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,15 @@ jobs:
files=$(git diff --diff-filter=AM --name-only ${{ github.event.before }} ${{ github.event.after }})
fi
fi
directories=$(for file in $files; do dirname $file; done | uniq | tr '\n' ' ' | sed 's/ $//')
directories=$(
for file in $files; do
d="$(dirname "$file")"
echo "$d" | sed -n 's#^\(lib/.*\)/benchmark/.*#\1/benchmark#p'
done \
| sort -u \
| tr '\n' ' ' \
| sed 's/ $//'
)
echo "directories=${directories}" >> $GITHUB_OUTPUT

# Get list of changed directories from workflow dispatch event:
Expand All @@ -150,5 +158,13 @@ jobs:
else
directories="${{ steps.changed-directories.outputs.directories }}"
fi
if [ -z "$directories" ]; then
echo "No changed benchmark directories detected; skipping."
exit 0
fi
if [ -z "$directories" ]; then
echo "No changed benchmark directories detected; skipping."
exit 0
fi
. "$GITHUB_WORKSPACE/.github/workflows/scripts/run_affected_benchmarks/run" "$directories"
timeout-minutes: 60
timeout-minutes: 120
5 changes: 4 additions & 1 deletion lib/node_modules/@stdlib/assert/is-readable-property-in/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@

'use strict';

'use strict';

// MODULES //

var bench = require( '@stdlib/bench' );
Expand All @@ -33,7 +35,8 @@ bench( pkg, function benchmark( b ) {
var arr;
var i;

arr = new Array( 100 ); // eslint-disable-line stdlib/no-new-array
arr = [];
arr.length = 100;

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
Expand Down
9 changes: 0 additions & 9 deletions lib/node_modules/@stdlib/blas/ext/base/lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,15 +1053,6 @@ setReadOnly( ns, 'gsumpw', require( '@stdlib/blas/ext/base/gsumpw' ) );
*/
setReadOnly( ns, 'gvander', require( '@stdlib/blas/ext/base/gvander' ) );

/**
* @name gwhere
* @memberof ns
* @readonly
* @type {Function}
* @see {@link module:@stdlib/blas/ext/base/gwhere}
*/
setReadOnly( ns, 'gwhere', require( '@stdlib/blas/ext/base/gwhere' ) );

/**
* @name gzeroTo
* @memberof ns
Expand Down