From 480bda57b8526cf7a1c80f32b99ac070e81068fc Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 18 Apr 2026 22:35:30 +0000 Subject: [PATCH 1/4] fix: drop undeclared err check and compare BigInt via Number in napi/create-int64 The @example block and README C example referenced an err variable that stdlib_napi_create_int64 never produces; the native test also compared the returned BigInt to a Number via strictEqual. --- lib/node_modules/@stdlib/napi/create-int64/README.md | 4 ---- lib/node_modules/@stdlib/napi/create-int64/src/main.c | 4 ---- .../@stdlib/napi/create-int64/test/test.native.js | 3 ++- 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/lib/node_modules/@stdlib/napi/create-int64/README.md b/lib/node_modules/@stdlib/napi/create-int64/README.md index 91a62aae552e..81fcc0cd70e5 100644 --- a/lib/node_modules/@stdlib/napi/create-int64/README.md +++ b/lib/node_modules/@stdlib/napi/create-int64/README.md @@ -119,10 +119,6 @@ static napi_value addon( napi_env env, napi_callback_info info ) { napi_value value; napi_status status = stdlib_napi_create_int64( env, 1, &value ); assert( status == napi_ok ); - if ( err != NULL ) { - assert( napi_throw( env, err ) == napi_ok ); - return NULL; - } // ... } diff --git a/lib/node_modules/@stdlib/napi/create-int64/src/main.c b/lib/node_modules/@stdlib/napi/create-int64/src/main.c index c10726e3718d..711435c99735 100644 --- a/lib/node_modules/@stdlib/napi/create-int64/src/main.c +++ b/lib/node_modules/@stdlib/napi/create-int64/src/main.c @@ -40,10 +40,6 @@ * napi_value value; * napi_status status = stdlib_napi_create_int64( env, 1, &value ); * assert( status == napi_ok ); -* if ( err != NULL ) { -* assert( napi_throw( env, err ) == napi_ok ); -* return NULL; -* } * * // ... * } diff --git a/lib/node_modules/@stdlib/napi/create-int64/test/test.native.js b/lib/node_modules/@stdlib/napi/create-int64/test/test.native.js index f3c58999e549..4ca6051d5c92 100644 --- a/lib/node_modules/@stdlib/napi/create-int64/test/test.native.js +++ b/lib/node_modules/@stdlib/napi/create-int64/test/test.native.js @@ -22,6 +22,7 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var Number = require( '@stdlib/number/ctor' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -78,7 +79,7 @@ tape( 'the function does not throw an error if provided a number', opts, functio ]; for ( i = 0; i < values.length; i++ ) { v = addon( values[ i ] ); - t.strictEqual( v, values[ i ], 'returns expected value when provided '+values[ i ] ); + t.strictEqual( Number( v ), values[ i ], 'returns expected value when provided '+values[ i ] ); } t.end(); }); From cfe45e8f7b85a43a4806c14ee317d3bb3dd0337f Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 18 Apr 2026 22:36:18 +0000 Subject: [PATCH 2/4] fix: drop undeclared err check, document BigInt return, and compare via Number in napi/create-uint64 The @example block and README C example referenced an err variable that stdlib_napi_create_uint64 never produces; added the missing C API note that the generated JavaScript value is a BigInt (matching create-int64); the native test compared the returned BigInt to a Number via strictEqual. --- lib/node_modules/@stdlib/napi/create-uint64/README.md | 6 ++---- lib/node_modules/@stdlib/napi/create-uint64/src/main.c | 4 ---- .../@stdlib/napi/create-uint64/test/test.native.js | 3 ++- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/lib/node_modules/@stdlib/napi/create-uint64/README.md b/lib/node_modules/@stdlib/napi/create-uint64/README.md index fbfa1ad29021..2a72f3a276fc 100644 --- a/lib/node_modules/@stdlib/napi/create-uint64/README.md +++ b/lib/node_modules/@stdlib/napi/create-uint64/README.md @@ -119,10 +119,6 @@ static napi_value addon( napi_env env, napi_callback_info info ) { napi_value value; napi_status status = stdlib_napi_create_uint64( env, 1, &value ); assert( status == napi_ok ); - if ( err != NULL ) { - assert( napi_throw( env, err ) == napi_ok ); - return NULL; - } // ... } @@ -187,6 +183,8 @@ The macro expects the following arguments:
+- The generated JavaScript value is a `BigInt` (N-API Version 6+). +
diff --git a/lib/node_modules/@stdlib/napi/create-uint64/src/main.c b/lib/node_modules/@stdlib/napi/create-uint64/src/main.c index 86e1d21176f8..006ac98797ef 100644 --- a/lib/node_modules/@stdlib/napi/create-uint64/src/main.c +++ b/lib/node_modules/@stdlib/napi/create-uint64/src/main.c @@ -40,10 +40,6 @@ * napi_value value; * napi_status status = stdlib_napi_create_uint64( env, 1, &value ); * assert( status == napi_ok ); -* if ( err != NULL ) { -* assert( napi_throw( env, err ) == napi_ok ); -* return NULL; -* } * * // ... * } diff --git a/lib/node_modules/@stdlib/napi/create-uint64/test/test.native.js b/lib/node_modules/@stdlib/napi/create-uint64/test/test.native.js index 88a9aa83a464..34f9dc078316 100644 --- a/lib/node_modules/@stdlib/napi/create-uint64/test/test.native.js +++ b/lib/node_modules/@stdlib/napi/create-uint64/test/test.native.js @@ -22,6 +22,7 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var Number = require( '@stdlib/number/ctor' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -78,7 +79,7 @@ tape( 'the function does not throw an error if provided a non-negative number', ]; for ( i = 0; i < values.length; i++ ) { v = addon( values[ i ] ); - t.strictEqual( v, values[ i ], 'returns expected value when provided '+values[ i ] ); + t.strictEqual( Number( v ), values[ i ], 'returns expected value when provided '+values[ i ] ); } t.end(); }); From 3b18bd65c86bb8dccf44827e1886d6b9102af03f Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 18 Apr 2026 22:36:39 +0000 Subject: [PATCH 3/4] style: add missing eslint no-undef directive to ndarray/colcat Examples block Matches the convention used across every other @stdlib/ndarray top-level README. --- lib/node_modules/@stdlib/ndarray/colcat/README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/node_modules/@stdlib/ndarray/colcat/README.md b/lib/node_modules/@stdlib/ndarray/colcat/README.md index 1e0bb4818d2c..89fe4d9d227c 100644 --- a/lib/node_modules/@stdlib/ndarray/colcat/README.md +++ b/lib/node_modules/@stdlib/ndarray/colcat/README.md @@ -111,6 +111,8 @@ The function accepts the following arguments: ## Examples + + ```javascript var discreteUniform = require( '@stdlib/random/discrete-uniform' ); var ndarray2array = require( '@stdlib/ndarray/to-array' ); From 10fe444c1fa5088f2cdd0d9747f9d12cff50d5f7 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 19 Apr 2026 05:31:55 +0000 Subject: [PATCH 4/4] revert: restore original BigInt assertions in napi/create-int64 and napi/create-uint64 native tests The lib/native.js wrapper already coerces the addon return value via Number(), so the prior strictEqual was sound. Drop the redundant Number() coercion and the unused @stdlib/number/ctor import. --- lib/node_modules/@stdlib/napi/create-int64/test/test.native.js | 3 +-- .../@stdlib/napi/create-uint64/test/test.native.js | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/node_modules/@stdlib/napi/create-int64/test/test.native.js b/lib/node_modules/@stdlib/napi/create-int64/test/test.native.js index 4ca6051d5c92..f3c58999e549 100644 --- a/lib/node_modules/@stdlib/napi/create-int64/test/test.native.js +++ b/lib/node_modules/@stdlib/napi/create-int64/test/test.native.js @@ -22,7 +22,6 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var Number = require( '@stdlib/number/ctor' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -79,7 +78,7 @@ tape( 'the function does not throw an error if provided a number', opts, functio ]; for ( i = 0; i < values.length; i++ ) { v = addon( values[ i ] ); - t.strictEqual( Number( v ), values[ i ], 'returns expected value when provided '+values[ i ] ); + t.strictEqual( v, values[ i ], 'returns expected value when provided '+values[ i ] ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/napi/create-uint64/test/test.native.js b/lib/node_modules/@stdlib/napi/create-uint64/test/test.native.js index 34f9dc078316..88a9aa83a464 100644 --- a/lib/node_modules/@stdlib/napi/create-uint64/test/test.native.js +++ b/lib/node_modules/@stdlib/napi/create-uint64/test/test.native.js @@ -22,7 +22,6 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var Number = require( '@stdlib/number/ctor' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -79,7 +78,7 @@ tape( 'the function does not throw an error if provided a non-negative number', ]; for ( i = 0; i < values.length; i++ ) { v = addon( values[ i ] ); - t.strictEqual( Number( v ), values[ i ], 'returns expected value when provided '+values[ i ] ); + t.strictEqual( v, values[ i ], 'returns expected value when provided '+values[ i ] ); } t.end(); });