Skip to content

docs: remove stray err handling in examples and enable lint rule #11556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 4 commits into from
Apr 19, 2026
Merged

docs: remove stray err handling in examples and enable lint rule #11556

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
480bda5
fix: drop undeclared err check and compare BigInt via Number in napi/…
claude Apr 18, 2026
cfe45e8
fix: drop undeclared err check, document BigInt return, and compare v…
claude Apr 18, 2026
3b18bd6
style: add missing eslint no-undef directive to ndarray/colcat Exampl…
claude Apr 18, 2026
10fe444
revert: restore original BigInt assertions in napi/create-int64 and n…
claude Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/node_modules/@stdlib/napi/create-int64/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,6 @@ static napi_value addon( napi_env env, napi_callback_info info ) {
napi_value value;
napi_status status = stdlib_napi_create_int64( env, 1, &value );
assert( status == napi_ok );
if ( err != NULL ) {
assert( napi_throw( env, err ) == napi_ok );
return NULL;
}

// ...
}
Expand Down
4 changes: 0 additions & 4 deletions lib/node_modules/@stdlib/napi/create-int64/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@
* napi_value value;
* napi_status status = stdlib_napi_create_int64( env, 1, &value );
* assert( status == napi_ok );
* if ( err != NULL ) {
* assert( napi_throw( env, err ) == napi_ok );
* return NULL;
* }
*
* // ...
* }
Expand Down
3 changes: 2 additions & 1 deletion lib/node_modules/@stdlib/napi/create-int64/test/test.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

var resolve = require( 'path' ).resolve;
var tape = require( 'tape' );
var Number = require( '@stdlib/number/ctor' );
var tryRequire = require( '@stdlib/utils/try-require' );


Expand Down Expand Up @@ -78,7 +79,7 @@ tape( 'the function does not throw an error if provided a number', opts, functio
];
for ( i = 0; i < values.length; i++ ) {
v = addon( values[ i ] );
t.strictEqual( v, values[ i ], 'returns expected value when provided '+values[ i ] );
t.strictEqual( Number( v ), values[ i ], 'returns expected value when provided '+values[ i ] );
Comment thread
kgryte marked this conversation as resolved.
Outdated
}
t.end();
});
6 changes: 2 additions & 4 deletions lib/node_modules/@stdlib/napi/create-uint64/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,6 @@ static napi_value addon( napi_env env, napi_callback_info info ) {
napi_value value;
napi_status status = stdlib_napi_create_uint64( env, 1, &value );
assert( status == napi_ok );
if ( err != NULL ) {
assert( napi_throw( env, err ) == napi_ok );
return NULL;
}

// ...
}
Expand Down Expand Up @@ -187,6 +183,8 @@ The macro expects the following arguments:

<section class="notes">

- The generated JavaScript value is a `BigInt` (N-API Version 6+).

</section>

<!-- /.notes -->
Expand Down
4 changes: 0 additions & 4 deletions lib/node_modules/@stdlib/napi/create-uint64/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@
* napi_value value;
* napi_status status = stdlib_napi_create_uint64( env, 1, &value );
* assert( status == napi_ok );
* if ( err != NULL ) {
* assert( napi_throw( env, err ) == napi_ok );
* return NULL;
* }
*
* // ...
* }
Expand Down
3 changes: 2 additions & 1 deletion lib/node_modules/@stdlib/napi/create-uint64/test/test.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

var resolve = require( 'path' ).resolve;
var tape = require( 'tape' );
var Number = require( '@stdlib/number/ctor' );
var tryRequire = require( '@stdlib/utils/try-require' );


Expand Down Expand Up @@ -78,7 +79,7 @@ tape( 'the function does not throw an error if provided a non-negative number',
];
for ( i = 0; i < values.length; i++ ) {
v = addon( values[ i ] );
t.strictEqual( v, values[ i ], 'returns expected value when provided '+values[ i ] );
t.strictEqual( Number( v ), values[ i ], 'returns expected value when provided '+values[ i ] );
Comment thread
kgryte marked this conversation as resolved.
Outdated
}
t.end();
});
2 changes: 2 additions & 0 deletions lib/node_modules/@stdlib/ndarray/colcat/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ The function accepts the following arguments:

## Examples

<!-- eslint no-undef: "error" -->

```javascript
var discreteUniform = require( '@stdlib/random/discrete-uniform' );
var ndarray2array = require( '@stdlib/ndarray/to-array' );
Expand Down
Loading